Help required in a Stored Procedure

Question

I have a stored procedure as follows:
create or replace
PROCEDURE ACCOUNT_HISTORY_PROC_TEST (v_accountid IN VARCHAR2 DEFAULT NULL,
                                        v_enddate IN Date DEFAULT NULL,
                                        cv_1 IN OUT SYS_REFCURSOR,
                                        flag IN INTEGER,
                                        v_Error OUT NOCOPY NVARCHAR2
                                      ) AS
   DAY_1 varchar(4000);
   DAY_2 varchar(4000);
   DAY_3 varchar(4000);
   DAY_4 varchar(4000);
   DAY_5 varchar(4000);
   DAY_6 varchar(4000);
   days_Diff number default 0;
   currdate date;
BEGIN --Stored Procedure Beginning
/*If the Account History Table has the Account Id then the following will be executed*/
   IF flag = 0 THEN --1st IF
     Select CurrentDate,DAY2,DAY3,DAY4,DAY5,DAY6 into currdate,DAY_2,DAY_3,DAY_4,DAY_5,DAY_6 from ACCOUNT_STATS_TABLE where Account_id = v_AccountId;
/*If the transaction is on the same day then the following will be executed*/
      IF currdate = v_endDate THEN --2nd IF
          OPEN cv_1 FOR
                Select DEPOSIT_CNT,DEPOSIT_AMT,WITHDRAWAL_CNT,WITHDRAWAL_AMT,ATM_CREDIT_CNT,ATM_CREDIT_AMT,ATM_DEBIT_CNT,ATM_DEBIT_AMT,CASH_CREDIT_CNT,CASH_CREDIT_AMT,CASH_DEBIT_CNT,CASH_DEBIT_AMT,CLRNG_CREDIT_CNT,CLRNG_CREDIT_AMT,CLRNG_DEBIT_CNT,CLRNG_DEBIT_AMT,TRANSFER_CREDIT_CNT,TRANSFER_CREDIT_AMT,TRANSFER_DEBIT_CNT,TRANSFER_DEBIT_AMT,CUMMULATIVE_CNT,CUMMULATIVE_AMT,CASH_COUNT,CASH_AMOUNT,DAY1,DAY2,DAY3,DAY4,DAY5,DAY6,CDAY_DEPOSIT_COUNT,CDAY_DEPOSIT_AMOUNT,CDAY_WITHDRAWAL_COUNT,CDAY_WITHDRAWAL_AMOUNT,CDAY_ATM_CREDITTXN_COUNT,CDAY_ATM_CREDITTXN_AMOUNT,CDAY_ATM_DEBITTXN_COUNT,CDAY_ATM_DEBITTXN_AMOUNT,CDAY_CASH_CREDITTXN_COUNT,CDAY_CASH_CREDITTXN_AMOUNT,CDAY_CASH_DEBITTXN_COUNT,CDAY_CASH_DEBITTXN_AMOUNT,CDAY_CLEARING_CREDITTXN_COUNT,CDAY_CLEARING_CREDITTXN_AMOUNT,CDAY_CLEARING_DEBITTXN_COUNT,CDAY_CLEARING_DEBITTXN_AMOUNT,CDAY_TRANSFER_CREDITTXN_COUNT,CDAY_TRANSFER_CREDITTXN_AMOUNT,CDAY_TRANSFER_DEBITTXN_COUNT,CDAY_TRANSFER_DEBITTXN_AMOUNT,CDAY_CUMMULATIVETXN_COUNT,CDAY_CUMMULATIVETXN_AMOUNT,CDAY_CASH_TXN_COUNT,CDAY_CASH_TXN_AMOUNT,CURRENTDATE from ACCOUNT_STATS_TABLE where Account_id = v_AccountId;
/*If the transaction is not on the same day then the DAY1,DAY2,DAY3,DAY4,DAY5,DAY6 columns will be shifted which will be done in the following part*/
      ELSE --2nd ELSE
        days_diff:=v_endDate-currdate;
        FOR i IN 1..days_diff LOOP
        DAY_1:=DAY_2;
        DAY_2:=DAY_3;
        DAY_3:=DAY_4;
        DAY_4:=DAY_5;
        DAY_5:=DAY_6;
        DAY_6:='0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0';
        END LOOP;
                  Update ACCOUNT_STATS_TABLE
                            set DAY1 = DAY_1,
                                DAY2 = DAY_2,
                                DAY3 = DAY_3,
                                DAY4 = DAY_4,
                                DAY5 = DAY_5,
                                DAY6 = DAY_6,
                                CDAY_DEPOSIT_COUNT=0,
                                CDAY_DEPOSIT_AMOUNT=0,
                                CDAY_WITHDRAWAL_COUNT=0,
                                CDAY_WITHDRAWAL_AMOUNT=0,
                                CDAY_ATM_CREDITTXN_COUNT=0,
                                CDAY_ATM_CREDITTXN_AMOUNT=0,
                                CDAY_ATM_DEBITTXN_COUNT=0,
                                CDAY_ATM_DEBITTXN_AMOUNT=0,
                                CDAY_CASH_CREDITTXN_COUNT=0,
                                CDAY_CASH_CREDITTXN_AMOUNT=0,
                                CDAY_CASH_DEBITTXN_COUNT=0,
                                CDAY_CASH_DEBITTXN_AMOUNT=0,
                                CDAY_CLEARING_CREDITTXN_COUNT=0,
                                CDAY_CLEARING_CREDITTXN_AMOUNT=0,
                                CDAY_CLEARING_DEBITTXN_COUNT=0,
                                CDAY_CLEARING_DEBITTXN_AMOUNT=0,
                                CDAY_TRANSFER_CREDITTXN_COUNT=0,
                                CDAY_TRANSFER_CREDITTXN_AMOUNT=0,
                                CDAY_TRANSFER_DEBITTXN_COUNT=0,
                                CDAY_TRANSFER_DEBITTXN_AMOUNT=0,
                                CDAY_CUMMULATIVETXN_COUNT=0,
                                CDAY_CUMMULATIVETXN_AMOUNT=0,
                                CDAY_CASH_TXN_COUNT=0,
                                CDAY_CASH_TXN_AMOUNT=0,
                                CurrentDate = v_enddate
                                where Account_id = v_accountid;
      open cv_1 for
          Select DEPOSIT_CNT,DEPOSIT_AMT,WITHDRAWAL_CNT,WITHDRAWAL_AMT,ATM_CREDIT_CNT,ATM_CREDIT_AMT,ATM_DEBIT_CNT,ATM_DEBIT_AMT,CASH_CREDIT_CNT,CASH_CREDIT_AMT,CASH_DEBIT_CNT,CASH_DEBIT_AMT,CLRNG_CREDIT_CNT,CLRNG_CREDIT_AMT,CLRNG_DEBIT_CNT,CLRNG_DEBIT_AMT,TRANSFER_CREDIT_CNT,TRANSFER_CREDIT_AMT,TRANSFER_DEBIT_CNT,TRANSFER_DEBIT_AMT,CUMMULATIVE_CNT,CUMMULATIVE_AMT,CASH_COUNT,CASH_AMOUNT,DAY1,DAY2,DAY3,DAY4,DAY5,DAY6,CDAY_DEPOSIT_COUNT,CDAY_DEPOSIT_AMOUNT,CDAY_WITHDRAWAL_COUNT,CDAY_WITHDRAWAL_AMOUNT,CDAY_ATM_CREDITTXN_COUNT,CDAY_ATM_CREDITTXN_AMOUNT,CDAY_ATM_DEBITTXN_COUNT,CDAY_ATM_DEBITTXN_AMOUNT,CDAY_CASH_CREDITTXN_COUNT,CDAY_CASH_CREDITTXN_AMOUNT,CDAY_CASH_DEBITTXN_COUNT,CDAY_CASH_DEBITTXN_AMOUNT,CDAY_CLEARING_CREDITTXN_COUNT,CDAY_CLEARING_CREDITTXN_AMOUNT,CDAY_CLEARING_DEBITTXN_COUNT,CDAY_CLEARING_DEBITTXN_AMOUNT,CDAY_TRANSFER_CREDITTXN_COUNT,CDAY_TRANSFER_CREDITTXN_AMOUNT,CDAY_TRANSFER_DEBITTXN_COUNT,CDAY_TRANSFER_DEBITTXN_AMOUNT,CDAY_CUMMULATIVETXN_COUNT,CDAY_CUMMULATIVETXN_AMOUNT,CDAY_CASH_TXN_COUNT,CDAY_CASH_TXN_AMOUNT,CURRENTDATE from ACCOUNT_STATS_TABLE where Account_id = v_AccountId;
      END IF; --END 2nd IF
/*If the Account History Table does not have Account Id then the following will be executed*/
ELSE --1st ELSE
/*If the transaction is in the middle of the month then the AH_PROC_REVISED Stored Procedure will be called*/     
          AH_PROC(v_accountid,v_enddate);
      open cv_1 for
      Select DEPOSIT_CNT,DEPOSIT_AMT,WITHDRAWAL_CNT,WITHDRAWAL_AMT,ATM_CREDIT_CNT,ATM_CREDIT_AMT,ATM_DEBIT_CNT,ATM_DEBIT_AMT,CASH_CREDIT_CNT,CASH_CREDIT_AMT,CASH_DEBIT_CNT,CASH_DEBIT_AMT,CLRNG_CREDIT_CNT,CLRNG_CREDIT_AMT,CLRNG_DEBIT_CNT,CLRNG_DEBIT_AMT,TRANSFER_CREDIT_CNT,TRANSFER_CREDIT_AMT,TRANSFER_DEBIT_CNT,TRANSFER_DEBIT_AMT,CUMMULATIVE_CNT,CUMMULATIVE_AMT,CASH_COUNT,CASH_AMOUNT,DAY1,DAY2,DAY3,DAY4,DAY5,DAY6,CDAY_DEPOSIT_COUNT,CDAY_DEPOSIT_AMOUNT,CDAY_WITHDRAWAL_COUNT,CDAY_WITHDRAWAL_AMOUNT,CDAY_ATM_CREDITTXN_COUNT,CDAY_ATM_CREDITTXN_AMOUNT,CDAY_ATM_DEBITTXN_COUNT,CDAY_ATM_DEBITTXN_AMOUNT,CDAY_CASH_CREDITTXN_COUNT,CDAY_CASH_CREDITTXN_AMOUNT,CDAY_CASH_DEBITTXN_COUNT,CDAY_CASH_DEBITTXN_AMOUNT,CDAY_CLEARING_CREDITTXN_COUNT,CDAY_CLEARING_CREDITTXN_AMOUNT,CDAY_CLEARING_DEBITTXN_COUNT,CDAY_CLEARING_DEBITTXN_AMOUNT,CDAY_TRANSFER_CREDITTXN_COUNT,CDAY_TRANSFER_CREDITTXN_AMOUNT,CDAY_TRANSFER_DEBITTXN_COUNT,CDAY_TRANSFER_DEBITTXN_AMOUNT,CDAY_CUMMULATIVETXN_COUNT,CDAY_CUMMULATIVETXN_AMOUNT,CDAY_CASH_TXN_COUNT,CDAY_CASH_TXN_AMOUNT,CURRENTDATE from ACCOUNT_STATS_TABLE where Account_id = v_AccountId;
END IF; --END 1st IF
EXCEPTION
   WHEN OTHERS THEN
  -- open cv_1 for Select DEPOSIT_CNT,DEPOSIT_AMT,WITHDRAWAL_CNT,WITHDRAWAL_AMT,ATM_CREDIT_CNT,ATM_CREDIT_AMT,ATM_DEBIT_CNT,ATM_DEBIT_AMT,CASH_CREDIT_CNT,CASH_CREDIT_AMT,CASH_DEBIT_CNT,CASH_DEBIT_AMT,CLRNG_CREDIT_CNT,CLRNG_CREDIT_AMT,CLRNG_DEBIT_CNT,CLRNG_DEBIT_AMT,TRANSFER_CREDIT_CNT,TRANSFER_CREDIT_AMT,TRANSFER_DEBIT_CNT,TRANSFER_DEBIT_AMT,CUMMULATIVE_CNT,CUMMULATIVE_AMT,CASH_COUNT,CASH_AMOUNT,DAY1,DAY2,DAY3,DAY4,DAY5,DAY6,CDAY_DEPOSIT_COUNT,CDAY_DEPOSIT_AMOUNT,CDAY_WITHDRAWAL_COUNT,CDAY_WITHDRAWAL_AMOUNT,CDAY_ATM_CREDITTXN_COUNT,CDAY_ATM_CREDITTXN_AMOUNT,CDAY_ATM_DEBITTXN_COUNT,CDAY_ATM_DEBITTXN_AMOUNT,CDAY_CASH_CREDITTXN_COUNT,CDAY_CASH_CREDITTXN_AMOUNT,CDAY_CASH_DEBITTXN_COUNT,CDAY_CASH_DEBITTXN_AMOUNT,CDAY_CLEARING_CREDITTXN_COUNT,CDAY_CLEARING_CREDITTXN_AMOUNT,CDAY_CLEARING_DEBITTXN_COUNT,CDAY_CLEARING_DEBITTXN_AMOUNT,CDAY_TRANSFER_CREDITTXN_COUNT,CDAY_TRANSFER_CREDITTXN_AMOUNT,CDAY_TRANSFER_DEBITTXN_COUNT,CDAY_TRANSFER_DEBITTXN_AMOUNT,CDAY_CUMMULATIVETXN_COUNT,CDAY_CUMMULATIVETXN_AMOUNT,CDAY_CASH_TXN_COUNT,CDAY_CASH_TXN_AMOUNT,CURRENTDATE from ACCOUNT_STATS_TABLE where Account_id = v_AccountId;
  v_Error := SQLERRM;
  --dbms_output.PUT_LINE('No data');
END ; --Stored Procedure End hereI want to modify this a little..
What i am doing right now is if flag = 0, then I am getting some values from the Account_Stats_Table and comapring if the current_datereturn from the table is same as the passed date..If same then, i return the cursor having the values for the passed accountid..There is two time querying of the table..
I want to avoid querying the table twice..If current date and passed date both are same then, let it return the results of the opened cursor.. How can i do it.. How can i avoid issuing select queries twice.. Please help..

Answer 1

You can try this:
IF flag = 0 THEN --1st IF
OPEN cv_1 FOR
Select DEPOSIT_CNT,DEPOSIT_AMT,WITHDRAWAL_CNT,WITHDRAWAL_AMT,ATM_CREDIT_CNT,ATM_CREDIT_AMT,ATM_DEBIT_CNT,ATM_DEBIT_AMT,CASH_CREDIT_CNT,CASH_CREDIT_AMT,CASH_DEBIT_CNT,CASH_DEBIT_AMT,CLRNG_CREDIT_CNT,CLRNG_CREDIT_AMT,CLRNG_DEBIT_CNT,CLRNG_DEBIT_AMT,TRANSFER_CREDIT_CNT,TRANSFER_CREDIT_AMT,TRANSFER_DEBIT_CNT,TRANSFER_DEBIT_AMT,CUMMULATIVE_CNT,CUMMULATIVE_AMT,CASH_COUNT,CASH_AMOUNT,DAY1,DAY2,DAY3,DAY4,DAY5,DAY6,CDAY_DEPOSIT_COUNT,CDAY_DEPOSIT_AMOUNT,CDAY_WITHDRAWAL_COUNT,CDAY_WITHDRAWAL_AMOUNT,CDAY_ATM_CREDITTXN_COUNT,CDAY_ATM_CREDITTXN_AMOUNT,CDAY_ATM_DEBITTXN_COUNT,CDAY_ATM_DEBITTXN_AMOUNT,CDAY_CASH_CREDITTXN_COUNT,CDAY_CASH_CREDITTXN_AMOUNT,CDAY_CASH_DEBITTXN_COUNT,CDAY_CASH_DEBITTXN_AMOUNT,CDAY_CLEARING_CREDITTXN_COUNT,CDAY_CLEARING_CREDITTXN_AMOUNT,CDAY_CLEARING_DEBITTXN_COUNT,CDAY_CLEARING_DEBITTXN_AMOUNT,CDAY_TRANSFER_CREDITTXN_COUNT,CDAY_TRANSFER_CREDITTXN_AMOUNT,CDAY_TRANSFER_DEBITTXN_COUNT,CDAY_TRANSFER_DEBITTXN_AMOUNT,CDAY_CUMMULATIVETXN_COUNT,CDAY_CUMMULATIVETXN_AMOUNT,CDAY_CASH_TXN_COUNT,CDAY_CASH_TXN_AMOUNT,CURRENTDATE
from
ACCOUNT_STATS_TABLE
where
Account_id = v_AccountId AND CurrentDate = v_enddate;