Help writing a simple stored procedure

Question

Hello, all:
I have normally done fine writing functional anonymous procedures, but I want to tighten up my trade a little. I have been looking through my PL/SQL book and the examples are too simple for the creation of a stored procedure along these lines:
create or replace procedure convertPIDM( iv_PIDM number)
is
v_PIDM number;
v_Banner_ID varchar2;
v_first_name varchar2;
v_first_name varchar2;
begin
/* select spriden_id, spriden_first_name, spriden_last_name from spriden */
select spriden_id into v_Banner_ID from spriden
where spriden_pidm = iv_PIDM
and spriden_change_ind is null;
DBMS_OUTPUT.put_line('Banner ID: ' || v_Banner_ID );
end;
I am getting a "Warning: compiled but with compilation errors." I don't understand why. Could someone point the issue out to me, please.
Thank you.

Answer 1

Okay, the answer almost bit me. I forget to add the size (ranges) to the varchar2.
create or replace procedure convertPIDM( iv_PIDM number)
is
v_PIDM number;
v_Banner_ID varchar2(8);
v_first_name varchar2(30);
v_first_name varchar2(30);
begin
--select spriden_id, spriden_first_name, spriden_last_name from spriden
select spriden_id into v_Banner_ID from spriden
where spriden_pidm = iv_PIDM
and spriden_change_ind is null;
DBMS_OUTPUT.put_line('Banner ID: ' || v_Banner_ID );
end;
show errors