Help to improve this code
Hi all,
This is the scenario;
I have a selection screen with all the field of a custom table, all the selection fields are parameters not ranges...
ok, i need to make a select statement only with the fields are filled.
I did the following:
(All the fields of my selection screen are stored in the structuer ls_selection_screen)
DATA: lv_cond_syntax TYPE string,
lv_field2read TYPE string,
lt_fields TYPE TABLE OF dd03l,
ls_fields LIKE LINE OF lt_campos,
lv_number TYPE CHAR24,
lv_cont TYPE i.
* Get all the field of my custom table;
SELECT * INTO TABLE lt_fields
FROM dd03l WHERE tabname EQ 'ZMYCUSTOMTABLE'.
* Fill the WHERE conditons
LOOP AT lt_fields INTO ls_fields.
ASSIGN COMPONENT ls_fields-fieldname OF STRUCTURE ls_selection_screen TO <fs_field>.
CHECK sy-subrc EQ 0.
* Add the field only if are filled;
CHECK <fs_field> IS NOT INITIAL.
ADD 1 TO lv_cont.
* --- Concatenate the field to the WHERE ---- *
IF lv_cont GT 1. "The first without 'AND'
CONCATENATE lv_cond_syntax 'AND' INTO lv_cond_syntax SEPARATED BY SPACE.
ENDIF.
* Concatenate field's value with quotation marks
IF ls_fields-inttype EQ 'P' OR ls_fields-inttype EQ 'F' OR ls_fields-inttype EQ 'I'.
* If is numeric, first we must to translate the value to a character type var...
WRITE <fs_field> TO lv_number LEFT-JUSTIFIED.
REPLACE ',' WITH '.' INTO lv_number.
CONCATENATE '''' lv_number '''' INTO lv_field2read.
ELSE.
CONCATENATE '''' <fs_field> '''' INTO lv_field2read.
ENDIF.
CONCATENATE lv_cond_syntax ls_fields-fieldname 'EQ' lv_field2read INTO lv_cond_syntax SEPARATED BY SPACE.
ENDLOOP.
* Select data:
SELECT * INTO CORRESPONDING FIELDS OF TABLE lt_my_table
FROM ZMYCUSTOMTABLE
WHERE (lv_cond_syntax).
Works fine, but i don't know it is there any other easiest way to do it...
Thanks in advance.
Moderator message: please choose more descriptive subject lines for your posts.
Edited by: Thomas Zloch on May 24, 2011 3:08 PM
the first part seems to be o.k., I don't see serious performance problems
But be aware that the generated SELECT can have kind of performance from extremely good to extremely poor.
Select data:
SELECT * INTO CORRESPONDING FIELDS OF TABLE lt_my_table
FROM ZMYCUSTOMTABLE
WHERE (lv_cond_syntax).
Similar Messages
-
Can somebody help me with this code?
Can anyone help me with this code? My problem is that i can't
seem to position this form, i want to be able to center it
vertically & horizontally in a div either using CSS or any
other means.
<div id="searchbar"><!--Search Bar -->
<div id="searchcart">
<div class="serchcartcont">
<form action='
http://www.romancart.com/search.asp'
name="engine" target=searchwin id="engine">
<input type=hidden value=????? name=storeid>
<input type=text value='' name=searchterm>
<input type=submit value='Go'> </form>
</div>
</div>
<div class="searchcont">Search For
Products:</div>
</div><!-- End Search Bar -->
Pleasssssseeeeeeee Help
ThanksHi,
Your form is defined in a div named "serchcartcont", you can
use attributes like position and align of the div to do what you
want to do. But there are two more dives above this dive, you will
have define the height width of these before you can center align
the inner most div. If you are not defining the height & width
then by default it decide it automatically to just fit the content
in it.
Hope this helps.
Maneet
LeXolution IT Services
Web Development
Company -
Hi guys, I need help in debugging this code I made, which is a GUI minesweeper. Its extremely buggy...I particularly need help fixing the actionListener part of the code as everytime I press a button on the GUI, an exception occurs.
help please!
package minesweeperGUI;
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
public class MinesweeperGUI implements ActionListener
//Declaration of attributes
static int length = 0;
JMenuItem menuItemNew = new JMenuItem();
JRadioButtonMenuItem rbEasy = new JRadioButtonMenuItem();
JRadioButtonMenuItem rbHard = new JRadioButtonMenuItem();
JMenuItem menuItemExit = new JMenuItem();
JButton buttonReset = new JButton();
JButton buttonGrid[][] = null;
JFrame frame = new JFrame();
int getBombsTotal = 0;
JLabel setBombsLabel = new JLabel();
int a = 0;
int b = 0;
//No constructor created. Uses default constructor
//Create the menu bar
public JMenuBar newMenuBar()
//Sets up the menubar
JMenuBar menuBar = new JMenuBar();
//Sets up the Game menu with choice of new, grid size, and exit
JMenu menu = new JMenu ("Game");
menuBar.add (menu);
menuItemNew = new JMenuItem ("New");
menuItemNew.addActionListener (this);
menu.add (menuItemNew);
menu.addSeparator();
//Sets up sub-menu for grid size with choice of easy and hard radio buttons
JMenu subMenu = new JMenu ("Grid Size");
rbEasy = new JRadioButtonMenuItem ("Easy: 5x5 grid");
rbEasy.addActionListener (this);
subMenu.add (rbEasy);
rbHard = new JRadioButtonMenuItem ("Hard: 10x10 grid");
rbHard.addActionListener (this);
subMenu.add (rbHard);
menu.add (subMenu);
menu.addSeparator();
menuItemExit = new JMenuItem ("Exit");
menuItemExit.addActionListener (this);
menu.add (menuItemExit);
return menuBar;
//Setting up of Bomb Grid
public int [][] setGrid (int length)
int grid[][] = null;
grid = new int[length][length];
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
grid[i][j] = ((int)Math.round(Math.random() * 10))% 2;
return grid;
//Setting up of the of the graphical bomb grid
public JButton[][] setButtonGrid (int length)
JButton buttonGrid[][] = null;
buttonGrid = new JButton[length][length];
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
buttonGrid[i][j] = new JButton();
return buttonGrid;
//Setting up of a way to count the total number of bombs in the bomb grid
public int getBombsTotal (int length, int setGrid[][])
int bombsTotal = 0;
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
if (setGrid[i][j] == 1)
bombsTotal += 1;
return bombsTotal;
//Create a label for number of bombs left
public JLabel setBombsLabel (int getBombsTotal)
JLabel bombsLabel = new JLabel(String.valueOf (getBombsTotal) + " Bombs Left");
return bombsLabel;
//Setting up a way to count the number of bombs around a button
public String setBombs (int length, int setGrid[][], int x, int y)
int bombs[][] = new int[length][length];
String bombsString = null;
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
if (i == 0 && j == 0)
bombs[i][j] = setGrid[i][j+1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i ==0 && j == (length - 1))
bombs[i][j] = setGrid[i][j-1] + setGrid[i+1][j-1] +
setGrid[i+1][j];
else if (i == (length - 1) && j == 0)
bombs[i][j] = setGrid[i-1][j] + setGrid[i-1][j+1] +
setGrid[i][j+1];
else if (i == (length - 1) && j == (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i][j-1];
else if (i == 0 && j != 0 && j != (length - 1))
bombs[i][j] = setGrid[i][j-1] + setGrid[i][j+1] +
setGrid[i+1][j-1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i == (length - 1) && j != 0 && j != (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i-1][j+1] + setGrid[i][j-1] +
setGrid[i][j+1];
else if (i != 0 && i != (length - 1) && j == 0)
bombs[i][j] = setGrid[i-1][j] + setGrid[i-1][j+1] +
setGrid[i][j+1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i != 0 && i != (length - 1) && j == (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i][j-1] + setGrid[i+1][j-1] +
setGrid[i+1][j];
else
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i-1][j+1] + setGrid[i][j-1] +
setGrid[i][j+1] + setGrid[i+1][j-1] +
setGrid[i+1][j] + setGrid[i+1][j+1];
bombsString = String.valueOf (bombs[x][y]);
return bombsString;
//create the panel for the bombs label and reset button
public JPanel newTopPanel(int length)
int setGridNew [][] = null;
setGridNew = new int[length][length];
int getBombsTotalNew = 0;
JLabel setBombsLabelNew = new JLabel();
setGridNew = setGrid (length);
getBombsTotalNew = getBombsTotal (length, setGridNew);
setBombsLabelNew = setBombsLabel (getBombsTotalNew);
JPanel topPanel = new JPanel ();
topPanel.setLayout (new BorderLayout (50,50));
JLabel bombsLabel = new JLabel ();
bombsLabel = setBombsLabelNew;
topPanel.add (bombsLabel, BorderLayout.WEST);
buttonReset = new JButton("Reset");
buttonReset.addActionListener (this);
topPanel.add (buttonReset, BorderLayout.CENTER);
return topPanel;
//create the panel for the play grids
public JPanel newBottomPanel(int length)
JButton setButtonGridNew[][] = null;
setButtonGridNew = new JButton [length][length];
setButtonGridNew = setButtonGrid (length);
JPanel bottomPanel = new JPanel ();
bottomPanel.setLayout (new GridLayout (length, length));
buttonGrid = new JButton[length][length];
for (a = 0; a < length; a++)
for (b = 0; b < length; b++)
buttonGrid[a] = setButtonGridNew[a][b];
buttonGrid[a][b].addActionListener (this);
bottomPanel.add (buttonGrid[a][b]);
return bottomPanel;
//Overiding of abstract method actionPerformed
public void actionPerformed(ActionEvent e)
if (e.getSource() == menuItemNew)
launchFrame(length);
else if (e.getSource() == menuItemExit)
frame.setVisible (false);
System.exit(0);
else if (e.getSource() == rbEasy)
length = 5;
launchFrame(length);
else if (e.getSource() == rbHard)
length = 10;
launchFrame(length);
else if (e.getSource() == buttonReset)
launchFrame(length);
else if (e.getSource() == buttonGrid[a][b])
int setGridNew [][] = null;
setGridNew = new int[length][length];
JButton bombButton [][] = null;
bombButton = new JButton [length][length];
String bombString [][] = null;
bombString = new String[length][length];
setGridNew = setGrid (length);
bombString[a][b] = setBombs (length, setGridNew, a, b);
bombButton[a][b] = new JButton (bombString[a][b]);
if (setGridNew[a][b] == 0)
buttonGrid[a][b] = bombButton[a][b];
getBombsTotal--;
JLabel setBombsLabelNew = new JLabel();
setBombsLabelNew = setBombsLabel (getBombsTotal);
else if (setGridNew[a][b] == 1 )
buttonGrid[a][b] = new JButton("x");
JOptionPane.showMessageDialog (null, "Game Over. You hit a Bomb!");
System.exit(0);
//create the content pane
public Container newContentPane(int length)
JPanel topPanel = new JPanel();
JPanel bottomPanel = new JPanel();
topPanel = newTopPanel(length);
bottomPanel = newBottomPanel (length);
JPanel contentPane = new JPanel();
contentPane.setOpaque (true);
contentPane.setLayout (new BorderLayout(50,50));
contentPane.add (topPanel, BorderLayout.NORTH);
contentPane.add (bottomPanel, BorderLayout.CENTER);
return contentPane;
public void launchFrame (int length)
//Makes sure we have nice window decorations
JFrame.setDefaultLookAndFeelDecorated(true);
//Sets up the top-level window
frame = new JFrame ("Minesweeper");
//Exits program when the closed button is clicked
frame.setDefaultCloseOperation (JFrame.EXIT_ON_CLOSE);
JMenuBar menuBar = new JMenuBar();
Container contentPane = new Container();
menuBar = newMenuBar();
contentPane = newContentPane (length);
//Sets up the menu bar and content pane
frame.setJMenuBar (menuBar);
frame.setContentPane (contentPane);
//Displays the window
frame.pack();
frame.setVisible (true);
public static void main (String args[])
//Default length is 5
length = 5;
MinesweeperGUI minesweeper = new MinesweeperGUI();
minesweeper.launchFrame(length);hi, thanks. that removed the exception; although now the buttons action listener won't work :(
here is the revised code:
To anyone out there, can you guys run this code and help me debug it?
I'm really desperate as this is a school project of mine and the deadline is 7 hours away. I have already been working on it for 3 days, but the program is still very buggy.
thanks!
/* Oliver Ian C. Wee 04-80112
* CS12 MHRU
* Machine Problem 2
package minesweeperGUI;
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
public class MinesweeperGUI implements ActionListener
//Declaration of attributes
static int length = 0;
JMenuItem menuItemNew = new JMenuItem();
JRadioButtonMenuItem rbEasy = new JRadioButtonMenuItem();
JRadioButtonMenuItem rbHard = new JRadioButtonMenuItem();
JMenuItem menuItemExit = new JMenuItem();
JButton buttonReset = new JButton();
JButton buttonGrid[][] = null;
JFrame frame = new JFrame();
int getBombsTotal = 0;
JLabel setBombsLabel = new JLabel();
int a = 0;
int b = 0;
//No constructor created. Uses default constructor
//Create the menu bar
public JMenuBar newMenuBar()
//Sets up the menubar
JMenuBar menuBar = new JMenuBar();
//Sets up the Game menu with choice of new, grid size, and exit
JMenu menu = new JMenu ("Game");
menuBar.add (menu);
menuItemNew = new JMenuItem ("New");
menuItemNew.addActionListener (this);
menu.add (menuItemNew);
menu.addSeparator();
//Sets up sub-menu for grid size with choice of easy and hard radio buttons
JMenu subMenu = new JMenu ("Grid Size");
ButtonGroup bg = new ButtonGroup();
rbEasy = new JRadioButtonMenuItem ("Easy: 5x5 grid");
bg.add (rbEasy);
rbEasy.addActionListener (this);
subMenu.add (rbEasy);
rbHard = new JRadioButtonMenuItem ("Hard: 10x10 grid");
bg.add (rbHard);
rbHard.addActionListener (this);
subMenu.add (rbHard);
menu.add (subMenu);
menu.addSeparator();
menuItemExit = new JMenuItem ("Exit");
menuItemExit.addActionListener (this);
menu.add (menuItemExit);
return menuBar;
//Setting up of Bomb Grid
public int [][] setGrid (int length)
int grid[][] = null;
grid = new int[length][length];
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
grid[i][j] = ((int)Math.round(Math.random() * 10))% 2;
return grid;
//Setting up of the of the graphical bomb grid
public JButton[][] setButtonGrid (int length)
JButton buttonGrid[][] = null;
buttonGrid = new JButton[length][length];
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
buttonGrid[i][j] = new JButton();
return buttonGrid;
//Setting up of a way to count the total number of bombs in the bomb grid
public int getBombsTotal (int length, int setGrid[][])
int bombsTotal = 0;
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
if (setGrid[i][j] == 1)
bombsTotal += 1;
return bombsTotal;
//Create a label for number of bombs left
public JLabel setBombsLabel (int getBombsTotal)
JLabel bombsLabel = new JLabel(" " +String.valueOf (getBombsTotal) + " Bombs Left");
return bombsLabel;
//Setting up a way to count the number of bombs around a button
public String setBombs (int length, int setGrid[][], int x, int y)
int bombs[][] = new int[length][length];
String bombsString = null;
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
if (i == 0 && j == 0)
bombs[i][j] = setGrid[i][j+1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i ==0 && j == (length - 1))
bombs[i][j] = setGrid[i][j-1] + setGrid[i+1][j-1] +
setGrid[i+1][j];
else if (i == (length - 1) && j == 0)
bombs[i][j] = setGrid[i-1][j] + setGrid[i-1][j+1] +
setGrid[i][j+1];
else if (i == (length - 1) && j == (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i][j-1];
else if (i == 0 && j != 0 && j != (length - 1))
bombs[i][j] = setGrid[i][j-1] + setGrid[i][j+1] +
setGrid[i+1][j-1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i == (length - 1) && j != 0 && j != (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i-1][j+1] + setGrid[i][j-1] +
setGrid[i][j+1];
else if (i != 0 && i != (length - 1) && j == 0)
bombs[i][j] = setGrid[i-1][j] + setGrid[i-1][j+1] +
setGrid[i][j+1] + setGrid[i+1][j] +
setGrid[i+1][j+1];
else if (i != 0 && i != (length - 1) && j == (length - 1))
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i][j-1] + setGrid[i+1][j-1] +
setGrid[i+1][j];
else
bombs[i][j] = setGrid[i-1][j-1] + setGrid[i-1][j] +
setGrid[i-1][j+1] + setGrid[i][j-1] +
setGrid[i][j+1] + setGrid[i+1][j-1] +
setGrid[i+1][j] + setGrid[i+1][j+1];
bombsString = String.valueOf (bombs[x][y]);
return bombsString;
//create the panel for the bombs label and reset button
public JPanel newTopPanel(int length)
int setGridNew [][] = null;
setGridNew = new int[length][length];
int getBombsTotalNew = 0;
JLabel setBombsLabelNew = new JLabel();
setGridNew = setGrid (length);
getBombsTotalNew = getBombsTotal (length, setGridNew);
setBombsLabelNew = setBombsLabel (getBombsTotalNew);
JPanel topPanel = new JPanel ();
topPanel.setLayout (new BorderLayout (20,20));
JLabel bombsLabel = new JLabel ();
bombsLabel = setBombsLabelNew;
topPanel.add (bombsLabel, BorderLayout.WEST);
buttonReset = new JButton("Reset");
buttonReset.addActionListener (this);
topPanel.add (buttonReset, BorderLayout.CENTER);
return topPanel;
//create the panel for the play grids
public JPanel newBottomPanel(int length)
JButton setButtonGridNew[][] = null;
setButtonGridNew = new JButton [length][length];
setButtonGridNew = setButtonGrid (length);
JPanel bottomPanel = new JPanel ();
bottomPanel.setLayout (new GridLayout (length, length));
buttonGrid = new JButton[length][length];
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
buttonGrid[i][j] = setButtonGridNew[i][j];
buttonGrid[i][j].addActionListener (this);
bottomPanel.add (buttonGrid[i][j]);
return bottomPanel;
//Overiding of abstract method actionPerformed
public void actionPerformed(ActionEvent e)
if (e.getSource() == menuItemNew)
closeFrame();
launchFrame(length);
else if (e.getSource() == menuItemExit)
frame.setVisible (false);
System.exit(0);
else if (e.getSource() == rbEasy)
closeFrame();
length = 5;
launchFrame(length);
else if (e.getSource() == rbHard)
closeFrame();
length = 10;
launchFrame(length);
else if (e.getSource() == buttonReset)
closeFrame();
launchFrame(length);
else if (e.getSource() == buttonGrid[a])
int setGridNew [][] = null;
setGridNew = new int[length][length];
JButton bombButton [][] = null;
bombButton = new JButton [length][length];
String bombString [][] = null;
bombString = new String[length][length];
setGridNew = setGrid (length);
for (int i = 0; i < length; i++)
for (int j = 0; j < length; j++)
bombString[i][j] = setBombs (length, setGridNew, i, j);
bombButton[i][j] = new JButton (bombString[i][j]);
if (setGridNew[a][b] == 0)
buttonGrid[a][b] = bombButton[a][b];
getBombsTotal--;
JLabel setBombsLabelNew = new JLabel();
setBombsLabelNew = setBombsLabel (" " String.valueOf (getBombsTotal) " Bombs Left");
else if (setGridNew[a][b] == 1 )
buttonGrid[a][b] = new JButton("x");
JOptionPane.showMessageDialog (null, "Game Over. You hit a Bomb!");
System.exit(0);
//create the content pane
public Container newContentPane(int length)
JPanel topPanel = new JPanel();
JPanel bottomPanel = new JPanel();
topPanel = newTopPanel(length);
bottomPanel = newBottomPanel (length);
JPanel contentPane = new JPanel();
contentPane.setOpaque (true);
contentPane.setLayout (new BorderLayout(5,5));
contentPane.add (topPanel, BorderLayout.NORTH);
contentPane.add (bottomPanel, BorderLayout.CENTER);
return contentPane;
public void closeFrame ()
frame = new JFrame ("Minesweeper");
frame.dispose();
public void launchFrame (int length)
//Makes sure we have nice window decorations
JFrame.setDefaultLookAndFeelDecorated(true);
//Sets up the top-level window
frame = new JFrame ("Minesweeper");
//Exits program when the closed button is clicked
frame.setDefaultCloseOperation (JFrame.EXIT_ON_CLOSE);
JMenuBar menuBar = new JMenuBar();
Container contentPane = new Container();
menuBar = newMenuBar();
contentPane = newContentPane (length);
//Sets up the menu bar and content pane
frame.setJMenuBar (menuBar);
frame.setContentPane (contentPane);
//Displays the window
frame.pack();
frame.setVisible (true);
public static void main (String args[])
//Default length is 5
length = 5;
MinesweeperGUI minesweeper = new MinesweeperGUI();
minesweeper.launchFrame(length); -
Please someone help me with this code..
hi, i have a big problem trying to figure out how to do this, i get this code somewhere in the net, so it's not me who code this, that's why i got this problem.
this is a MIDlet games, something like gallaga. i like to add some features like the UP and DOWN movement and also i have a problem with his "fire", i can only shoot once after the fire image is gone in the screen, what i liked to have is even i pressed the fire button and press it again the fire will not gone, what i mean continues fire if i pressed everytime the fire button.
i will post the code here so you can see it and give me some feedback. i need this badly, hoping to all you guys! thanks..for this forum.
----CODE BEGIN ---------------
import java.io.IOException;
import java.io.PrintStream;
import java.util.Random;
import javax.microedition.lcdui.*;
import javax.microedition.midlet.MIDlet;
import javax.microedition.midlet.MIDletStateChangeException;
import javax.microedition.rms.RecordStore;
import javax.microedition.rms.RecordStoreException;
public class MobileGalaga extends MIDlet
implements CommandListener, Runnable
class ScoreScreen extends Canvas
public void paint(Graphics g)
g.setColor(0xffffff);
g.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
g.setColor(0x160291);
g.setFont(MobileGalaga.fs);
g.drawString("Help", MobileGalaga.CENTERW, 2, 17);
g.setColor(0);
g.drawString("Use left/right and fire", MobileGalaga.CENTERW, 20, 17);
g.drawString("to destory the", MobileGalaga.CENTERW, 30, 17);
g.drawString("incoming alien MobileGalaga", MobileGalaga.CENTERW, 40, 17);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 8)
display.setCurrent(titlescreen);
ScoreScreen()
class TitleScreen extends Canvas
public void paint(Graphics g)
g.setColor(0xffffff);
g.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
g.drawImage(MobileGalaga.logoimg, MobileGalaga.CENTERW, 15, 17);
g.setColor(0);
g.setFont(MobileGalaga.fs);
g.drawString("Press 5 to", MobileGalaga.CENTERW, 43, 17);
g.drawString("see help", MobileGalaga.CENTERW, 53, 17);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 8)
display.setCurrent(scorescreen);
TitleScreen()
class MainScreen extends Canvas
public void paint(Graphics g)
offg.setColor(0xffffff);
offg.fillRect(0, 0, MobileGalaga.WIDTH, MobileGalaga.HEIGHT);
for(int i = 0; i < MobileGalaga.slen; i++)
if(!MobileGalaga.dead)
offg.drawImage(MobileGalaga.alienimg[MobileGalaga.frame[i]], MobileGalaga.x[i], MobileGalaga.y[i], 17);
if(!MobileGalaga.playerdead)
offg.drawImage(MobileGalaga.playerimg, MobileGalaga.px, MobileGalaga.py, 17);
} else
if(MobileGalaga.explodeframe < 3)
offg.drawImage(MobileGalaga.explosionimg[MobileGalaga.explodeframe], MobileGalaga.px, MobileGalaga.py, 17);
MobileGalaga.explodeframe++;
if(!MobileGalaga.gameover)
MobileGalaga.playerpause++;
if(MobileGalaga.playerpause < 50)
MobileGalaga.playerpause++;
} else
MobileGalaga.playerdead = false;
MobileGalaga.playerpause = 0;
MobileGalaga.px = MobileGalaga.CENTERW;
offg.setColor(0);
offg.drawString(MobileGalaga.scorestr, MobileGalaga.WIDTH, 0, 24);
offg.drawImage(MobileGalaga.playerimg, 0, 0, 20);
offg.drawString(MobileGalaga.lives + "", 12, 0, 20);
if(MobileGalaga.laser)
offg.drawLine(MobileGalaga.laserx, MobileGalaga.lasery, MobileGalaga.laserx, MobileGalaga.lasery + 4);
if(MobileGalaga.showscores)
for(int j = 0; j < 5; j++)
if(j == MobileGalaga.rank)
offg.setColor(0xff0000);
else
offg.setColor(0);
offg.drawString((j + 1) + " .... " + getScoreStr(MobileGalaga.highscore[j]), MobileGalaga.CENTERW, 20 + j * 10, 17);
if(MobileGalaga.showmessage)
offg.setColor(0xff0000);
offg.drawString(MobileGalaga.msg, MobileGalaga.CENTERW, MobileGalaga.CENTERH, 17);
MobileGalaga.messagepause++;
if(MobileGalaga.messagepause > 20)
MobileGalaga.showmessage = false;
MobileGalaga.messagepause = 0;
if(MobileGalaga.gameover)
MobileGalaga.showscores = true;
else
if(MobileGalaga.wavecomplete)
initWave();
g.drawImage(offimg, 0, 0, 20);
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = true;
else
if(j == 5)
MobileGalaga.playerRight = true;
else
if(j == 8)
fireLaser();
public void keyReleased(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = false;
else
if(j == 5)
MobileGalaga.playerRight = false;
private Image offimg;
private Graphics offg;
public MainScreen()
offimg = Image.createImage(getWidth(), getHeight());
offg = offimg.getGraphics();
offg.setFont(MobileGalaga.fs);
public MobileGalaga()
rand = new Random();
display = Display.getDisplay(this);
mainscreen = new MainScreen();
titlescreen = new TitleScreen();
scorescreen = new ScoreScreen();
WIDTH = mainscreen.getWidth();
HEIGHT = mainscreen.getHeight();
CENTERW = WIDTH / 2;
CENTERH = HEIGHT / 2;
exitCommand = new Command("Exit", 7, 1);
playCommand = new Command("Play", 1, 1);
quitCommand = new Command("Quit", 1, 1);
againCommand = new Command("Again", 1, 1);
nullCommand = new Command("", 1, 1);
try
alienimg[0] = Image.createImage("/alien1.png");
alienimg[1] = Image.createImage("/alien2.png");
explosionimg[0] = Image.createImage("/explosion1.png");
explosionimg[1] = Image.createImage("/explosion2.png");
explosionimg[2] = Image.createImage("/explosion3.png");
playerimg = Image.createImage("/player.png");
logoimg = Image.createImage("/logo.png");
catch(IOException ioexception)
db("Couldn't get images!");
imgW = alienimg[0].getWidth();
imgH = alienimg[0].getHeight();
edgeH = imgW / 2;
edgeV = imgH / 2;
pimgW = playerimg.getWidth();
pimgH = playerimg.getHeight();
pedgeH = pimgW / 2;
pedgeV = pimgH / 2;
highscore = getHighScores();
public void run()
while(runner)
rp();
updatePos();
try
MobileGalaga _tmp = this;
Thread.sleep(75L);
catch(InterruptedException interruptedexception)
db("interrupted");
runner = false;
MobileGalaga _tmp1 = this;
Thread.yield();
public void startApp()
throws MIDletStateChangeException
display.setCurrent(titlescreen);
addBeginCommands(titlescreen, false);
addBeginCommands(scorescreen, false);
addPlayCommands(mainscreen, false);
public void pauseApp()
public void destroyApp(boolean flag)
runner = false;
th = null;
private void rp()
mainscreen.repaint();
private void startGame()
initGame();
if(th == null)
th = new Thread(this);
runner = true;
th.start();
private void initGame()
px = CENTERW;
py = HEIGHT - pedgeV - pimgH;
packcount = 0;
lives = 3;
score = 0;
scorestr = "000000";
rank = -1;
difficulty = 400;
wave = 1;
initWave();
private void initWave()
for(int i = 0; i < slen; i++)
frame[i] = i % 2;
x[i] = packX[i] = sposX[i];
y[i] = packY[i] = sposY[i];
dx[i] = packdx = alien_dx_right;
dy[i] = packdy = alien_dy_right;
dxcount[i] = dycount[i] = 0;
pmode[i] = 0;
flying[i] = false;
dead[i] = false;
playerLeft = false;
playerRight = false;
laser = false;
playerdead = false;
showscores = false;
showmessage = false;
gameover = false;
wavecomplete = false;
playerpause = 0;
messagepause = 0;
killed = 0;
private void updatePos()
if(playerLeft)
updatePlayerPos(-2);
else
if(playerRight)
updatePlayerPos(2);
fly = Math.abs(rand.nextInt() % difficulty);
if(fly < slen && !flying[fly] && !dead[fly])
if(x[fly] < CENTERW)
setDX(fly, alien_dx_flyright, 2);
setDY(fly, alien_dy_flyright, 2);
} else
setDX(fly, alien_dx_flyleft, 2);
setDY(fly, alien_dy_flyleft, 2);
flying[fly] = true;
for(int i = 0; i < slen; i++)
if(!dead[i])
if(!flying[i])
if(x[i] + edgeH + dx[i][dxcount[i]] > WIDTH)
changePackDir(alien_dx_left, alien_dy_left);
if((x[i] - edgeH) + dx[i][dxcount[i]] < 0)
changePackDir(alien_dx_right, alien_dy_right);
} else
if(y[i] + edgeV + dy[i][dycount[i]] > HEIGHT)
x[i] = packX[i];
y[i] = packY[i];
flying[i] = false;
setDX(i, packdx, 0);
setDY(i, packdy, 0);
if(!playerdead && y[i] <= py + pedgeV && y[i] >= py - pedgeV && x[i] <= px + pedgeH && x[i] >= px - pedgeH)
playerHit();
if(laser && lasery <= y[i] + edgeV && lasery >= y[i] - edgeV && laserx <= x[i] + edgeH && laserx >= x[i] - edgeH)
alienHit(i);
for(int j = 0; j < slen; j++)
if(!dead[j])
if(framecount == 3)
frame[j] = frame[j] + 1 < 2 ? 1 : 0;
lastx = x[j];
lasty = y[j];
x[j] += dx[j][dxcount[j]];
y[j] += dy[j][dycount[j]];
if(pmode[j] == 0)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : 0;
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : 0;
} else
if(pmode[j] == 2)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : dxcount[j];
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : dycount[j];
packX[j] += packdx[packcount];
packY[j] += packdy[packcount];
packcount = packcount + 1 < packlen ? packcount + 1 : 0;
framecount = framecount + 1 < 4 ? framecount + 1 : 0;
if(laser)
lasery -= 6;
if(lasery < 0)
laser = false;
private void setDX(int i, int ai[], int j)
if(i == -1)
for(int k = 0; k < slen; k++)
if(!flying[k])
dx[k] = ai;
dxcount[k] = 0;
pmode[k] = j;
} else
dx[i] = ai;
dxcount[i] = 0;
pmode[i] = j;
private void setDY(int i, int ai[], int j)
if(i == -1)
for(int k = 0; k < slen; k++)
if(!flying[k])
dy[k] = ai;
dycount[k] = 0;
pmode[k] = j;
} else
dy[i] = ai;
dycount[i] = 0;
pmode[i] = j;
private void changePackDir(int ai[], int ai1[])
setDX(-1, ai, 0);
setDY(-1, ai1, 0);
packdx = ai;
packdy = ai1;
packcount = 0;
private void updatePlayerPos(int i)
plastx = px;
px += i;
if(px + pedgeH > WIDTH || px - pedgeH < 0)
px = plastx;
private void fireLaser()
if(!laser)
laser = true;
laserx = px;
lasery = py;
private void alienHit(int i)
if(!playerdead)
dead[i] = true;
laser = false;
killed++;
if(flying[i])
score += 200;
else
score += 50;
if(killed == slen)
waveComplete();
scorestr = getScoreStr(score);
private void playerHit()
playerdead = true;
playerpause = 0;
explodeframe = 0;
lives--;
if(lives == 0)
gameOver();
private void waveComplete()
wavecomplete = true;
difficulty -= 100;
if(difficulty < 100)
difficulty = 100;
msg = "WAVE " + wave + " COMPLETE";
messagepause = 0;
showmessage = true;
wave++;
score += 1000 * wave;
scorestr = getScoreStr(score);
private void gameOver()
gameover = true;
msg = "GAME OVER";
for(int i = 0; i < 5; i++)
if(score < highscore[i])
continue;
for(int j = 4; j > i; j--)
highscore[j] = highscore[j - 1];
highscore[i] = score;
rank = i;
break;
setHighScores();
showmessage = true;
messagepause = 0;
addEndCommands(mainscreen, true);
private void addBeginCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(playCommand);
displayable.addCommand(exitCommand);
displayable.setCommandListener(this);
private void addPlayCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(nullCommand);
displayable.addCommand(quitCommand);
displayable.setCommandListener(this);
private void addEndCommands(Displayable displayable, boolean flag)
if(flag)
removeCommands();
displayable.addCommand(againCommand);
displayable.addCommand(quitCommand);
displayable.setCommandListener(this);
private void removeCommands()
Displayable displayable = display.getCurrent();
displayable.removeCommand(nullCommand);
displayable.removeCommand(quitCommand);
displayable.removeCommand(againCommand);
displayable.removeCommand(playCommand);
displayable.removeCommand(exitCommand);
public void commandAction(Command command, Displayable displayable)
if(command == playCommand)
display.setCurrent(mainscreen);
startGame();
if(command == quitCommand)
runner = false;
while(th.isAlive()) ;
th = null;
addPlayCommands(mainscreen, true);
display.setCurrent(titlescreen);
if(command == againCommand)
runner = false;
while(th.isAlive()) ;
th = null;
display.setCurrent(mainscreen);
addPlayCommands(mainscreen, true);
startGame();
if(command == exitCommand)
destroyApp(false);
notifyDestroyed();
private int[] getHighScores()
int ai[] = new int[5];
ai[0] = 5000;
ai[1] = 4000;
ai[2] = 3000;
ai[3] = 2000;
ai[4] = 1000;
byte abyte0[][] = new byte[5][6];
try
hsdata = RecordStore.openRecordStore("MobileGalaga", true);
int i = hsdata.getNumRecords();
if(i == 0)
for(int j = 0; j < 5; j++)
abyte0[j] = Integer.toString(ai[j]).getBytes();
hsdata.addRecord(abyte0[j], 0, abyte0[j].length);
} else
for(int k = 0; k < 5; k++)
abyte0[k] = hsdata.getRecord(k + 1);
String s = "";
for(int l = 0; l < abyte0[k].length; l++)
s = s + (char)abyte0[k][l] + "";
ai[k] = Integer.parseInt(s);
catch(RecordStoreException recordstoreexception)
db("problem with initialising highscore data\n" + recordstoreexception);
return ai;
private void setHighScores()
byte abyte0[][] = new byte[5][6];
try
hsdata = RecordStore.openRecordStore("MobileGalaga", true);
for(int i = 0; i < 5; i++)
abyte0[i] = Integer.toString(highscore[i]).getBytes();
hsdata.setRecord(i + 1, abyte0[i], 0, abyte0[i].length);
catch(RecordStoreException recordstoreexception)
db("problem with setting highscore data\n" + recordstoreexception);
private String getScoreStr(int i)
templen = 6 - (i + "").length();
tempstr = "";
for(int j = 0; j < templen; j++)
tempstr = tempstr + "0";
return tempstr + i;
public static void db(String s)
System.out.println(s);
public static void db(int i)
System.out.println(i + "");
private Display display;
private Command exitCommand;
private Command playCommand;
private Command quitCommand;
private Command againCommand;
private Command nullCommand;
private MainScreen mainscreen;
private TitleScreen titlescreen;
private ScoreScreen scorescreen;
private static int WIDTH;
private static int HEIGHT;
private static int CENTERW;
private static int CENTERH;
private boolean runner;
private Thread th;
private Random rand;
private static final int RED = 0xff0000;
private static final int ORANGE = 0xff9100;
private static final int YELLOW = 0xffff00;
private static final int WHITE = 0xffffff;
private static final int BLACK = 0;
private static final int BLUE = 0x160291;
private static Image alienimg[] = new Image[2];
private static Image explosionimg[] = new Image[3];
private static Image playerimg;
private static Image logoimg;
private static int imgH;
private static int imgW;
private static int pimgH;
private static int pimgW;
private static int edgeH;
private static int edgeV;
private static int pedgeH;
private static int pedgeV;
private static final Font fs = Font.getFont(64, 0, 8);
private static final Font fl = Font.getFont(64, 1, 16);
private static final int sposX[] = {
16, 28, 40, 52, 4, 16, 28, 40, 52, 64,
4, 16, 28, 40, 52, 64
private static final int sposY[] = {
14, 14, 14, 14, 26, 26, 26, 26, 26, 26,
38, 38, 38, 38, 38, 38
private static final int LOOP = 0;
private static final int ONCE = 1;
private static final int HOLD = 2;
private static final int move_none[] = {
0
private static final int alien_dx_right[] = {
1, 1, 1, 1, 1, 1, 1, 1
private static final int alien_dy_right[] = {
0, 0, 1, 1, 0, 0, -1, -1
private static final int alien_dx_left[] = {
-1, -1, -1, -1, -1, -1, -1, -1
private static final int alien_dy_left[] = {
0, 0, -1, -1, 0, 0, 1, 1
private static final int alien_dx_flyright[] = {
1, 1, 1, 0, -1, -1, -1, -1, -1, 0,
1, 1, 2, 3, 4, 5, 6
private static final int alien_dy_flyright[] = {
0, -1, -1, -1, -1, -1, 0, 1, 1, 1,
1, 1, 2, 3, 4, 5, 6
private static final int alien_dx_flyleft[] = {
-1, -1, -1, 0, 1, 1, 1, 1, 1, 0,
-1, -1, -2, -3, -4, -5, -6
private static final int alien_dy_flyleft[] = {
0, -1, -1, -1, -1, -1, 0, 1, 1, 1,
1, 1, 2, 3, 4, 5, 6
private static final int slen;
private static final int ailen;
private static final int packlen;
private static int pmode[];
private static int x[];
private static int y[];
private static int dx[][];
private static int dy[][];
private static int dxcount[];
private static int dycount[];
private static int frame[];
private static boolean flying[];
private static boolean dead[];
private static boolean exploding[];
private static int lastx;
private static int lasty;
private static int fly;
private static int packX[];
private static int packY[];
private static int packdx[];
private static int packdy[];
private static int packcount;
private static int framecount = 3;
private static int px;
private static int py;
private static int plastx;
private static int score;
private static String scorestr;
private static int lives;
private static int killed;
private static boolean playerdead;
private static int explodeframe;
private static int playerpause;
private static int rank;
private static boolean playerLeft;
private static boolean playerRight;
private static boolean laser;
private static int laserx;
private static int lasery;
private static RecordStore hsdata;
private static int highscore[] = new int[5];
private static boolean showmessage;
private static boolean showscores;
private static boolean gameover;
private static boolean wavecomplete;
private static int messagepause;
private static String msg;
private static int difficulty;
private static int wave;
private static String tempstr;
private static int templen;
static
slen = sposX.length;
ailen = alien_dx_flyright.length;
packlen = alien_dx_right.length;
pmode = new int[slen];
x = new int[slen];
y = new int[slen];
dx = new int[slen][ailen];
dy = new int[slen][ailen];
dxcount = new int[slen];
dycount = new int[slen];
frame = new int[slen];
flying = new boolean[slen];
dead = new boolean[slen];
exploding = new boolean[slen];
packX = new int[slen];
packY = new int[slen];
packdx = new int[packlen];
packdy = new int[packlen];
----END OF CODE ----------------hi sorry if it's too big! i hope i can explain this very well (you know i only got this code in the net), if you try to run the program in emulator, the and lunch it will it will first display the title screen and if you hit the pressed key 5 it will display help,
so my problem is how to move UP and DOWN and also if i pressed the fire button it will continue to fire. here is the code.
//Code for the Left,Right,UP and Down movement and also the fire
public void keyPressed(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = true; //this is ok
else
if(j == 5)
MobileGalaga.playerRight = true; //this is ok
else
if(j==1)
MobileGalaga.playerUp = true; //i add this only, this has a problem
else
if(j==6)
MobileGalaga.playerDown = true; //i add this only, this has a problem
else
if(j == 8)
fireLaser(); //for the release of fire
//for the release of key pressed
public void keyReleased(int i)
int j = getGameAction(i);
if(j == 2)
MobileGalaga.playerLeft = false;
else
if(j == 5)
MobileGalaga.playerRight = false;
//Update the position base on key pressed
private void updatePos()
if(playerLeft)
updatePlayerPos(-5);
else
if(playerUp)
updatePlayerPos1(-4);
else
if(playerDown)
updatePlayerPos1(4);
else
if(playerRight)
updatePlayerPos(5);
fly = Math.abs(rand.nextInt() % difficulty);
if(fly < slen && !flying[fly] && !dead[fly])
if(x[fly] < CENTERW)
setDX(fly, alien_dx_flyright, 2);
setDY(fly, alien_dy_flyright, 2);
} else
setDX(fly, alien_dx_flyleft, 2);
setDY(fly, alien_dy_flyleft, 2);
flying[fly] = true;
for(int i = 0; i < slen; i++)
if(!dead)
if(!flying[i])
if(x[i] + edgeH + dx[i][dxcount[i]] > WIDTH)
changePackDir(alien_dx_left, alien_dy_left);
if((x[i] - edgeH) + dx[i][dxcount[i]] < 0)
changePackDir(alien_dx_right, alien_dy_right);
} else
if(y[i] + edgeV + dy[i][dycount[i]] > HEIGHT)
x[i] = packX[i];
y[i] = packY[i];
flying[i] = false;
setDX(i, packdx, 0);
setDY(i, packdy, 0);
if(!playerdead && y[i] <= py + pedgeV && y[i] >= py - pedgeV && x[i] <= px + pedgeH && x[i] >= px - pedgeH)
playerHit();
if(laser && lasery <= y[i] + edgeV && lasery >= y[i] - edgeV && laserx <= x[i] + edgeH && laserx >= x[i] - edgeH)
alienHit(i);
for(int j = 0; j < slen; j++)
if(!dead[j])
if(framecount == 3)
frame[j] = frame[j] + 1 < 2 ? 1 : 0;
lastx = x[j];
lasty = y[j];
x[j] += dx[j][dxcount[j]];
y[j] += dy[j][dycount[j]];
if(pmode[j] == 0)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : 0;
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : 0;
} else
if(pmode[j] == 2)
dxcount[j] = dxcount[j] + 1 < dx[j].length ? dxcount[j] + 1 : dxcount[j];
dycount[j] = dycount[j] + 1 < dy[j].length ? dycount[j] + 1 : dycount[j];
packX[j] += packdx[packcount];
packY[j] += packdy[packcount];
packcount = packcount + 1 < packlen ? packcount + 1 : 0;
framecount = framecount + 1 < 4 ? framecount + 1 : 0;
if(laser)
lasery -= 6;
if(lasery < 0 )
laser = false;
// this will move the object UP,DOWN,Left and Right
private void updatePlayerPos(int i)
plastx = px;
px += i;
if(px + pedgeH > WIDTH || px - pedgeH < 0)
px = plastx;
private void updatePlayerPos1(int i)
plastx = py;
py += i;
if(px + pedgeV > HEIGHT || px - pedgeV < 0)
px = plastx;
// This will fire, if you hit the fire button
private void fireLaser()
if(!laser)
laser = true;
laserx = px;
lasery = py;
sorry if it's too long i just want too explain this. if anyone like to see this and run so that you can see it also, i can send an email.
thanks,
alek -
Used createinstallmedis to make a copy of the Mavericks app for use in a new hard drive install.. Copied find but gave error code 110 and failed to make the flash drive bootable.. Any help in what errror code means?
Did you partition and format the flash drive first? See the following:
Make Your Own Mavericks, Mountain/Lion Installer
After downloading the installer you must first save the Install Mac OS X application. After the installer downloads DO NOT click on the Install button. Go to your Applications folder and make a copy of the installer. Move the copy into your Downloads folder. Now you can click on the Install button. You must do this because the installer deletes itself automatically when it finishes installing.
2. Get a USB flash drive that is at least 8 GBs. Prep this flash drive as follows:
Open Disk Utility in your Utilities folder.
After DU loads select your flash drive (this is the entry with the mfgr.'s ID and size) from the leftside list. Under the Volume Scheme heading set the number of partitions from the drop down menu to one. Set the format type to Mac OS Extended (Journaled.) Click on the Options button, set the partition scheme to GUID then click on the OK button. Click on the Partition button and wait until the process has completed.
Select the volume you just created (this is the sub-entry under the drive entry) from the left side list.
Click on the Erase tab in the DU main window.
Set the format type to Mac OS Extended (Journaled.) Click on the Options button, check the button for Zero Data and click on OK to return to the Erase window.
Click on the Erase button. The format process can take up to an hour depending upon the flash drive size.
Make your own Mavericks flash drive installer using the Mavericks tool:
Mavericks has its own built-in installer maker you use via the Terminal:
You will need a freshly partitioned and formatted USB flash drive with at least 8GBs. Leave the name of the flash drive at the system default, "Untitled." Do not change this name. Open the Terminal in the Utilities folder. Copy this command line after the prompt in the Terminal's window:
sudo /Applications/Install\ OS\ X\ Mavericks.app/Contents/Resources/createinstallmedia --volume /Volumes/Untitled --applicationpath /Applications/Install\ OS\ X\ Mavericks.app --nointeraction
Press RETURN. Enter your admin password when prompted. It will not be echoed to the screen so be careful to enter it correctly. Press RETURN, again.
Wait for the process to complete which will take quite some time. -
import java.util.Date;
import java.net.*;
public class DateTest{
public static void main(String arr[]){
try{
URL url = new URL("http://www.google.com");
HttpURLConnection url1 = (HttpURLConnection)url.openConnection();
// System.out.println(url1.getExpiration());
System.out.println((new Date(url1.getExpiration())).toString());
catch(Exception e){
System.out.println(e);
IS MY EXPIRATION DATE LOGICALLY A CORRECT ONE im a beginner help me in this codehere's the output of your code:
dt: Wed Jun 08 10:47:12 CST 2005
Thu Jan 01 08:00:00 CST 1970
the first line is the sysdate of my pc
and the second line is the date of the expiration date
as you can see it isn't correct to be expired at that time because the web or url isn't well established at that time -
Please make suggestions on how to improve this code.
Hello Experts,
I am currently modifying a report where a certain code is giving
me run time error. When I debugged the program, the internal table
has 20,000+ records. Now, is there any alternative to this code?
I really need to speed this up. Help would be greatly appreciated and rewarded.
LOOP AT it_cdpos INTO wa_cdpos.
l_matnr = wa_cdpos-objectid+00(18).
l_charg = wa_cdpos-objectid+22(10).
l_zustd = wa_cdpos-value_new+00(01).
READ TABLE it_batch INTO wa_batch
WITH KEY matnr = l_matnr
charg = l_charg.
IF sy-subrc EQ 0.
l_tabix = sy-tabix.
wa_batch-zustd = l_zustd.
MODIFY it_batch FROM wa_batch INDEX l_tabix
TRANSPORTING zustd.
ELSE.
wa_batch-matnr = l_matnr.
wa_batch-charg = l_charg.
wa_batch-zustd = l_zustd.
wa_batch-code = 'A'. "selected within period
APPEND wa_batch TO it_batch.
ENDIF.
ENDLOOP.Check the SQL statement from which u get the result otherwise
the code which u sent is optimized or u can use the binary search option for the Read statement for MATNR
while the rest of the code is optimized....
or u can use
loop at it_cdpos assinging <fs>.
<FS>-cols = value.
<b>note: in this case <FS>-col = value</b>
u wont have to use <b>modify</b> statement for internal table for updating the line contents
since assinging it to field-symbol will dynamically modifies the contents.
<b>this method is faster than the below modify process </b>
endloop. -
Help on upgrading this code to Java 5
Hi guys,
I was trying to upgrading the following code to comply with Java 5 using generics, but I failed. Hope somebody here can help me out of this.
This is the original code:
import java.util.*;
public class TestJava5{
public static void main(String [] args){
TestJava5 t = new TestJava5();
Collection strs = t.getAll(String.class);
for(Iterator i = strs.iterator(); i.hasNext();){
System.out.println(i.next());
private Collection getAll(Class c){
Collection rs = new ArrayList ();
if(String.class.equals(c)){
rs.add("str1");
rs.add("str2");
}else if(StringBuffer.class.equals(c)){
rs.add(new StringBuffer("buffer1"));
rs.add(new StringBuffer("buffer2"));
return rs;
}and this is the code I tried to use generics, but obviously, I cannot add a String or StringBuffer into a Collection<T>.
import java.util.*;
public class TestJava5{
public static void main(String [] args){
TestJava5 t = new TestJava5();
Collection<String> strs = t.getAll(String.class);
for(String str:strs){
System.out.println(str);
private <T> Collection<T> getAll(Class<T> c){
Collection<T> rs = new ArrayList<T>();
if(String.class.equals(c)){
rs.add("str1");
rs.add("str2");
}else if(URI.class.equals(c)){
rs.add(new StringBuffer("buffer1"));
rs.add(new StringBuffer("buffer2"));
return rs;
}Actually, now I've looked at it, it's even worse than that!
You create a collection with type T, but this type is not fixed at compile type (by definition, obviously). So when you come to add something to the collection (either a String or a StringBuffer), the compiler cannot guarantee that your collection is of the correct type.
This code is really on a hiding to nothing, I would suggest. But... the following should relieve your immediate compilation problems. However, it is likely to cause further problems when trying to use the returned collection:
private <T> Collection<?> getAll2(Class<T> c) {
if (String.class.equals(c)) {
Collection<String> rs = new ArrayList<String>();
rs.add("str1");
rs.add("str2");
return rs;
} else if (URI.class.equals(c)) {
Collection<StringBuffer> rs = new ArrayList<StringBuffer>();
rs.add(new StringBuffer("buffer1"));
rs.add(new StringBuffer("buffer2"));
return rs;
} else {
return null; // or something else like new ArrayList<Object>()
} -
need help with this code... i am new to java programming.. and having difficulties with the code below...
import java.awt.*;
import javax.swing.*;
import java.net.*;
public class DisplayImage extends JApplet
public void init()
int[] imageData = {0x47,0x49,0x46,0x38,0x39,0x61,0x38,0x00,0x12,0x00,0xF3,0x00,0x00,0xFB,0x0B,0x0E,0xFF,0x24,0x00,0xFF,0x3C,0x00,0xFF,0xFF,0xFF,0xFF,0x00,0x7B,0xFF,0x00,0x1E,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x2C,0x00,0x00,0x00,0x00,0x38,0x00,0x12,0x00,0x00,0x04,0x68,0x10,0xC8,0x49,0xAB,0xBD,0x38,0xEB,0xCD,0xBB,0x0E,0x5E,0x26,0x84,0x64,0x69,0x9E,0xE6,0xA0,0x0E,0xD5,0xEA,0x4E,0xEE,0x4A,0xBD,0xA8,0x2A,0xD9,0x30,0xCB,0xE1,0x00,0xCE,0x93,0xBC,0x9F,0x6E,0x13,0x1C,0xF6,0x8C,0xA7,0x62,0x47,0x99,0x43,0xDD,0x8C,0x31,0x64,0x73,0xFA,0xAC,0xC9,0xA8,0x3F,0xEA,0x71,0x26,0x2D,0x65,0xB9,0x96,0xAC,0xEF,0x9B,0xEA,0x6E,0x5B,0xD2,0xA8,0x53,0x0B,0x6E,0x67,0xC8,0x44,0xA8,0x4E,0x88,0x14,0xCB,0x93,0xF3,0xFB,0xD9,0x3D,0x85,0x2F,0xAF,0x5C,0x64,0x82,0x80,0x6B,0x16,0x04,0x85,0x88,0x6B,0x05,0x89,0x12,0x11,0x00,0x3B};
ImageIcon icon = null;
try
icon = ImageIcon(ImageDate[]);
catch(IOException e)
System.out.println("Failed to create URL:\n" + e);
return;
loadImage(image);
int imageWidth = icon.getIconWidth(); // Get icon width
int imageHeight = icon.getIconHeight(); // and its height
resize(imageWidth,imageHeight); // Set applet size to fit the image
//Create panel a showing the image
ImagePanel imagePanel = new ImagePanel(icon.getImage());
getContentPane().add(imagePanel); // Add the panel to the content pane
// Class representing a panel displaying an image
class ImagePanel extends JPanel
public ImagePanel(Image image)
this.image = image;
public void paint(Graphics g)
g.drawImage(image, 0, 0, this); // Display the image
Image image; // The image
}Thanks in advance...
Uzairyeah true.... its not that i need someone to write the code.. just cos this code is giving me some problems thought i could get code from others...
i noticed the extra bracket ending the init().. but thats not what i have problem with....
It is with how to use ImageIcon(byte[])
it is something that i need to use this thing in particular... as i am asked to do.... -
Hello
Need to tune this code.Its taking too much time.
REFRESH: T_BVOR.
IF NOT I_TEM[] IS INITIAL.
SELECT BVORG BUKRS GJAHR BELNR INTO
CORRESPONDING FIELDS OF
TABLE T_BVOR
FROM BVOR
FOR ALL ENTRIES IN I_TEM
WHERE BVORG = I_TEM-BVORG
AND GJAHR = I_TEM-GJAHR.
ENDIF.
IF SY-SUBRC EQ 0.
SORT T_BVOR BY BVORG GJAHR.
ENDIF.
CLEAR: WA_BVOR.
SORT I_TEM BY BVORG GJAHR.
LOOP AT T_BVOR INTO WA_BVOR.
CLEAR: I_TEM.
READ TABLE I_TEM WITH KEY BVORG = WA_BVOR-BVORG
GJAHR = WA_BVOR-GJAHR
BINARY SEARCH.
IF SY-SUBRC EQ 0.
MOVE I_TEM-BLART TO WA_BVOR-BLART.
ENDIF.
MODIFY T_BVOR FROM WA_BVOR TRANSPORTING BLART.
ENDLOOP.
SORT T_BVOR BY BUKRS BELNR GJAHR.
IF NOT T_BVOR[] IS INITIAL.
LOOP AT I_BVOR.
REFRESH: GT_BSEG.
SELECT BUKRS
BELNR GJAHR BSCHL KOSTL HKONT
EBELN PRCTR ZZINFO3 TXGRP
FROM BSEG
INTO CORRESPONDING FIELDS
OF TABLE GT_BSEG
FOR ALL ENTRIES IN T_BVOR
WHERE BUKRS = T_BVOR-BUKRS
AND BELNR = T_BVOR-BELNR
AND GJAHR = T_BVOR-GJAHR
AND NOT HKONT IN RANGE_HKONT.
ENDIF.
SORT GT_BSEG BY BUKRS BELNR GJAHR.
DELETE ADJACENT DUPLICATES FROM GT_BSEG
COMPARING BUKRS BELNR GJAHR.
CLEAR: WA_BSEG.
LOOP AT GT_BSEG INTO WA_BSEG.
CLEAR: WA_BVOR.
READ TABLE T_BVOR INTO WA_BVOR WITH KEY
BUKRS = WA_BSEG-BUKRS
BELNR = WA_BSEG-BELNR
GJAHR = WA_BSEG-GJAHR
BINARY SEARCH.
IF SY-SUBRC EQ 0.
MOVE WA_BVOR-BLART TO WA_BSEG-BLART.
MOVE WA_BVOR-BVORG TO WA_BSEG-BVORG.
ENDIF.
MODIFY GT_BSEG FROM WA_BSEG TRANSPORTING BLART BVORG.
ENDLOOP.
REFRESH: GT_BSEG1,GT_BSEG2.
SORT T_DOCS BY BSCHL BLART.
SORT GT_BSEG BY BVORG.
CLEAR: WA_BSEG.
LOOP AT GT_BSEG INTO WA_BSEG.
CLEAR: T_DOCS.
LOOP AT T_DOCS WHERE BSCHL = WA_BSEG-BSCHL
AND BLART = WA_BSEG-BLART.
IF T_DOCS-BSCHL = '40' OR T_DOCS-BSCHL = '50'
OR T_DOCS-BSCHL = '81' OR T_DOCS-BSCHL = '91'.
MOVE-CORRESPONDING WA_BSEG TO WA_BSEG1.
APPEND WA_BSEG1 TO GT_BSEG1.
CLEAR: WA_BSEG1.
ENDIF.
IF T_DOCS-BSCHL = '31' OR T_DOCS-BSCHL = '32'
OR T_DOCS-BSCHL = '21' OR T_DOCS-BSCHL = '22'
OR ( T_DOCS-ZDATATYP = 'TAXRPT02' AND
( T_DOCS-BSCHL = '40' OR T_DOCS-BSCHL = '50' ) ).
MOVE-CORRESPONDING WA_BSEG TO WA_BSEG1.
APPEND WA_BSEG2 TO GT_BSEG2.
CLEAR: WA_BSEG2.
ENDIF.
ENDLOOP.
ENDLOOP.
SORT GT_BSEG1 BY TXGRP.
SORT GT_BSEG2 BY BUKRS BELNR GJAHR.
LOOP AT i_bseg.
CLEAR: WA_BSEG2.
LOOP AT GT_BSEG2 INTO WA_BSEG2.
CLEAR : GT_ALV_ITEM.
LOOP AT GT_ALV_ITEM WHERE
BUKRS = WA_BSEG2-BUKRS AND
BELNR = WA_BSEG2-BELNR AND
GJAHR = WA_BSEG2-GJAHR.
CLEAR: WA_BSEG1.
LOOP AT GT_BSEG1 INTO WA_BSEG1
WHERE GJAHR = GT_ALV_ITEM-GJAHR AND
TXGRP = GT_ALV_ITEM-TXGRP AND
BVORG = WA_BSEG2-BVORG.
MOVE: WA_BSEG1-BUKRS TO GT_ALV_ITEM-BUKRS,
WA_BSEG1-EBELN TO GT_ALV_ITEM-EBELN,
WA_BSEG1-HKONT TO GT_ALV_ITEM-HKONT,
WA_BSEG1-BELNR TO GT_ALV_ITEM-BELNR,
WA_BSEG1-KOSTL TO GT_ALV_ITEM-KOSTL,
WA_BSEG1-PRCTR TO GT_ALV_ITEM-PRCTR,
WA_BSEG1-ZZINFO3 TO GT_ALV_ITEM-ZZINFO3." M003a
CLEAR: WA_BSEG1.
ENDLOOP.
MODIFY GT_ALV_ITEM INDEX SY-TABIX.
IF gt_alv_item-txjlv = 6.EXIT.ENDIF.
ENDIF.
ENDLOOP.
CLEAR: WA_BSEG2.
ENDLOOP.
Thanks
SunilWays of Performance Tuning
1. Selection Criteria
2. Select Statements
Select Queries
SQL Interface
Aggregate Functions
For all Entries
Select Over more than one internal table
Selection Criteria
1. Restrict the data to the selection criteria itself, rather than filtering it out using the ABAP code using CHECK statement.
2. Select with selection list.
SELECT * FROM SBOOK INTO SBOOK_WA.
CHECK: SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
ENDSELECT.
The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list
SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK
WHERE SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
Select Statements Select Queries
1. Avoid nested selects
SELECT * FROM EKKO INTO EKKO_WA.
SELECT * FROM EKAN INTO EKAN_WA
WHERE EBELN = EKKO_WA-EBELN.
ENDSELECT.
ENDSELECT.
The above code can be much more optimized by the code written below.
SELECT PF1 PF2 FF3 FF4 INTO TABLE ITAB
FROM EKKO AS P INNER JOIN EKAN AS F
ON PEBELN = FEBELN.
Note: A simple SELECT loop is a single database access whose result is passed to the ABAP program line by line. Nested SELECT loops mean that the number of accesses in the inner loop is multiplied by the number of accesses in the outer loop. One should therefore use nested SELECT loops only if the selection in the outer loop contains very few lines or the outer loop is a SELECT SINGLE statement.
2. Select all the records in a single shot using into table clause of select statement rather than to use Append statements.
SELECT * FROM SBOOK INTO SBOOK_WA.
CHECK: SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
ENDSELECT.
The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list and puts the data in one shot using into table
SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK
WHERE SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
3. When a base table has multiple indices, the where clause should be in the order of the index, either a primary or a secondary index.
To choose an index, the optimizer checks the field names specified in the where clause and then uses an index that has the same order of the fields. In certain scenarios, it is advisable to check whether a new index can speed up the performance of a program. This will come handy in programs that access data from the finance tables.
4. For testing existence, use Select.. Up to 1 rows statement instead of a Select-Endselect-loop with an Exit.
SELECT * FROM SBOOK INTO SBOOK_WA
UP TO 1 ROWS
WHERE CARRID = 'LH'.
ENDSELECT.
The above code is more optimized as compared to the code mentioned below for testing existence of a record.
SELECT * FROM SBOOK INTO SBOOK_WA
WHERE CARRID = 'LH'.
EXIT.
ENDSELECT.
5. Use Select Single if all primary key fields are supplied in the Where condition .
If all primary key fields are supplied in the Where conditions you can even use Select Single.
Select Single requires one communication with the database system, whereas Select-Endselect needs two.
Select Statements SQL Interface
1. Use column updates instead of single-row updates
to update your database tables.
SELECT * FROM SFLIGHT INTO SFLIGHT_WA.
SFLIGHT_WA-SEATSOCC =
SFLIGHT_WA-SEATSOCC - 1.
UPDATE SFLIGHT FROM SFLIGHT_WA.
ENDSELECT.
The above mentioned code can be more optimized by using the following code
UPDATE SFLIGHT
SET SEATSOCC = SEATSOCC - 1.
2. For all frequently used Select statements, try to use an index.
SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA
WHERE CARRID = 'LH'
AND CONNID = '0400'.
ENDSELECT.
The above mentioned code can be more optimized by using the following code
SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA
WHERE MANDT IN ( SELECT MANDT FROM T000 )
AND CARRID = 'LH'
AND CONNID = '0400'.
ENDSELECT.
3. Using buffered tables improves the performance considerably.
Bypassing the buffer increases the network considerably
SELECT SINGLE * FROM T100 INTO T100_WA
BYPASSING BUFFER
WHERE SPRSL = 'D'
AND ARBGB = '00'
AND MSGNR = '999'.
The above mentioned code can be more optimized by using the following code
SELECT SINGLE * FROM T100 INTO T100_WA
WHERE SPRSL = 'D'
AND ARBGB = '00'
AND MSGNR = '999'.
Select Statements Aggregate Functions
If you want to find the maximum, minimum, sum and average value or the count of a database column, use a select list with aggregate functions instead of computing the aggregates yourself.
Some of the Aggregate functions allowed in SAP are MAX, MIN, AVG, SUM, COUNT, COUNT( * )
Consider the following extract.
Maxno = 0.
Select * from zflight where airln = LF and cntry = IN.
Check zflight-fligh > maxno.
Maxno = zflight-fligh.
Endselect.
The above mentioned code can be much more optimized by using the following code.
Select max( fligh ) from zflight into maxno where airln = LF and cntry = IN.
Select Statements For All Entries
The for all entries creates a where clause, where all the entries in the driver table are combined with OR. If the number of entries in the driver table is larger than rsdb/max_blocking_factor, several similar SQL statements are executed to limit the length of the WHERE clause.
The plus
Large amount of data
Mixing processing and reading of data
Fast internal reprocessing of data
Fast
The Minus
Difficult to program/understand
Memory could be critical (use FREE or PACKAGE size)
Points to be must considered FOR ALL ENTRIES
Check that data is present in the driver table
Sorting the driver table
Removing duplicates from the driver table
Consider the following piece of extract
Loop at int_cntry.
Select single * from zfligh into int_fligh
where cntry = int_cntry-cntry.
Append int_fligh.
Endloop.
The above mentioned can be more optimized by using the following code.
Sort int_cntry by cntry.
Delete adjacent duplicates from int_cntry.
If NOT int_cntry[] is INITIAL.
Select * from zfligh appending table int_fligh
For all entries in int_cntry
Where cntry = int_cntry-cntry.
Endif.
Select Statements Select Over more than one Internal table
1. Its better to use a views instead of nested Select statements.
SELECT * FROM DD01L INTO DD01L_WA
WHERE DOMNAME LIKE 'CHAR%'
AND AS4LOCAL = 'A'.
SELECT SINGLE * FROM DD01T INTO DD01T_WA
WHERE DOMNAME = DD01L_WA-DOMNAME
AND AS4LOCAL = 'A'
AND AS4VERS = DD01L_WA-AS4VERS
AND DDLANGUAGE = SY-LANGU.
ENDSELECT.
The above code can be more optimized by extracting all the data from view DD01V_WA
SELECT * FROM DD01V INTO DD01V_WA
WHERE DOMNAME LIKE 'CHAR%'
AND DDLANGUAGE = SY-LANGU.
ENDSELECT
2. To read data from several logically connected tables use a join instead of nested Select statements. Joins are preferred only if all the primary key are available in WHERE clause for the tables that are joined. If the primary keys are not provided in join the Joining of tables itself takes time.
SELECT * FROM EKKO INTO EKKO_WA.
SELECT * FROM EKAN INTO EKAN_WA
WHERE EBELN = EKKO_WA-EBELN.
ENDSELECT.
ENDSELECT.
The above code can be much more optimized by the code written below.
SELECT PF1 PF2 FF3 FF4 INTO TABLE ITAB
FROM EKKO AS P INNER JOIN EKAN AS F
ON PEBELN = FEBELN.
3. Instead of using nested Select loops it is often better to use subqueries.
SELECT * FROM SPFLI
INTO TABLE T_SPFLI
WHERE CITYFROM = 'FRANKFURT'
AND CITYTO = 'NEW YORK'.
SELECT * FROM SFLIGHT AS F
INTO SFLIGHT_WA
FOR ALL ENTRIES IN T_SPFLI
WHERE SEATSOCC < F~SEATSMAX
AND CARRID = T_SPFLI-CARRID
AND CONNID = T_SPFLI-CONNID
AND FLDATE BETWEEN '19990101' AND '19990331'.
ENDSELECT.
The above mentioned code can be even more optimized by using subqueries instead of for all entries.
SELECT * FROM SFLIGHT AS F INTO SFLIGHT_WA
WHERE SEATSOCC < F~SEATSMAX
AND EXISTS ( SELECT * FROM SPFLI
WHERE CARRID = F~CARRID
AND CONNID = F~CONNID
AND CITYFROM = 'FRANKFURT'
AND CITYTO = 'NEW YORK' )
AND FLDATE BETWEEN '19990101' AND '19990331'.
ENDSELECT.
1. Table operations should be done using explicit work areas rather than via header lines.
READ TABLE ITAB INTO WA WITH KEY K = 'X BINARY SEARCH.
IS MUCH FASTER THAN USING
READ TABLE ITAB INTO WA WITH KEY K = 'X'.
If TAB has n entries, linear search runs in O( n ) time, whereas binary search takes only O( log2( n ) ).
2. Always try to use binary search instead of linear search. But dont forget to sort your internal table before that.
READ TABLE ITAB INTO WA WITH KEY K = 'X'. IS FASTER THAN USING
READ TABLE ITAB INTO WA WITH KEY (NAME) = 'X'.
3. A dynamic key access is slower than a static one, since the key specification must be evaluated at runtime.
4. A binary search using secondary index takes considerably less time.
5. LOOP ... WHERE is faster than LOOP/CHECK because LOOP ... WHERE evaluates the specified condition internally.
LOOP AT ITAB INTO WA WHERE K = 'X'.
ENDLOOP.
The above code is much faster than using
LOOP AT ITAB INTO WA.
CHECK WA-K = 'X'.
ENDLOOP.
6. Modifying selected components using MODIFY itab TRANSPORTING f1 f2.. accelerates the task of updating a line of an internal table.
WA-DATE = SY-DATUM.
MODIFY ITAB FROM WA INDEX 1 TRANSPORTING DATE.
The above code is more optimized as compared to
WA-DATE = SY-DATUM.
MODIFY ITAB FROM WA INDEX 1.
7. Accessing the table entries directly in a "LOOP ... ASSIGNING ..." accelerates the task of updating a set of lines of an internal table considerably
Modifying selected components only makes the program faster as compared to Modifying all lines completely.
e.g,
LOOP AT ITAB ASSIGNING <WA>.
I = SY-TABIX MOD 2.
IF I = 0.
<WA>-FLAG = 'X'.
ENDIF.
ENDLOOP.
The above code works faster as compared to
LOOP AT ITAB INTO WA.
I = SY-TABIX MOD 2.
IF I = 0.
WA-FLAG = 'X'.
MODIFY ITAB FROM WA.
ENDIF.
ENDLOOP.
8. If collect semantics is required, it is always better to use to COLLECT rather than READ BINARY and then ADD.
LOOP AT ITAB1 INTO WA1.
READ TABLE ITAB2 INTO WA2 WITH KEY K = WA1-K BINARY SEARCH.
IF SY-SUBRC = 0.
ADD: WA1-VAL1 TO WA2-VAL1,
WA1-VAL2 TO WA2-VAL2.
MODIFY ITAB2 FROM WA2 INDEX SY-TABIX TRANSPORTING VAL1 VAL2.
ELSE.
INSERT WA1 INTO ITAB2 INDEX SY-TABIX.
ENDIF.
ENDLOOP.
The above code uses BINARY SEARCH for collect semantics. READ BINARY runs in O( log2(n) ) time. The above piece of code can be more optimized by
LOOP AT ITAB1 INTO WA.
COLLECT WA INTO ITAB2.
ENDLOOP.
SORT ITAB2 BY K.
COLLECT, however, uses a hash algorithm and is therefore independent
of the number of entries (i.e. O(1)) .
9. "APPEND LINES OF itab1 TO itab2" accelerates the task of appending a table to another table considerably as compared to LOOP-APPEND-ENDLOOP.
APPEND LINES OF ITAB1 TO ITAB2.
This is more optimized as compared to
LOOP AT ITAB1 INTO WA.
APPEND WA TO ITAB2.
ENDLOOP.
10. DELETE ADJACENT DUPLICATES accelerates the task of deleting duplicate entries considerably as compared to READ-LOOP-DELETE-ENDLOOP.
DELETE ADJACENT DUPLICATES FROM ITAB COMPARING K.
This is much more optimized as compared to
READ TABLE ITAB INDEX 1 INTO PREV_LINE.
LOOP AT ITAB FROM 2 INTO WA.
IF WA = PREV_LINE.
DELETE ITAB.
ELSE.
PREV_LINE = WA.
ENDIF.
ENDLOOP.
11. "DELETE itab FROM ... TO ..." accelerates the task of deleting a sequence of lines considerably as compared to DO -DELETE-ENDDO.
DELETE ITAB FROM 450 TO 550.
This is much more optimized as compared to
DO 101 TIMES.
DELETE ITAB INDEX 450.
ENDDO.
12. Copying internal tables by using ITAB2[ ] = ITAB1[ ] as compared to LOOP-APPEND-ENDLOOP.
ITAB2[] = ITAB1[].
This is much more optimized as compared to
REFRESH ITAB2.
LOOP AT ITAB1 INTO WA.
APPEND WA TO ITAB2.
ENDLOOP.
13. Specify the sort key as restrictively as possible to run the program faster.
SORT ITAB BY K. makes the program runs faster as compared to SORT ITAB.
Internal Tables contd
Hashed and Sorted tables
1. For single read access hashed tables are more optimized as compared to sorted tables.
2. For partial sequential access sorted tables are more optimized as compared to hashed tables
Hashed And Sorted Tables
Point # 1
Consider the following example where HTAB is a hashed table and STAB is a sorted table
DO 250 TIMES.
N = 4 * SY-INDEX.
READ TABLE HTAB INTO WA WITH TABLE KEY K = N.
IF SY-SUBRC = 0.
ENDIF.
ENDDO.
This runs faster for single read access as compared to the following same code for sorted table
DO 250 TIMES.
N = 4 * SY-INDEX.
READ TABLE STAB INTO WA WITH TABLE KEY K = N.
IF SY-SUBRC = 0.
ENDIF.
ENDDO.
Point # 2
Similarly for Partial Sequential access the STAB runs faster as compared to HTAB
LOOP AT STAB INTO WA WHERE K = SUBKEY.
ENDLOOP.
This runs faster as compared to
LOOP AT HTAB INTO WA WHERE K = SUBKEY.
ENDLOOP. -
Can someone pls help me with this code
The method createScreen() creates the first screen wherein the user makes a selection if he wants all the data ,in a range or single data.The problem comes in when the user makes a selection of single.that then displays the singleScreen() method.Then the user has to input a key data like date or invoice no on the basis of which all the information for that set of data is selected.Now if the user inputs a wrong key that does not exist for the first time the program says invalid entry of data,after u click ok on the option pane it prompts him to enter the data again.But since then whenever the user inputs wrong data the program says wrong data but after displaying the singlescreen again does not wait for input from the user it again flashes the option pane with the invalid entry message.and this goes on doubling everytime the user inputs wrong data.the second wrong entry of data flashes the error message twice,the third wrong entry flashes the option pane message 4 times and so on.What actually happens is it does not wait at the singlescreen() for user to input data ,it straight goes into displaying the JOptionPane message for wrong data entry so we have to click the optiion pane twice,four times and so on.
Can someone pls help me with this!!!!!!!!!
import java.util.*;
import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;
import java.text.*;
import java.util.*;
public class MainMenu extends JFrame implements ActionListener,ItemListener{
//class
FileReaderDemo1 fd=new FileReaderDemo1();
FileReaderDemo1 fr;
Swing1Win sw;
//primary
int monthkey=1,counter=0;
boolean flag=false,splitflag=false;
String selection,monthselection,dateselection="01",yearselection="00",s,searchcriteria="By Date",datekey,smonthkey,invoiceno;
//arrays
String singlesearcharray[];
String[] monthlist={"Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sept","Oct","Nov","Dec"};
String[] datelist=new String[31];
String[] yearlist=new String[100];
String[] searchlist={"By Date","By Invoiceno"};
//collection
Hashtable allinvoicesdata=new Hashtable();
Vector data=new Vector();
Enumeration keydata;
//components
JButton next=new JButton("NEXT>>");
JComboBox month,date,year,search;
JLabel bydate,byinvno,trial;
JTextField yeartext,invtext;
JPanel panel1,panel2,panel3,panel4;
JRadioButton single,range,all;
ButtonGroup group;
JButton select=new JButton("SELECT");
//frame and layout declarations
JFrame jf;
Container con;
GridBagLayout gridbag=new GridBagLayout();
GridBagConstraints gc=new GridBagConstraints();
//constructor
MainMenu(){
jf=new JFrame();
con=getContentPane();
con.setLayout(null);
fr=new FileReaderDemo1();
createScreen();
setSize(500,250);
setLocation(250,250);
setVisible(true);
//This is thefirst screen displayed
public void createScreen(){
group=new ButtonGroup();
single=new JRadioButton("SINGLE");
range=new JRadioButton("RANGE");
all=new JRadioButton("ALL");
search=new JComboBox(searchlist);
group.add(single);
group.add(range);
group.add(all);
single.setBounds(100,50,100,20);
search.setBounds(200,50,100,20);
range.setBounds(100,90,100,20);
all.setBounds(100,130,100,20);
select.setBounds(200,200,100,20);
con.add(single);
con.add(search);
con.add(range);
con.add(all);
con.add(select);
search.setEnabled(false);
single.addItemListener(this);
search.addActionListener(new MyActionListener());
range.addItemListener(this);
all.addItemListener(this);
select.addActionListener(this);
public class MyActionListener implements ActionListener{
public void actionPerformed(ActionEvent a){
JComboBox cb=(JComboBox)a.getSource();
if(a.getSource().equals(month))
monthkey=((cb.getSelectedIndex())+1);
if(a.getSource().equals(date)){
dateselection=(String)cb.getSelectedItem();
if(a.getSource().equals(year))
yearselection=(String)cb.getSelectedItem();
if(a.getSource().equals(search)){
searchcriteria=(String)cb.getSelectedItem();
public void itemStateChanged(ItemEvent ie){
if(ie.getItem()==single){
selection="single";
search.setEnabled(true);
else if (ie.getItem()==all){
selection="all";
search.setEnabled(false);
else if (ie.getItem()==range){
search.setEnabled(false);
public void actionPerformed(ActionEvent ae){
if(ae.getSource().equals(select))
if(selection.equals("single")){
singleScreen();
if(selection.equals("all"))
sw=new Swing1Win();
if(ae.getSource().equals(next)){
if(monthkey<9)
smonthkey="0"+monthkey;
System.out.println(smonthkey+"/"+dateselection+"/"+yearselection+"it prints this");
allinvoicesdata=fr.read(searchcriteria);
if (searchcriteria.equals("By Date")){
System.out.println("it goes in this");
singleinvoice(smonthkey+"/"+dateselection+"/"+yearselection);
else if (searchcriteria.equals("By Invoiceno")){
invoiceno=invtext.getText();
singleinvoice(invoiceno);
if (flag == false){
System.out.println("flag is false");
singleScreen();
else{
System.out.println("its in here");
singlesearcharray=new String[data.size()];
data.copyInto(singlesearcharray);
sw=new Swing1Win(singlesearcharray);
public void singleinvoice(String searchdata){
keydata=allinvoicesdata.keys();
while(keydata.hasMoreElements()){
s=(String)keydata.nextElement();
if(s.equals(searchdata)){
System.out.println(s);
flag=true;
break;
if (flag==true){
System.out.println("vector found");
System.exit(0);
data= ((Vector)(allinvoicesdata.get(s)));
else{
JOptionPane.showMessageDialog(jf,"Invalid entry of date : choose again");
public void singleScreen(){
System.out.println("its at the start");
con.removeAll();
SwingUtilities.updateComponentTreeUI(con);
con.setLayout(null);
counter=0;
panel2=new JPanel(gridbag);
bydate=new JLabel("By Date : ");
byinvno=new JLabel("By Invoice No : ");
dateComboBox();
invtext=new JTextField(6);
gc.gridx=0;
gc.gridy=0;
gc.gridwidth=1;
gridbag.setConstraints(month,gc);
panel2.add(month);
gc.gridx=1;
gc.gridy=0;
gridbag.setConstraints(date,gc);
panel2.add(date);
gc.gridx=2;
gc.gridy=0;
gc.gridwidth=1;
gridbag.setConstraints(year,gc);
panel2.add(year);
bydate.setBounds(100,30,60,20);
con.add(bydate);
panel2.setBounds(170,30,200,30);
con.add(panel2);
byinvno.setBounds(100,70,100,20);
invtext.setBounds(200,70,50,20);
con.add(byinvno);
con.add(invtext);
next.setBounds(300,200,100,20);
con.add(next);
if (searchcriteria.equals("By Invoiceno")){
month.setEnabled(false);
date.setEnabled(false);
year.setEnabled(false);
else if(searchcriteria.equals("By Date")){
byinvno.setEnabled(false);
invtext.setEnabled(false);
monthkey=1;
dateselection="01";
yearselection="00";
month.addActionListener(new MyActionListener());
date.addActionListener(new MyActionListener());
year.addActionListener(new MyActionListener());
next.addActionListener(this);
invtext.addKeyListener(new KeyAdapter(){
public void keyTyped(KeyEvent ke){
char c=ke.getKeyChar();
if ((c == KeyEvent.VK_BACK_SPACE) ||(c == KeyEvent.VK_DELETE)){
System.out.println(counter+"before");
counter--;
System.out.println(counter+"after");
else
counter++;
if(counter>6){
System.out.println(counter);
counter--;
ke.consume();
else
if(!((Character.isDigit(c) || (c == KeyEvent.VK_BACK_SPACE) || (c == KeyEvent.VK_DELETE)))){
getToolkit().beep();
counter--;
JOptionPane.showMessageDialog(null,"please enter numerical value");
ke.consume();
System.out.println("its at the end");
public void dateComboBox(){
for (int counter=0,day=01;day<=31;counter++,day++)
if(day<=9)
datelist[counter]="0"+String.valueOf(day);
else
datelist[counter]=String.valueOf(day);
for(int counter=0,yr=00;yr<=99;yr++,counter++)
if(yr<=9)
yearlist[counter]="0"+String.valueOf(yr);
else
yearlist[counter]=String.valueOf(yr);
month=new JComboBox(monthlist);
date=new JComboBox(datelist);
year=new JComboBox(yearlist);
public static void main(String[] args){
MainMenu mm=new MainMenu();
public class WindowHandler extends WindowAdapter{
public void windowClosing(WindowEvent we){
jf.dispose();
System.exit(0);
}Hi,
I had a similar problem with a message dialog. Don't know if it is a bug, I was in a hurry and had no time to search the bug database... I found a solution by using keyPressed() and keyReleased() instead of keyTyped():
private boolean pressed = false;
public void keyPressed(KeyEvent e) {
pressed = true;
public void keyReleased(KeyEvent e) {
if (!pressed) {
e.consume();
return;
// Here you can test whatever key you want
//...I don't know if it will help you, but it worked for me.
Regards. -
Can any one help me in this code
Hi all,
I have created a selection screen and my aim is to display some fields or some block dynamically by choosing some radio button is it possible.
can any one help me in this.
REPORT z_g_test.
TABLES: spfli,sbook,sscrfields.
SELECTION-SCREEN BEGIN OF BLOCK 1 WITH FRAME TITLE text-001.
SELECT-OPTIONS:s_carrid FOR spfli-carrid.
SELECTION-SCREEN END OF BLOCK 1.
PARAMETERS:rad1 RADIOBUTTON GROUP g1 USER-COMMAND us1,
rad2 RADIOBUTTON GROUP g1 DEFAULT 'X' .
SELECTION-SCREEN BEGIN OF SCREEN 001 as subscreen ."WITH FRAME TITLE text-002.
SELECT-OPTIONS: s_fldate FOR sbook-fldate.
SELECTION-SCREEN END OF SCREEN 001.
DATA ok_code LIKE sy-ucomm.
INITIALIZATION.
START-OF-SELECTION.
SELECT * FROM spfli WHERE carrid IN s_carrid.
ENDSELECT.
END-OF-SELECTION.
WRITE:spfli-carrid.
AT SELECTION-SCREEN.
CASE sscrfields-ucomm.
WHEN'US1'.
* call screen 001 starting at 55 40.
ENDCASE.
Is i am going on the right way
Regards,
Lisa.
Message was edited by: Lisa Roy
Message was edited by: Lisa Roy
Message was edited by: Lisa RoyThis is what I meant. Copy this and try as it is and see if it serves your purpose.
REPORT ztest1 .
TABLES: spfli, sscrfields, sbook.
SELECTION-SCREEN BEGIN OF TABBED BLOCK tabb1 FOR 4 LINES.
SELECTION-SCREEN TAB (25) tabs1 USER-COMMAND ucomm1
DEFAULT SCREEN 001.
SELECTION-SCREEN TAB (25) tabs2 USER-COMMAND ucomm2
DEFAULT SCREEN 002.
SELECTION-SCREEN END OF BLOCK tabb1.
SELECTION-SCREEN BEGIN OF BLOCK b1 WITH FRAME TITLE abc.
PARAMETERS: p_date LIKE sy-datum.
SELECTION-SCREEN END OF BLOCK b1.
SELECTION-SCREEN BEGIN OF SCREEN 001 AS SUBSCREEN .
SELECT-OPTIONS: s_fldate FOR sbook-fldate.
SELECTION-SCREEN END OF SCREEN 001.
SELECTION-SCREEN BEGIN OF SCREEN 002 AS SUBSCREEN .
SELECT-OPTIONS:s_carrid FOR spfli-carrid.
SELECTION-SCREEN END OF SCREEN 002.
INITIALIZATION.
tabs1 = 'Search by flight date'.
tabs2 = 'Search by flight number'.
abc = 'Some other parameters'.
AT SELECTION-SCREEN OUTPUT.
CASE sscrfields-ucomm.
WHEN 'UCOMM1'.
tabb1-prog = sy-repid.
tabb1-dynnr = 001.
tabb1-activetab = 'TABS1'.
WHEN 'UCOMM2'.
tabb1-prog = sy-repid.
tabb1-dynnr = 002.
tabb1-activetab = 'TABS2'.
ENDCASE. -
Can you help me with this code
hi am new to java so please bare with me , so in this code as you can see i comment some lines of code the one i comment works when i compile it , but why the one with fields does not ? can you please explain this to me
public class Demo3
public static int a = 5;
public static int b = 6;
public static int c = a+b;
public static int d = b-a;
a*=5;
public static void main (String [] args)
/*int a = 5;
int b = 6;
int c = a+b;
int d = b-a;
a*=5;
System.out.println (a);
System.out.println (b);
System.out.println (c);
System.out.println (d);
}>
public class Demo3
public static int a = 5;
public static int b = 6;
public static int c = a+b;
public static int d = b-a;
a*=5;This is not possible. write this statement in a function.
or
in a static block like
static {
a*=5;
}>
public static void main (String [] args)
/*int a = 5;
int b = 6;
int c = a+b;
int d = b-a;
a*=5;
System.out.println (a);
System.out.println (b);
System.out.println (c);
System.out.println (d); -
Can anybody help me with this code?
I am a beginner to J2ME. The following is a small program I wrote just for test.
Theoretically, in my opinion, I shall see in the screen a number increase from 1 to 29999 rapidly after execute the code. But instead, it displays nothing but only displays 29999 after several seconds . Can some body point out what's wrong with this code? Thanks.
import javax.microedition.midlet.*;
import javax.microedition.lcdui.*;
public class Test extends MIDlet{
int x=1;
String b="";
private Display display;
public Test() {
display = Display.getDisplay(this);
public void startApp() {
MyCanvas mc = new MyCanvas() ;
display.setCurrent(mc) ;
while(x<30000){
b=String.valueOf(x);
mc.repaint();
x++;
public void pauseApp() {
public void destroyApp(boolean unconditional) {
class MyCanvas extends Canvas{
public void paint(Graphics g){
g.drawString(b,10,10,0);thanks, I have already got the answer. you are right, if repaint in a high speed the screen will show nothing. here is the code for it, thanks the expert of nokia forum.
import javax.microedition.midlet.*;
import javax.microedition.lcdui.*;
//Counter
//Need to know when a number has been painted and need to wait a for a fraction of a sec before
//painting the next number. This wait also allows other events like "Exit" to be processed
//Use double buffering to avoid flicker
//Paint in a different thread to keep the UI responsive
public class MyMIDlet extends MIDlet{
int x=1;
String b="";
private Display display;
Thread t = null;
MyCanvas mc = null;
public MyMIDlet() {
display = Display.getDisplay(this);
public void startApp() {
mc = new MyCanvas();
t = new Thread(mc) ;
display.setCurrent(mc) ;
b=String.valueOf(x);
t.start();
public void callbackPaintDone(){
try{
//provides the delay between every repaint and also time to react to Exit
synchronized(this){
wait(1);
}catch(Exception e){}
paintNextNumber();
private void paintNextNumber(){
if(x<30000){
x++;
b=String.valueOf(x);
mc.doPaint = true; //signals that next number can be painted
public void pauseApp() {
public void destroyApp(boolean unconditional) {
class MyCanvas extends Canvas implements Runnable{
Image buf = null;
Graphics bg = null;
public boolean doPaint = true;
public MyCanvas(){
buf = Image.createImage(getWidth(),getHeight());
bg = buf.getGraphics();
public void paint(Graphics g){
bg.setColor(255,255,255);
bg.fillRect(0,0,getWidth(),getHeight());
bg.setColor(0);
bg.drawString(b,10,10,0);
g.drawImage(buf,10,10,Graphics.TOP|Graphics.LEFT);
// Callback for next number to be painted
MyMIDlet.this.callbackPaintDone();
public void run(){
while(true){
if(doPaint){ //only paints when a number has been painted, and next one is ready to be painted
doPaint = false;
repaint();
serviceRepaints(); -
Please, I want to help in correcting this code
I want to know what mistakes in this code where it gives the message (frm-41214 unable to run report)
the code
DECLARE
v_rep_id REPORT_OBJECT;
v_repjob VARCHAR2(100);
v_job_id VARCHAR2(100);
v_rep_status VARCHAR2(100);
v_reportsrvr VARCHAR2(50) := 'rep10';
v_runformat vARCHAR2(50) := 'pdf';
BEGIN
IF :date_from IS NULL and :date_to is null and :ITEM4 is null THEN
RAISE FORM_TRIGGER_FAILURE;
END IF;
v_rep_id := FIND_REPORT_OBJECT('REPORT2');
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_COMM_MODE, SYNCHRONOUS);
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_DESTYPE, CACHE);
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_SERVER, v_reportsrvr);
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_DESFORMAT, v_runformat);
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_OTHER , 'P_date="' || TO_CHAR(:date_from, 'dd/mm/yyyy') || '" P_date1="'|| TO_CHAR(:date_to, 'dd/mm/yyyy') || '"'||'" p_no="' || :ITEM4||'" paramform=no"');
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_FILENAME, 'd:\ltvisits_omayma.rdf');
v_repjob := RUN_REPORT_OBJECT(v_rep_id);
v_job_id := SUBSTR(v_repjob, LENGTH(v_reportsrvr) + 2, LENGTH(v_repjob) );
v_rep_status := REPORT_OBJECT_STATUS(v_repjob);
IF v_rep_status = 'FINISHED' THEN
WEB.SHOW_DOCUMENT('/reports/rwservlet/getjobid' || v_job_id ||'?server=' || v_reportsrvr || '', '_blank');
ELSE
message('Report failed with error message ');
END IF;
CLEAR_FORM;
END;Hi,
You CANNOT use hardcord path in report name
SET_REPORT_OBJECT_PROPERTY(v_rep_id, REPORT_FILENAME, 'd:\ltvisits_omayma.rdf'); Remove "d:\" part from the report name and then copy your report to FORMS_PATH location.
*If answer is correct then please mark it.
Maybe you are looking for
-
Hi, I have a Windows 2008R2 Updated / Exchange 2010 SP3 Rollup 7 (Role CAS,HUB,MBX) with only external users connection : ActiveSync, EWS, OWA, Outlook Anywhere. 4 processors and 24Go of memory are allocated to the Exchange server VM (VMWare). Netsca
-
Data Migration from existing legacy to SRM
Hello All , We are preparing for cutover of our SRM implementation. Version in SRM 5.0 tech scenario - Classic. The business scenario is Sourcing with Bid Invitation. At our client's place existing legacy is working where they have many open Bid Invi
-
InDesign CC book bookmarks not working in PDF
Hi This is less a question and more an answer to a problem I was having that I found an answer to elsewhere so I thought I'd post it here for others. I have a 580 book in InDesign CC with a TOC and automatic bookmarks for all the chapters and subsect
-
How to manage a connection with powershell using visual studio with C#
Hi I want to manage a connection with powershell for a web app using visual studio with c#. and also run command with pipeline Plz give a some suggestions..
-
Closing programs within a repeat
Hello, I am writing a program that inserts photos and descriptions of them into Appleworks. I want to be able to close the preview program after I insert the photo into appleworks. Thanks for teh help.