Help with performance of a subroutine

Question

Hi Experts,
can anyone help me tweek the code so that the performance is improved? will appreciate ur response.
thanks in advance.
*&      Form  GET_PHY_QUANTITY
      text
     -->P_LT_LAGP  text
     <--P_LS_LAGP  text
     <--P_LT_PHYSICAL  text
form get_phy_quantity  using    p_lt_aqua type tt_aqua
                                p_lt_lagp type tt_lagp
                       changing p_ls_aqua type gs_aqua
                                p_ls_lagp type gs_lagp
                                p_lt_physical.
  types: begin of ty_hu,
     lgnum_hu    type /scwm/lgnum,
     huident     type /scwm/de_huident,
     guid_hu     type guid,
    end of ty_hu.
  types: begin of ty_ordim,
    lgnum      type /scwm/lgnum,
    lgpla      type /scwm/lgpla,
    guid_stock type /lime/guid_stock,
   end of ty_ordim.
  types: begin of ty_nquan,
      guid_stock  type /lime/guid_stock,
      guid_parent type /lime/guid_parent,
      punit       type /lime/unit,
      pquan       type /lime/quantity,
      coo         type /scwm/de_coo,
      lgpla       type /scwm/lgpla,   "RJ
    end of ty_nquan.
  data: ls_hu    type ty_hu,
        ls_ordim type ty_ordim,
        ls_nquan type ty_nquan,
        lv_tabix type sy-tabix.
  data: lt_guid  type standard table of ty_hu,
        ls_guid  type  ty_hu,
        lt_hu    type standard table of ty_hu,
        lt_ordim like standard table of ls_ordim,
        lt_nquan like standard table of ls_nquan .
  data: ls_data type zspm_binquan.
  data: lt_data type standard table of zspm_binquan.
lgpla in p_lt_lagp and huident in /scwm/hu_iw01 have different data types.
So, we are moving the lgpla field to a huident field before selection from the table.
  loop at p_lt_lagp into p_ls_lagp.
    move p_ls_lagp-lgnum to ls_hu-lgnum_hu.
    move p_ls_lagp-lgpla to ls_hu-huident.
    append ls_hu to lt_hu.
    read table p_lt_aqua into p_ls_aqua with key lgnum = p_ls_lagp-lgnum
                                                 lgpla = p_ls_lagp-lgpla
                                                 matid = '00000000000000000000000000000000'.
    if sy-subrc = 0.
" If AQUA table has blank Product, we have to get it from WT table.
     IF  p_ls_aqua-matid IS INITIAL.
        move p_ls_aqua-guid_stock to ls_ordim-guid_stock.
        move p_ls_aqua-lgnum to ls_ordim-lgnum.
        move p_ls_aqua-lgpla to ls_ordim-lgpla.
        append ls_ordim to lt_ordim.
     ENDIF.
    endif.
  endloop.
  clear: ls_ordim, ls_hu, p_ls_aqua, p_ls_lagp.
  select lgnum_hu huident guid_hu
   from /scwm/hu_iw01
    into table lt_guid
    for all entries in lt_hu
  where lgnum_hu = lt_hu-lgnum_hu and huident = lt_hu-huident.
  if sy-subrc = 0.
    sort lt_guid by guid_hu.
    delete adjacent duplicates from lt_guid comparing all fields.
  endif.
  select n~guid_stock
         n~guid_parent
         n~unit
         n~quan
         q~coo
            into table lt_nquan
           from ( /lime/nquan as n
        left outer join /scwm/quan  as q
          on qguid_stock = nguid_stock
          and qguid_parent = nguid_parent )
        for all entries in lt_guid
          where n~guid_parent = lt_guid-guid_hu
            and n~guid_stock gt '0000000000000000'
            and n~vsi eq space
            and n~quan gt 0.
  sort lt_nquan by guid_parent guid_stock.
   loop at lt_nquan into ls_nquan.    "RJ
     lv_tabix = sy-tabix.
     read table lt_guid into ls_guid with key guid_hu =  ls_nquan-guid_parent.
     if sy-subrc eq 0.
     ls_nquan-lgpla = ls_guid-huident.
     modify lt_nquan from ls_nquan index lv_tabix.
     endif.
   endloop.
  loop at lt_nquan into ls_nquan.
If there is physical qty but no available quantity, move to lt_ordim table.
    read table p_lt_aqua into p_ls_aqua with key guid_stock  = ls_nquan-guid_stock
                                                       lgpla = ls_nquan-lgpla.
    if sy-subrc ne 0.
      read table lt_guid into ls_hu with key guid_hu = ls_nquan-guid_parent binary search.
      if sy-subrc = 0.
        move ls_hu-lgnum_hu      to ls_ordim-lgnum.
        move ls_hu-huident       to ls_ordim-lgpla.
        move ls_nquan-guid_stock to ls_ordim-guid_stock.
        append ls_ordim to lt_ordim.
      endif.
    endif.
  endloop.
  sort lt_ordim by lgpla guid_stock.
  clear: ls_nquan, ls_ordim.
  loop at lt_nquan into ls_nquan.
    move-corresponding ls_nquan to ls_data.
If not in AQUA table, get the batch, stock type from WT tables, ORDIM_O or ORDIM_C.
    read table lt_ordim into ls_ordim with key  lgpla = ls_nquan-lgpla
                                                guid_stock = ls_nquan-guid_stock binary search.
    if sy-subrc = 0.
      select single matid cat charg wdatu
       from /scwm/ordim_o
       into (ls_data-matid, ls_data-cat, ls_data-charg, ls_data-wdatu)
       where lgnum eq ls_ordim-lgnum and guid_stock eq ls_ordim-guid_stock.
      if sy-subrc ne 0.
        select single matid cat charg wdatu
        from /scwm/ordim_c
        into (ls_data-matid, ls_data-cat, ls_data-charg, ls_data-wdatu)
        where lgnum eq ls_ordim-lgnum and guid_stock eq ls_ordim-guid_stock.
      endif.
      ls_data-lgnum   = ls_ordim-lgnum.
      ls_data-huident = ls_ordim-lgpla.
    else. " if there is avail. qty., get batch and other info from AQUA table.
      read table p_lt_aqua into p_ls_aqua with key guid_stock = ls_nquan-guid_stock 
                                                                        lgpla = ls_nquan-lgpla.
      if sy-subrc = 0.
        ls_data-lgnum   = p_ls_aqua-lgnum.
        ls_data-huident = p_ls_aqua-lgpla.
        ls_data-matid   = p_ls_aqua-matid.
        ls_data-cat     = p_ls_aqua-cat.
        ls_data-charg   = p_ls_aqua-charg.
        ls_data-wdatu   = p_ls_aqua-wdatu.
      endif.
    endif.
    append ls_data to lt_data.
  endloop.
  p_lt_physical = lt_data.
  refresh: lt_data, lt_ordim, lt_guid, lt_hu, lt_nquan.
endform.                    " GET_PHY_QUANTITY

Answer 1

Hi friends,
I have a function module which does array insertions and is causing a slowdown can you please recommend any changes ? or any ideas as to what can be done? Thanks in advance.
Thanks,
Kathy.
<code>
function Zwmsid_ship_id_insert .
""Update Function Module:
""Local Interface:
*"  IMPORTING
*"     VALUE(IT_SHIP_ID_HD) TYPE  Z_TT_SID_HD
*"     VALUE(IT_SHIP_ID_ITM) TYPE  Z_TT_SID_IT
*"     VALUE(IT_SHIP_ID_PR) TYPE  Z_TT_SID_PR
*"     VALUE(IT_SHIP_ID_HU) TYPE  Z_TT_SID_HU
*"     VALUE(IT_SHIP_ID_REFDOC) TYPE  Z_TT_SID_RFD
*"  EXCEPTIONS
*"      INSERTION_FAILED
This is for Inserting Data from the IMPORT parameter Tables into
the DB tables.
To avoid run-time dump, ACCEPTING DUPLICATE KEYS addition is used.
if exception is result, ROLLBACK work is done in the calling module
Local Data Objects
Variables
  data: lv_initial_sid type c,
Work Area
        ls_ship_id_hd type Z_tsid_hd,   " Ship-Id Header
        ls_sid_ht type Z_tsid_ht,       " Ship-ID History
Internal Tables
        lt_sid_ht type Z_tt_sid_ht.     " Ship-ID History Table
  data: lv_timestamp(15) type c,
        lv_systimstp     type /scdl/dl_cretst,
        lv_tz            type tznzone          value 'UTC'.
Build the Ship-ID data for building History table
  loop at it_ship_id_hd into ls_ship_id_hd.
    if ls_ship_id_hd-ship_id  is initial.
      lv_initial_sid = gc_x.
    endif.
    ls_sid_ht-ship_id        = ls_ship_id_hd-ship_id  . " Ship-ID
    ls_sid_ht-status         = gc_created             . " CR
    ls_sid_ht-direction      = ls_ship_id_hd-direction. " Direction
    ls_sid_ht-username       = sy-uname               . " User Name
    append ls_sid_ht to lt_sid_ht.
    clear: ls_sid_ht, ls_ship_id_hd.
  endloop.
  if not lv_initial_sid is initial.
    clear: lv_initial_sid.
    message e014 raising insertion_failed.
  endif.
Inserting Ship-ID Header Data
  insert Z_tsid_hd from table it_ship_id_hd
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
Inserting Ship-ID Item Data
  insert Z_tsid_it from table it_ship_id_itm
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
Inserting Ship-ID Partner Data
  insert Z_tsid_pr from table it_ship_id_pr
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
Inserting Ship-ID HU (handling Unit) Data
  insert Z_tsid_hu from table it_ship_id_hu
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
Inserting Ship-ID Reference Document table Data
  insert Z_tsid_rfd from table it_ship_id_refdoc
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
Inserting into Ship-ID History Table
  insert Z_tsid_ht from table lt_sid_ht
         accepting duplicate keys.
  if sy-subrc ne 0.
    message e011 raising insertion_failed.
  endif.
endfunction.
<code>