Help with Performance tunning PL/SQL

Question

Hi All,
I have a PL/SQL procedure, it works fine. No errors, and no bugs. However its taking forever to finish. I am using the concatenation operator (||), and I know its expensive. How can I improve performance to the procedure ?
Here is the code
create or replace
PROCEDURE POST_ADDRESS_CLEANSE AS
CURSOR C1 IS
SELECT Z.ROW_ID,
        Z.NAME
FROM  STGDATA.ACCOUNT_SOURCE Z;
CURSOR  C2 IS
SELECT  DISTINCT CLEANSED_NAME || CLEANSED_STREET_ADDRESS ||
        CLEANSED_STREET_ADDRESS_2 || CLEANSED_CITY || CLEANSED_STATE ||
        CLEANSED_POSTAL_CODE AS FULLRECORD
FROM    STGDATA.ACCOUNT_SOURCE_CLEANSED;
V_ROWID Number := 1;
V_FLAG VARCHAR2(30);
TEMP_ROW_ID VARCHAR2(10) := NULL;
BEGIN
  -- This loop will update CLEANSED_NAME column in ACCOUNT_SOURCE_CLEANSED table.
  FOR X IN C1 LOOP
    TEMP_ROW_ID := TO_CHAR(X.ROW_ID);
  UPDATE STGDATA.ACCOUNT_SOURCE_CLEANSED A
  SET  A.CLEANSED_NAME = X.NAME
  WHERE A.ROW_ID = TEMP_ROW_ID;
    COMMIT;
  END LOOP;
  -- This loop will update columns EM_PRIMARY_FLAG, EM_GROUP_ID in ACCOUNT_SOURCE_CLEANSED table
  FOR Y IN C2 LOOP
    UPDATE  STGDATA.ACCOUNT_SOURCE_CLEANSED
    SET     EM_GROUP_ID = V_ROWID
    WHERE   CLEANSED_NAME || CLEANSED_STREET_ADDRESS || CLEANSED_STREET_ADDRESS_2 ||
            CLEANSED_CITY || CLEANSED_STATE || CLEANSED_POSTAL_CODE = Y.FULLRECORD;
    UPDATE  STGDATA.ACCOUNT_SOURCE_CLEANSED
    SET     EM_PRIMARY_FLAG = 'Y'
    WHERE   CLEANSED_NAME || CLEANSED_STREET_ADDRESS || CLEANSED_STREET_ADDRESS_2 ||
            CLEANSED_CITY || CLEANSED_STATE || CLEANSED_POSTAL_CODE = Y.FULLRECORD
    AND     ROWNUM = 1;
    V_ROWID := V_ROWID + 1;
    COMMIT;
  END LOOP;
  UPDATE  STGDATA.ACCOUNT_SOURCE_CLEANSED
  SET     EM_PRIMARY_FLAG = 'N'
  WHERE   EM_PRIMARY_FLAG IS NULL;
  COMMIT;
  --dbms_output.put_line('V_ROW:'||V_ROWID);
  --dbms_output.put_line('CLEANSED_NAME:'||Y.FULLRECORD); 
END POST_ADDRESS_CLEANSE;
Thanks in advance.
Message was edited by: Rooney -- added code using syntax highlight

Answer 1

I was able to modify my code a bit, however I don't see a way of not using loops.
In the loop, I am updating 2 columns. EM_PRIMARY_FLAG, and EM_GROUP_ID. The data I am working with has duplicate records, and that is why I am using a distinct in the cursor. The requirements are is to make one record a primary record, and the rest are reference records. What makes my record primary is updating column EM_PRIMARY_FLAG with a 'Y', and updating EM_GROUP_ID with a number combines all duplicate records into a group.
In the procedure, I am getting the distinct records, looping through each one, and then doing 2 updates:
1 - Update EM_PRIMARY_FLAG to 'Y' where rownum = 1, this will set one record to be primary
2 - Update EM_GROUP_ID to a number (V_ROWID := V_ROWID + 1) where V_ROWID starts from 1, to group all records into a set.
Here is my latest code after modifying it:
create or replace
PROCEDURE POST_ADDRESS_CLEANSE AS
CURSOR  C1 IS
SELECT      DISTINCT NVL(CLEANSED_NAME, '') AS NAME_CLEANSED,
                  NVL(CLEANSED_STREET_ADDRESS, '') AS ADDRESS_CLEANSED,
                  NVL(CLEANSED_STREET_ADDRESS_2, '') AS ADDRESS2_CLEANSED,
                  NVL(CLEANSED_CITY, '') AS CITY_CLEANSED,
                  NVL(CLEANSED_STATE, '') AS STATE_CLEANSED,
                  NVL(CLEANSED_POSTAL_CODE, '') AS POSTAL_CODE_CLEANSED
FROM        STGDATA.ACCOUNT_SOURCE_CLEANSED;
V_ROWID Number := 1;
V_FLAG VARCHAR2(30);
TEMP_ROW_ID VARCHAR2(10) := NULL;
BEGIN
    UPDATE STGDATA.ACCOUNT_SOURCE_CLEANSED A
    SET  A.CLEANSED_NAME = (SELECT   Z.NAME
                                                   FROM     STGDATA.ACCOUNT_SOURCE Z
                                                   WHERE    Z.ROW_ID = (SELECT  TO_NUMBER(B.ROW_ID)
                                                                                       FROM    STGDATA.ACCOUNT_SOURCE_CLEANSED B
                                                                                       WHERE   B.ROW_ID = A.ROW_ID));
    COMMIT;
  -- This loop will update columns EM_PRIMARY_FLAG, EM_GROUP_ID in ACCOUNT_SOURCE_CLEANSED table
  FOR Y IN C1 LOOP
    UPDATE   STGDATA.ACCOUNT_SOURCE_CLEANSED
    SET          EM_GROUP_ID = V_ROWID
    WHERE    CLEANSED_NAME = Y.NAME_CLEANSED
    AND          CLEANSED_STREET_ADDRESS = Y.ADDRESS_CLEANSED
    AND          CLEANSED_STREET_ADDRESS_2 = Y.ADDRESS2_CLEANSED
    AND          CLEANSED_CITY = Y.CITY_CLEANSED
    AND          CLEANSED_STATE = Y.STATE_CLEANSED
    AND          CLEANSED_POSTAL_CODE = Y.POSTAL_CODE_CLEANSED;
    UPDATE  STGDATA.ACCOUNT_SOURCE_CLEANSED
    SET     EM_PRIMARY_FLAG = 'Y'
    WHERE   CLEANSED_NAME = Y.NAME_CLEANSED
    AND     CLEANSED_STREET_ADDRESS = Y.ADDRESS_CLEANSED
    AND     CLEANSED_STREET_ADDRESS_2 = Y.ADDRESS2_CLEANSED
    AND     CLEANSED_CITY = Y.CITY_CLEANSED
    AND     CLEANSED_STATE = Y.STATE_CLEANSED
    AND     CLEANSED_POSTAL_CODE = Y.POSTAL_CODE_CLEANSED
    AND     ROWNUM = 1;
    V_ROWID := V_ROWID + 1;
  END LOOP;
  COMMIT;
  UPDATE  STGDATA.ACCOUNT_SOURCE_CLEANSED
  SET     EM_PRIMARY_FLAG = 'N'
  WHERE   EM_PRIMARY_FLAG IS NULL;
  COMMIT;
END POST_ADDRESS_CLEANSE;
Thanks
Message was edited by: Rooney - Just added the code in SQL block using syntax highlight.