I don't want to write too much code is there a different way of doing this

Question

I am writing a precedure to check on the max test scores for different codes ('S01','S02'.S03') --there are more
then I need to insert the table if the record with the best score does not exists for example for b.sortest_tesc_code = 'BSV', I am writing a cursor
for each code (.sortest_tesc_code = 'S01') is there a way to do this different? so I cant do something like a.sortest_tesc_code in ('S01','S02'.S03') and store in a
variable then insert, the problem is that you can have a student that have only one test other that have two etc..etc.. is not consistent, also If the b.sortest_tesc_code = 'BSV') is already in the table I don't do an insert I will have to do an update if the sortest_test_score is greater since the student can submit scores more than once... In another words check if the record exists( b.sortest_tesc_code = 'BSV') if is there compare with the new max score and if the new max score is greater then update.. If the score (by code) is not in the table insert
Hope this is clear, this is what I have, I now it will work but it will be too much code..check for exists and not exists in two different precedures..
Thank you
CURSOR get_the_max_scores_S01_cur IS
            SELECT
             sortest_pidm, a.sortest_test_score, a.sortest_tesc_code,
             a.sortest_test_date,a.sortest_equiv_ind
            FROM
            saturn.spriden, saturn.sortest a, saturn.stvtesc
           WHERE 
           a.sortest_pidm = spriden_pidm
          AND stvtesc_code = a.sortest_tesc_code
          AND spriden_change_ind IS NULL
       -----and   a.sortest_tesc_code in ('S01','S02'.S03')
       AND a.sortest_tesc_code = 'S01'
       --and spriden_id = p_student_id  --
       ---for test purposes
       AND sortest_pidm = 133999 ----THE WILL BE A PARAMETER
       AND a.sortest_test_score =
              (SELECT MAX (b.sortest_test_score)
                 FROM saturn.sortest b
                WHERE a.sortest_tesc_code = b.sortest_tesc_code
                      AND a.sortest_pidm = b.sortest_pidm)
                            AND NOT EXISTS
              (SELECT 1   FROM    saturn.sortest b
              WHERE    A.sortest_tesc_code = b.sortest_tesc_code
                      AND a.sortest_pidm = b.sortest_pidm     
                      and   b.sortest_tesc_code = 'BSV');
     BEGIN
                 UTL_FILE.fclose_all;
                 v_file_handle := UTL_FILE.fopen (v_out_path, v_out_file, 'a');
                UTL_FILE.put_line (v_file_handle,
                      CHR (10) || TO_CHAR (SYSDATE, 'DD-MON-YYYY HH:MI:SS'));
               UTL_FILE.put_line (v_file_handle, 'sortest_best_sct_scorest');
               --check for an open cursor before opening
               IF get_the_max_scores_S01_cur%ISOPEN
                   THEN
                    CLOSE get_the_max_scores_S01_cur;
               END IF;
            OPEN get_the_max_scores_S01_cur;
             LOOP
                   FETCH get_the_max_scores_S01_cur
                   INTO v_pidm, v_tscore, v_testcode,
                           v_test_date, v_equiv_ind;
                   EXIT WHEN get_the_max_scores_S01_cur%NOTFOUND;
               IF  get_the_max_scores_S01_cur%FOUND 
                THEN
                   INSERT INTO saturn.sortest
                   (sortest_pidm,sortest_tesc_code,sortest_test_date,sortest_test_score,
                    sortest_activity_date,sortest_equiv_ind,sortest_user_id,sortest_data_origin)
                    VALUES
                    v_pidm,
                   'BSV',
                    v_test_date,
                     v_tscore,
                     sysdate, 
                    v_equiv_ind,
                    p_user,
                    'best_test_scores process'
               END IF;    
               END LOOP;
               COMMIT;
               ---Initialize variables
                v_pidm := NULL;
                v_test_date := NULL; 
                v_tscore  := NULL; 
                v_equiv_ind :=  NULL;
                v_testcode  :=  NULL;
             CLOSE get_the_max_scores_S01_cur;
----then another do the same for S02...S03

Answer 1

Thank you, here is the code, I change the name of the tables, but it is the same concept.what I need is to extract the max score for each code (s01,s02,s03,s04)
then insert a record with a different code in the same table
BSM     Best Math SAT (S01)                              
BSW     Best writing SAT (S04)     
BSC     Best READING SAT (S03)     
BSE     Best READING SAT (S02)     
I need to be able to check if the BS codes are already in the table (BSM...BSC..) IF they are not do an insert and if they are do an update get the maximun score
again (the students can submit more than one score form the same code and any date) and if the maximun is different(greater) of what is already in the database (with the BSM...BSC.. codes) do an update, IF NOT if is the same or less don't update...
I need the PERSON table because I need to use the ID as a parameter they (user) can run the process for one ID or all the records in the table TEST
Thank you, I hope is clear
create table TEST
TEST_PIDM                  NUMBER(8)            NOT NULL,
TEST_TESC_CODE        VARCHAR2(4 CHAR)     NOT NULL,
TEST_TEST_DATE        DATE                 NOT NULL,
TEST_TEST_SCORE       VARCHAR2(5 CHAR)     NOT NULL,
TEST_ACTIVITY_DATE    DATE                 NOT NULL,
TEST_EQUIV_IND        VARCHAR2(1 CHAR)     NOT NULL
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'EB' ,TO_DATE( '01-JUN-2004', 'DD-MON-YYYY'),'710',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'M2' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'710',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S01' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'750',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S01' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'720',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S02' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S02' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'730',SYSDATE,'N'
FROM DUAL ;
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S03' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'780',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S03' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S04' ,TO_DATE( '01-JUN-2005', 'DD-MON-YYYY'),'770',SYSDATE,'N'
FROM DUAL; 
INSERT INTO TEST
( TEST_PIDM, TEST_TESC_CODE,TEST_TEST_DATE, TEST_TEST_SCORE, TEST_ACTIVITY_DATE,TEST_EQUIV_IND)
SELECT
128019,'S04' ,TO_DATE( '05-JUL-2005', 'DD-MON-YYYY'),'740',SYSDATE,'N'
FROM DUAL; 
CREATE TABLE PERSON
  PERSON_PIDM                NUMBER(8)         NOT NULL,
  PERSON_ID                  VARCHAR2(9 CHAR)  NOT NULL
INSERT INTO  PERSON
( PERSON_PIDM ,   PERSON_ID)
SELECT
128019,'003334556'
FROM DUAL ;
CREATE TABLE VALTSC
VALTSC_CODE             VARCHAR2(4 CHAR)     NOT NULL,
  VALTSC_DESC             VARCHAR2(30 CHAR)
INSERT INTO  VALTSC
VALTSC_CODE,
  VALTSC_DESC 
SELECT
'S01' ,
'XXS01'
FROM DUAL; 
  INSERT INTO  VALTSC
VALTSC_CODE,
  VALTSC_DESC 
SELECT
'S02' ,
'XXS02'
FROM DUAL 
  INSERT INTO  VALTSC
VALTSC_CODE,
  VALTSC_DESC 
SELECT
'S03' ,
'XXS03'
FROM DUAL; 
INSERT INTO  VALTSC
VALTSC_CODE,
  VALTSC_DESC 
SELECT
'S04' ,
'XXS04'
FROM DUAL;