I have a minor string issue

Question

Been looking at the code all day but if I can get a little help this would be great...
I have a hashtable of buttons and strings and i run a loop to see if they are true...
public static String checkCaja()
       String temp="";
       for(String name:checkboxes.keySet()){
           // System.out.println(checkboxes.get(name).isSelected()+name);
            if (checkboxes.get(name).isSelected()==true)
                 temp=temp+name+",";
     return temp;
  }the temp returns the strings with an ','. So I will get a
From one,two,three,four, five,
I would like to remove the last comma from the last word added... any ideas?
It should look like one, two,three,four,five
Thank you in advance!

Answer 1

As long as we are tweaking code, when you're iterating over names and values, you should use the entry set:
String f(Map<String, JCheckBox> checkboxes) {
    StringBuffer sb = new StringBuffer();
    for(Map.Entry < String, JCheckBox > e : checkboxes.entrySet()) {
        if(e.getValue().isSelected()) {
            if (sb.length() > 0)
                sb.append(", ");
            sb.append(e.getKey());
    return sb.toString();
}I would also go with adding the delimiter every time, then substringing to remove the last one, if any:
String f(Map<String, JCheckBox> checkboxes) {
    String DELIM = ", ";
    StringBuffer sb = new StringBuffer();
    for(Map.Entry < String, JCheckBox > e : checkboxes.entrySet())
        if(e.getValue().isSelected())
            sb.append(e.getKey()).append(DELIM);
    String s = sb.toString();
    int length = s.length();
    return length > 0 ? s.substring(0, length - DELIM.length()) : s;
}