Images become corrupted after uploading

Question

Hello i'm trying to make an upload bean that uploads files form client PCs to the server, i'm using jdk 1.4 and tomcat 4.0.
i made a modification to "Budi Kurniawan" code from "http://www.onjava.com/pub/a/onjava/2001/04/05/upload.html"
and the package is working very well only with text files.
when i tried to upload images or exe . i found the files corrupted. i compaired the original files with the uploaded one and they was the same in size.
i think the problem is with the way i process the content type of the file.
please if u have any ideas to modify this code to enable it to upload images and exe please post ur reply.
the package name is "michael.web.upload" this package should be able to handle a form with mulitble input types and mulitble files to upload at one time
the package contain two classes "FileUpload" provides some info about the uploaded file and "MultiPartParser" the parser that do the upload
File Upload Class
package michael.web.upload;
* <p>Title: </p>
* <p>Description: </p>
* <p>Copyright: Copyright (c) 2005</p>
* <p>Company: </p>
* @author Michael Ageeb
* @version 1.0
public class FileUpload {
  public static final int SAVE_NAME = 0;
  public static final int PARAM_NAME = 1;
  public static final int FILE_NAME = 2;
  public static final int ERROR_FREE = 3;
  public static final int ERROR_IO = 4;
  public static final int ERROR_MAXSIZE = 5;
  private String fileName, savePath, paramName, saveName, MIMEType;
  private long size, maxSize;
  private int saveNameMethod, errorCode;
  private Throwable th;
  public FileUpload(String paramName, String savePath) {
    size = 0;
    maxSize = Long.MAX_VALUE;
    this.paramName = paramName;
    this.savePath = savePath;
    saveName = null;
    fileName = null;
    saveNameMethod = FILE_NAME;
    errorCode = ERROR_FREE;
    th = null;
    this.MIMEType = "text/plain";
  void setMIMEType(String mime) {
    this.MIMEType = mime;
  public String getMIMEType() {
    return this.MIMEType;
  void setThrowable(Throwable th) {
    this.th = th;
  public Throwable getThrowable() {
    return this.th;
  public void setSaveNameMethod(int sn) {
    if (sn < 0 || sn > 2)return;
    saveNameMethod = sn;
  public int getSaveNameMethod() {
    return this.saveNameMethod;
  void setErrorCode(int ec) {
    if (ec < 3 || ec > 5)return;
    this.errorCode = ec;
  public int getErrorCode() {
    return errorCode;
  public String getFileName() {
    return fileName;
  public long getMaxSize() {
    return maxSize;
  public void setMaxSize(long maxSize) {
    if (maxSize < 0)return;
    this.maxSize = maxSize;
  public long getSize() {
    return size;
  public void setSavePath(String savePath) {
    this.savePath = savePath;
  public String getSavePath() {
    return savePath;
  public String getSaveName() {
    switch (this.saveNameMethod) {
      case FILE_NAME:
        return this.fileName;
      case PARAM_NAME:
        return this.paramName;
      case SAVE_NAME:
        return this.saveName != null ? this.saveName : this.fileName;
    return null;
  public void setSaveName(String saveName) {
    this.saveName = saveName;
  public String getParamName() {
    return paramName;
  void setFileName(String fileName) {
    this.fileName = fileName;
  void setSize(long size){
    this.size=size;
}MultiPartParser Class
package michael.web.upload;
import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.util.*;
* <p>Title: </p>
* <p>Description: </p>
* <p>Copyright: Copyright (c) 2005</p>
* <p>Company: </p>
* @author Michael Ageeb
* @version 1.0
public class MultiPartParser {
  private Hashtable fields;
  private Hashtable files;
  private String defSavePath;
  private LinkedList parameters;
  public MultiPartParser(String savePath) {
    this.defSavePath = savePath;
    parameters = new LinkedList();
    fields = new Hashtable();
    files = new Hashtable();
  public void addFileUpload(FileUpload fu) {
    files.put(fu.getParamName(), fu);
  public FileUpload getFileUpload(String param) {
    return (FileUpload) files.get(param);
  public Enumeration getFilesNames() {
    return files.keys();
  public Enumeration getFieldsNames() {
    return fields.keys();
  public Enumeration getPatameterNames() {
    return Collections.enumeration(parameters);
  boolean addParameter(String param) {
    if (parameters.contains(param))return false;
    parameters.addLast(param);
    return true;
  public String getField(String param) {
    ArrayList arr = (ArrayList) fields.get(param);
    if (arr == null)return null;
    return (String) arr.get(0);
  public String[] getFieldValues(String param) {
    ArrayList arr = (ArrayList) fields.get(param);
    if (arr == null)return null;
    String a[] = new String[arr.size()];
    for (int i = 0; i < a.length; i++) a[i] = (String) arr.get(i);
    return a;
  private String getFilename(String s) {
    int pos = s.indexOf("filename=\"");
    String filepath = s.substring(pos + 10, s.length() - 1);
    // Windows browsers include the full path on the client
    // But Linux/Unix and Mac browsers only send the filename
    // test if this is from a Windows browser
    pos = filepath.lastIndexOf("\\");
    if (pos != -1)
      return filepath.substring(pos + 1);
    else
      return filepath;
  private String getContentType(String s) {
    int pos = s.indexOf(": ");
    return s.substring(pos + 2, s.length());
  public void parse(HttpServletRequest request) throws IOException {
    ServletInputStream in = request.getInputStream();
    byte[] line = new byte[128];
    int i = in.readLine(line, 0, 128);
    if (i < 3)
      return;
    int boundaryLength = i - 2;
    String boundary = new String(line, 0, boundaryLength); //-2 discards the newline character
    while (i != -1) {
      String newLine = new String(line, 0, i);
      if (newLine.startsWith("Content-Disposition: form-data; name=\"")) {
        if (newLine.indexOf("filename=\"") != -1) {
          int pos = newLine.indexOf("name=\"");
          String paramName = newLine.substring(pos + 6,
                                               newLine.indexOf("name=\"",
              pos + 6));
          FileUpload fu;
          if (files.contains(paramName)) fu = (FileUpload) files.get(paramName);
          else {
            fu = new FileUpload(paramName, defSavePath);
            files.put(paramName, fu);
          addParameter(paramName);
          fu.setFileName(getFilename(new String(line, 0, i - 2)));
          //this is the file content
          i = in.readLine(line, 0, 128);
          fu.setMIMEType(getContentType(new String(line, 0, i - 2)));
          i = in.readLine(line, 0, 128);
          // blank line
          i = in.readLine(line, 0, 128);
          newLine = new String(line, 0, i);
          ByteArrayOutputStream pw = new ByteArrayOutputStream();
          //          FileOutputStream pw=new FileOutputStream((fu.getSavePath() == null ? "" : fu.getSavePath()) +
          //                       fu.getSaveName());
          long count = 0;
          while (i != -1 && !newLine.startsWith(boundary) &&
                 count <= fu.getMaxSize()) {
            // the problem is the last line of the file content
            // contains the new line character.
            // So, we need to check if the current line is
            // the last line.
            i = in.readLine(line, 0, 128);
            if ( (i == boundaryLength + 2 || i == boundaryLength + 4) // + 4 is eof
                && (new String(line, 0, i).startsWith(boundary))) {
              pw.write(newLine.getBytes(), 0, newLine.length() - 2);
              count += newLine.length() - 2;
            else {
              pw.write(newLine.getBytes(), 0, newLine.length());
              count += newLine.length();
            newLine = new String(line, 0, i);
          pw.close();
          RandomAccessFile rf = new RandomAccessFile( (fu.getSavePath() == null ?
              "" : fu.getSavePath()) + fu.getSaveName(), "rw");
          byte[] bytes = pw.toByteArray();
          rf.write(bytes, 0, bytes.length);
          rf.close();
          if (count > fu.getMaxSize()) {
            File f = new File( (fu.getSavePath() == null ? "" : fu.getSavePath()) +
                              fu.getSaveName());
            f.delete();
            fu.setErrorCode(FileUpload.ERROR_MAXSIZE);
          else {
            fu.setSize(count);
        else {
          //this is a field
          // get the field name
          int pos = newLine.indexOf("name=\"");
          String fieldName = newLine.substring(pos + 6, newLine.length() - 3);
          //System.out.println("fieldName:" + fieldName);
          // blank line
          i = in.readLine(line, 0, 128);
          i = in.readLine(line, 0, 128);
          newLine = new String(line, 0, i);
          StringBuffer fieldValue = new StringBuffer(128);
          while (i != -1 && !newLine.startsWith(boundary)) {
            // The last line of the field
            // contains the new line character.
            // So, we need to check if the current line is
            // the last line.
            i = in.readLine(line, 0, 128);
            if ( (i == boundaryLength + 2 || i == boundaryLength + 4) // + 4 is eof
                && (new String(line, 0, i).startsWith(boundary)))
              fieldValue.append(newLine.substring(0, newLine.length() - 2));
            else
              fieldValue.append(newLine);
            newLine = new String(line, 0, i);
          //System.out.println("fieldValue:" + fieldValue.toString());
          if (addParameter(fieldName)) {
            ArrayList arr = new ArrayList();
            arr.add(fieldValue.toString());
            fields.put(fieldName, arr);
          else {
            ( (ArrayList) fields.get(fieldName)).add(fieldValue.toString());
      i = in.readLine(line, 0, 128);
    } // end while
}All what you want to do in ur jsp page and u will find the files in ur C:/
<%@ page import="michael.web.upload.*" %>
<%
MultiPartParser parser=new MultiPartParser("C:/");
parser.parse(request);
%>

Answer 1

Hellooooooooooo,
Could anybody post a code that is able to upload images. (i mean raw code without using fancy controlos)