Invalid identifier error in executing a ref cursr

Question

I am getting ORA00904: "MARKETING": invalid identifier ... and it's driving me crazy!!
here's my sql code...
StrTitle varchar2(500);
TYPE RefCurCusts IS REF CURSOR;
rec_ref_custs RefCurCusts;
strCusts varchar2(500);
StrTitle := 'MARKETING';
OPEN rec_ref_custs FOR
'Select distinct b.account_number, b.marketing_rep_name, c.customer_name, a.meter, a.mappole, a.feeder, b.last_or_corp_name, b.house_number, b.street_direction, b.street_name, b.street_suffix, max(odate) over (partition by b.account_number) last_called, n.message_type, c.list_name     
From srs.current_outage_calls o, tlm.customer_electric b, srs.notification_list n, SRS.NOTIFIABLE_CUSTOMERS_VW c, srs.est_customer_outages a
Where c.SERVICE_ADDR_NUMBER = b.SERVICE_ADDR_NUMBER And substr(b.meter_number, 2, 6) = a.meter and b.service_point_end_date is null and o.meter(+)=a.meter and n.list_name=c.list_name and c.list_name = '||StrTitle;
               LOOP
                    FETCH rec_ref_custs INTO strCusts;
                    EXIT WHEN rec_ref_custs%NOTFOUND;
                         StrBodyHTML:= StrBodyHTML || ', ' || strCusts;
               END LOOP;
CLOSE rec_ref_custs;     
please help!
Thanks

Answer 1

Fuse_5a wrote:
I am taking the value of StrTitle (I changed the name of it to strList in the below code) from a different select statement ... therefore, strList will be changing based on the results of the first query.
this code is for an automailer that will run every minute!!
here's more of my code to better explain it ...
Any suggestions?
OPEN rec_ref_list FOR
'Select
distinct c.list_name     
From
srs.current_outage_calls o,
tlm.customer_electric  b,
srs.notification_list n,
SRS.NOTIFIABLE_CUSTOMERS_VW c,
srs.est_customer_outages a
Where
c.SERVICE_ADDR_NUMBER = b.SERVICE_ADDR_NUMBER
And substr(b.meter_number, 2, 6) = a.meter
and b.service_point_end_date is null
and o.meter(+)=a.meter
and n.list_name=c.list_name';
LOOP
FETCH rec_ref_list INTO *strList*;
EXIT WHEN rec_ref_list%NOTFOUND;
     OPEN rec_ref_custs FOR
'Select
b.account_number,
b.marketing_rep_name,
c.customer_name, a.meter,
a.mappole, a.feeder,
b.last_or_corp_name,
b.house_number,
b.street_direction,
b.street_name,
b.street_suffix,
max(odate) over (partition by b.account_number) last_called,
n.message_type,
c.list_name     
From
srs.current_outage_calls o,
tlm.customer_electric  b,
srs.notification_list n,
SRS.NOTIFIABLE_CUSTOMERS_VW c,
srs.est_customer_outages a
Where
c.SERVICE_ADDR_NUMBER = b.SERVICE_ADDR_NUMBER
And substr(b.meter_number, 2, 6) = a.mete
and b.service_point_end_date is null
and o.meter(+)=a.meter
and n.list_name=c.list_name
and c.list_name = :1' using *strList*;
       LOOP
           FETCH rec_ref_custs INTO strCusts;
           EXIT WHEN rec_ref_custs%NOTFOUND;
               StrBodyHTML:= StrBodyHTML || ', ' || strList || ', ' || strCusts;
       END LOOP;
CLOSE rec_ref_custs;     
END LOOP;
CLOSE rec_ref_list;     
You have a variable, nothing more. You DO NOT need dynamic SQL here, just trust me (then go read about it and learn why ... it will serve your career well to do some reading).
You don't need 2 cursors here, for lack of not wanting to try to decipher this in it's entirety i took a simple hack and utilized an IN clause.
for loop_var in
   Select
      b.account_number,
      b.marketing_rep_name,
      c.customer_name, a.meter,
      a.mappole, a.feeder,
      b.last_or_corp_name,
      b.house_number,
       b.street_direction,
      b.street_name,
      b.street_suffix,
      max(odate) over (partition by b.account_number) last_called,
      n.message_type,
      c.list_name     
   From
      srs.current_outage_calls o,
      tlm.customer_electric  b,
      srs.notification_list n,
      SRS.NOTIFIABLE_CUSTOMERS_VW c,
      srs.est_customer_outages a
   Where
    c.SERVICE_ADDR_NUMBER = b.SERVICE_ADDR_NUMBER
   And substr(b.meter_number, 2, 6) = a.mete
   and b.service_point_end_date is null
   and o.meter(+)=a.meter
   and n.list_name=c.list_name
   and c.list_name in
      Select
         c.list_name     
      From
      srs.current_outage_calls o,
      tlm.customer_electric  b,
      srs.notification_list n,
      SRS.NOTIFIABLE_CUSTOMERS_VW c,
      srs.est_customer_outages a
      Where
      c.SERVICE_ADDR_NUMBER = b.SERVICE_ADDR_NUMBER
      And substr(b.meter_number, 2, 6) = a.meter
      and b.service_point_end_date is null
      and o.meter(+)=a.meter
      and n.list_name=c.list_name
LOOP
   StrBodyHTML:= StrBodyHTML || ', ' || loop_var.<pick_a_column_from_select_list_above>;
END LOOP;No ref cursors, less complex and 1 single SQL query ... much cleaner and efficient.