Issue with script while adding table MTL_SECONDARY_INVENTORIES

Question

Hi All,
I have a requirement to modify the existing query to fetch the segment3 of GL_CODE_COMBINATIONS table. I have to fetch it based on the Material_Account of MTL_SECONDARY_INVENTORIES.
The existing piece of code is as below:
SELECT line.inventory_item_id, line.order_quantity_uom line_uom,
line.line_number, line.fulfilled_quantity qty, line.line_id,
line.created_by, itm.segment1 || '.' || itm.segment2 item,
itm.primary_uom_code primary_uom, head.order_number, head.header_id,
head.attribute2 subinventory, line.actual_shipment_date date_shipped,
NVL (itm.serial_number_control_code, 1) serial_req,
NVL (itm.lot_control_code, 1) lot_req
FROM mtl_system_items itm,
oe_transaction_types_tl typ,
oe_order_headers_all head,
oe_order_lines_all line
WHERE itm.organization_id = v_org_id
AND itm.inventory_item_id = line.inventory_item_id
AND typ.NAME || '' IN ('ABC', 'DEF')
AND typ.transaction_type_id = head.order_type_id
AND head.header_id = line.header_id
The modified code is as below:
SELECT glcc.segment3 -- AB Changed
line.inventory_item_id, line.order_quantity_uom line_uom,
line.line_number, line.fulfilled_quantity qty, line.line_id,
line.created_by, itm.segment1 || '.' || itm.segment2 item,
itm.primary_uom_code primary_uom, head.order_number, head.header_id,
head.attribute2 subinventory, line.actual_shipment_date date_shipped,
NVL (itm.serial_number_control_code, 1) serial_req,
NVL (itm.lot_control_code, 1) lot_req
FROM mtl_system_items itm,
mtl_secondary_inventories msis, -- AB Changed
mtl_item_sub_inventories misi, -- AB Changed
gl_code_combinations glcc -- AB Changed
oe_transaction_types_tl typ,
oe_order_headers_all head,
oe_order_lines_all line
WHERE itm.organization_id = v_org_id
AND itm.inventory_item_id = line.inventory_item_id
AND typ.NAME || '' IN ('ABC', 'DEF')
AND typ.transaction_type_id = head.order_type_id
AND head.header_id = line.header_id
AND line.line_id = p_line_id;
AND glcc.code_combination_id = msis.material_account -- AB Changed
AND msis.secondary_inventory_name = misi.secondary_inventory -- AB Changed
AND msis.organization_id = misi.organization_id -- AB Changed
AND misi.inventory_item_id = itm.inventory_item_id -- AB Changed
AND misi.organization_id = itm.organization_id -- AB Changed
**NOTE:** I was told that, for a particular item, the total number of records BEFORE and AFTER change has to be the same.
So, can someone let me know, if the modification done is correct to meet the requirements? If not, could you please guide me in this regard?
Thanks very much in advance.
Regards,
AB

Answer 1

Your joins are correct but your number of records may not remain same if one item-org combination has more than 1 records in the mtl_item_sub_inventories table.
However, if your business rules may prevent someone from creating such records, then you are fine. Run the following to verify that
select count(1),organization_id,inventory_item_id From mtl_item_sub_inventories misi
group by organization_id,inventory_item_id having count(1) >1
Hope this answers your question,
Sandeep Gandhi