Logic dosen't work

Question

Hi,
I have a problem to change a user's password. Here is the condition. In my db it has a table called userpassword.
userpassword(empno,username,password,level)
At first time who wants to access this system must logs on to the system via submitting
username and password. The it displays the main form. My problem is, I wrote a .jsp page to update the password. But I want to mention here something. Only the user who logs into the system can change his/her password only, others can't do it.
Here is the form which I used to change the password,"changePasswordForm.html".
<form method="POST" action="changePassCtrl.jsp">
<p> </p>
<p> </p>
  <div align="center">
    <center>
    <table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse"
bordercolor="#C0C0C0" width="47%" id="AutoNumber1" height="189">
      <tr>
        <td width="100%" colspan="2" bgcolor="#0000FF" bordercolor="#FFFFFF" height="19">
        <font color="#FFFFFF"><b>Change Password</b></font></td>
      </tr>
      <tr>
        <td width="50%" bordercolor="#FFF3C6" height="23"
bgcolor="#FFF3C6"><b>Username</b></td>
        <td width="50%" bordercolor="#FFF3C6" height="23" bgcolor="#FFF3C6">
        <input type="text" name="username" size="15" style="border: 1px solid
#0000FF"></td>
      </tr>
      <tr>
        <td width="50%" bordercolor="#FFF3C6" height="20" bgcolor="#FFF3C6"><b>
        Enter old password</b></td>
        <td width="50%" bordercolor="#FFF3C6" height="20" bgcolor="#FFF3C6">
        <input type="text" name="oldPass" size="15" style="border: 1px solid
#0000FF"></td>
      </tr>
      <tr>
        <td width="50%" bordercolor="#FFF3C6" height="20" bgcolor="#FFF3C6"><b>Enter new
password</b></td>
        <td width="50%" bordercolor="#FFF3C6" height="20" bgcolor="#FFF3C6">
        <input type="password" name="newPass" size="15" style="border: 1px solid
#0000FF"></td>
      </tr>
      <tr>
        <td width="100%" align="center" bordercolor="#FFF3C6" height="26" colspan="2"
bgcolor="#FFF3C6">
        <input type="submit" value="SUBMIT" name="B3" style="border:1px solid #0000FF;
font-weight: bold"></td>
      </tr>
      <tr>
        <td width="50%" bordercolor="#FFFFFF" height="3"></td>
        <td width="50%" bordercolor="#FFFFFF" height="3"></td>
      </tr>
    </table>
    </center>
  </div>
</form>here is the file "changePassCtrl.jsp"
<%@ page language="java" import="java.util.*"%>
<%@ page import="hrm.UserAccManager" %>
<%@ page session="true" %>
<%@ page import="java.sql.*,javax.servlet.http.*" %>
<jsp:useBean id="useraccount" class="hrm.UserAccManager" scope="request"/>
<% hrm.UserAccManager user =
(hrm.UserAccManager)request.getSession().getAttribute("useraccount");%>
<%
     final String DRIVER = "com.mysql.jdbc.Driver";
       final String DBURL  = "jdbc:mysql://localhost:3306/superfine";
        // Load the driver class and establish a connection
     Class.forName(DRIVER);
        Connection connection = DriverManager.getConnection(DBURL);
        PreparedStatement pstmt =null;     
     String value1 = user.getUsername();
     String value2 = user.getPassword();
     String nextPage ="MainForm.jsp";
     String uName = request.getParameter("username");
     String uPass1 = request.getParameter("oldPass");
     String uPass2 = request.getParameter("newPass");
     if((value1==uName)&& (value2==uPass1)){
          //Prepare a statement that will handle the update
          String sql ="UPDATE UserPassword SET password= + uPass2 + ";
         pstmt = connection.prepareStatement(sql);          
          //assign value for ???
               pstmt.setString(1, uPass2);          
               pstmt = connection.prepareStatement(sql);
               pstmt.executeUpdate();
               //Close any open JDBC objects
               if(pstmt != null) pstmt.close();
               if(connection != null) connection.close();
     %>
          <jsp:forward page="MainForm.jsp"/>
     <%
     else{
     %>
          <jsp:forward page="InvalidUNamePass.html"/>
     <%
%>In this file ther is some logic behind it. If the user enters the correct username and
password, then it must update the db and finnaly should display the "MainForm.jsp".
Otherwise if username and password invalid, then it should displays
"InvalidUNamePass.html". But my problem is, when I enter a invalid username and password
it displays "InvalidUNamePass.html", but it also display the "InvalidUNamePass.html" for
valid username and password also. Why is it?
Please can somebody help me. Thanks.

Answer 1

You cannot compare strings with "==" operator. Use String equals method to compare the strings. That is why it is going to the error page.
if((value1==uName)&& (value2==uPass1)){
Replace with
if (value1.equals(uName) ---- Like this.
Thanks