Menu Bar AppleScripts do not work

Question

I just tried to use the Finder script, Add to File Names, to add a prefix string to a group of files.
What I got was the string "Prefix" added to the end of the file name, after the siffix, thus changing the file type to an unrecognized string.

Answer 1

OK, this is very weird.
This is a script that came from Apple that has worked for many years --
Add to File Names
This script is designed to add a prefix or suffix to files in the front window of the desktop.
If no folder windows are open, the script will affect items on the desktop.
Copyright © 2001–2007 Apple Inc.
So I start picking it apart and I quickly found the problem:
repeat
          display dialog "Enter the prefix or suffix to use:" default answer the prefix_or_suffix buttons {"Cancel", "Prefix", "Suffix"}
          copy the result as list to {the prefix_or_suffix, the button_pressed}
          if the prefix_or_suffix is not "" then exit repeat
end repeat
I added a line after:
display dialog "The button pressed was " & button_pressed & " and the prefix/suffix was " & prefix_or_suffix
And it tells me :
The button pressed was prefix_string_entered and the prefix/suffix was Prefix
So I reverse the order to
          copy the result as list to {the button_pressed, the prefix_or_suffix}
and now it works as before.
Why did this stop working ?