Mplayer - GTK2

Question

There's a patch which makes Gmplayer use gtk2.
It's really good - stable, even supports the new file selector.
I suggest to include it in official arch mplayer package.
Here's my PKGBUILD:
# $Id: PKGBUILD,v 1.50 2004/07/23 20:18:11 judd Exp $
# Maintainer: dorphell <[email protected]>
# (gtk2 support added by rehcra)
pkgname=mplayer
pkgver=1.0pre5
pkgrel=5rehcra
pkgdesc="A movie player for linux"
depends=('libmad' 'libungif' 'gtk2' 'libvorbis'
'libjpeg' 'libpng' 'libtheora')
url="http://www.mplayerhq.hu/"
source=(ftp://ftp.mplayerhq.hu/MPlayer/releases/MPlayer-$pkgver.tar.bz2 http://www.win.net/~ardneh/patches/mplayer1.0pre5-gtk2-20040730.patch.bz2 ftp://ftp.mplayerhq.hu/MPlayer/releases/fonts/font-arial-iso-8859-1.tar.bz2 ftp://ftp.mplayerhq.hu/MPlayer/Skin/Blue-1.4.tar.bz2)
build() {
cd $startdir/src/MPlayer-$pkgver
patch -p1 < ../mplayer1.0pre5-gtk2-20040730.patch
## needed because of stupid coreutils messup
sed -i 's/(head|tail) -1/1 -n 1/' configure
./configure --prefix=/usr --enable-gui --enable-linux-devfs --disable-arts
--disable-external-faad --enable-runtime-cpudetection --disable-smb
--enable-x11 --enable-theora --confdir=/etc/mplayer
make || return 1
make DESTDIR=$startdir/pkg install
mkdir -p $startdir/pkg/usr/share/mplayer/Skin
cp etc/{codecs.conf,input.conf,example.conf} $startdir/pkg/usr/share/mplayer
rm -rf $startdir/pkg/usr/share/mplayer/font $startdir/pkg/usr/etc
mv $startdir/src/font-arial-iso-8859-1/font-arial-{14,18,24,28}-iso-8859-1 $startdir/pkg/usr/share/mplayer/
cd $startdir/pkg/usr/share/mplayer
ln -s font-arial-24-iso-8859-1 font
mv $startdir/src/Blue $startdir/pkg/usr/share/mplayer/Skin/default
(sorry above has some dependencies stripped; i don't like windows codecs and such)

Answer 1

contrasutra wrote:We were all fed up by the hacky patching Debian, Gentoo, et al do.
mplayer-gtk2 patch doesn't look like a hack... Good patches should be included even though devs doesn't want to include them in vanilla sources (eg. Xmms devs don't want to move to gtk2 only because they think it would add bloat to xmms. Hardly anybody agrees with them)
We just want the vanilla source, in its compatible glory.
Mplayer-gtk2 is just as compatible as Mplayer-gtk1 is. This patch is a cosmetic change.
Take into account that kernel development model changed recently. Kernel developers put the responsibility of patching the kernel on distribution maintainers. So if we don't patch the kernel, Arch will be very unstable.
I don't want my mplayer patched.
You can always recompile it with ABS yourself
Arch is about simplicity, and when you patch everything, you lose that.
Is it simplicity to compile mplayer with obsolete gtk frontend?
But I (a) don't use the kernel package, (...)
There are people who use it. And don't say it's not a big deal - mplayer with gtk2 is even smaller deal.
EDIT: GTK1 is still used by MANY packages. It is not obsolete. The Arch philosophy also seems to be "don't mess with working things". If the package is unmaintained, it's actually LESS work for the devs .
Which packages need gtk1 that don't have gtk2 equivalent? Note gmplayer's gtk support is optional.
Original developers of gtk don't support it anymore so it's obsolete.
Unmaintained packages are bad, because free software environment is ever-changing and everything looses compatibility.
Actually it's not my intention to patch Arch's current version of mplayer. All I'm asking is to split mplayer into two packages: mplayer and gmplayer.