Multiple count query

Question

I'm trying to write a function to compare two different counts.
I have patient on multiple drugs...some drugs are allergy drugs and at least one allergy drug must be marked as primary.
select count(drug_role) as vAllergyCount, count(primary_flag) as PF, ap.patient_id
from ae_all_drugs aed, ae_patient ap
where drug_role = 'Allergy'
and aed.patient_id = ap.patient_id
and ap.patient_id like '2012%'
group by ap.patient_id,primary_flag
order by ap.patient_id
when grouped by patient id and primary flag I would receive a record like this:
VAlllergyCount | PF | patient_id
1 | 0 | 2012AB1
3 | 1 | 2012AB1
If i only group by patient_id I get this (which is what I want):
VAlllergyCount | PF| patient_id
4 | 1 | 2012AB1
But if I try to compare the two:
IF vAllergyCount > 1 and PF = 1 THEN 'SUCCESS' ELSIF 'FAIL'
I receive the error message "exact fetch returns more than requested number of rows" becuase the results are really my first query.
Can anyone help me re-write my query to compare the values?
P.S. I'm very new to this and this forum and I apologize for not inserting code tags. I don't know how.

Answer 1

Hi,
979105 wrote:
Thank you for your hlep.
I need to write a function because the SQL query is going to be used as an edit check for another program. So yes, it will have to worth my time.
You are correct. I have a patient on multiple drugs. I want to know if there is at least one allergy drug (drug_role) > 1 if there is at least ONE primary allergy drug.
I did initially write my function with the patient_id as an input value. Why would I not need the vAllergyCount or the pf if that is an argument?If all you want to know is 'SUCCESS' or 'FAIL', then write a query that produces 'SUCCESS' or 'FAIL'. Inside the query, it may be handy to have something like vAllergyCount or pf, but that doesn't mean that they will be returned by the query, or that you need PL/SQL variables for them.
Here's my original function:That's a PROCEDURE, not a function. Sometimes, people use the word "procedure" lossely, to mean any kind of stored code, including functions, but never the other way around.
\Don't forget to put another \ tag at the end of the formatted section.
\ tags are supposed to occur in pairs. If you have an odd number of \ tags, the last one has no effect, and is displayed as regular text.
PROCEDURE COUNT_ALLERGY_MED (
     ivPatient_ID IN VARCHAR2,
     ovErrorText          OUT     VARCHAR2 )
IS
     vCase_ID          VARCHAR2 (25);
     vSusCount           NUMBER (3);
     vSuspectMed          VARCHAR2 (1);
     --vPrimaryFlag     VARCHAR2(1);
cursor c1 is
     select count(*) as vSusCount
     from ae_suspect_drugs aed
     where drug_role = 'S'
     and aed.case_id = ivCase_ID
     --group by ivcase_id;
BEGIN
open c1;
fetch c1 into vSusCount;
close c1;
IF vSusCount < 1 /*AND vPrimaryFlag IS NULL*/ THEN
     ovErrorText := 'Suspect Drug Count is less than 1' || 'SusCount: ' || vSusCount;
     ELSIF vSusCount = 1 /*AND vPrimaryFlag IS NULL*/ THEN
     ovErrorText := 'Suspect Drug count is equal to 1' || 'SusCount: ' || vSusCount;
     ELSIF vSusCount > 1 /*AND vPrimaryFlag IS NULL*/ THEN
     ovErrorText := 'Suspect Drug count is greater than 1 ' || 'SusCount: ' || vSusCount;
     ELSE
     ovErrorText := 'All criteria met';
END IF;
END COUNT_SUSPECT_MED;It seems like it would be more convenient to have a FUNCTION, rather than a PROCEDURE; that way you could call the function directly in a SQL statement (e.g., in the WHERE clause of a query or DML statement) as well as in PL/SQL.
The procedure you posted seems to be quite a bit differetn from the problem you asked eariler.
Here's one way you might write a fucntion for the earlier problem:CREATE OR REPLACE FUNCTION count_allergy_med
( ivPatient_ID IN VARCHAR2
RETURN VARCHAR2
IS
return_str VARCHAR2 (50);          -- To be returned
BEGIN
SELECT CASE
     WHEN COUNT (drug_role) > 1
          AND COUNT (primary_flag) = 1
          THEN 'SUCCESS'
          ELSE 'FAIL'
     END     
INTO return_str
FROM ae_all_drugs     aed
,      ae_patient           ap
WHERE drug_role          = 'Allergy'
AND     aed.patient_id      = ap.patient_id
AND     ap.patient_id     = ivPatient_ID;
RETURN return_str;
END count_allergy_med;
Notice that there are no columns in the result set, nor variables in the function, that correspond to vAllergyCount or pf.
The function above returns 1 of 2 possible values.  You couold just as well write a function that had 4 possible outcomes, or 4 basic results, each containing a variable number, such asSuspect Drug Count is less than 1. SusCount: 0
I'm not sure why you would want such as result, since 0 is the only possible count that is less than 1, but it's easy enough to produce results like that if you really want them.
Once again, if you'd like help, post a clear example of what you want.  Include CREATE TABLE and INSERT statements for some sample data.  Post some code where you might use the function that you're thinking of.  Give a couple of different arguments for that functuion, and the results you would want for each argument given the same sample data.