Need help in archiveing and deleting records

Question

Hi frnds
I wrote a procedure to archive the records and delete the archived one but after inserting and deleting the tot counter is not working and its showing 1 record inserted and i didnt tried the deletion part,pls find my code and how to get the correct no of records inserted as out put and same for deletion.One more thing,before deletion i want to confirm all the records which i going to delete is already inserted eg,if i could'nt able to do insert the specific no of rows the program shud exit without doing the deletion,How to accomplish that
Declare
cnt NUMBER := 0;
tot number :=0;
CURSOR ins IS
select count(*) from Cal_log
where trunc(c_date) ='11-Aug-2008';
BEGIN
FOR rec IN ins LOOP
insert into Calls_arc
select * from Cal_log
where trunc(c_date) ='11-Aug-2008';
tot :=tot + 1
cnt := cnt + 1;
IF (cnt >= 100) THEN
COMMIT;
cnt := 0;
END IF;
END LOOP;
DBMS_OUTPUT.PUT_LINE('inserted ' || tot|| ' records in call_arch.');
FOR rec IN ins LOOP
delete from Cal_log
where trunc(c_date) ='11-Aug-2008';
tot := tot + 1;
cnt := cnt + 1;
IF (cnt >= 100) THEN
COMMIT;
cnt := 0;
END IF;
COMMIT;
DBMS_OUTPUT.PUT_LINE('Deleted ' || tot || ' records from Cal_log');
END;

Answer 1

Since
CURSOR ins IS
select count(*) from Cal_log
where trunc(c_date) ='11-Aug-2008';always returns one row, your loop
FOR rec IN ins LOOPdoes not make much sense. But it does not hurt. The real issue with your code is you increment tot by one while insert processes more than one row (all rows for Aug 11). You should use %ROWCOUNT. And one more thing, never rely on implicit date conversions since default date format is client session sependent. Anyway, all you need is:
BEGIN
    insert
      into Calls_arc
      select  count(*)
        from  Cal_log
        where c_date >= to_date('11-Aug-2008','dd-mon-yyyy')
          and c_date <  to_date('12-Aug-2008','dd-mon-yyyy');
    DBMS_OUTPUT.PUT_LINE('inserted ' || SQL%ROWCOUNT || ' records in call_arch.');
    delete
      from Cal_log
      where c_date >= to_date('11-Aug-2008','dd-mon-yyyy')
        and c_date <  to_date('12-Aug-2008','dd-mon-yyyy');
    COMMIT;
    DBMS_OUTPUT.PUT_LINE('Deleted ' || SQL%ROWCOUNT || ' records from Cal_log');
END;
/SY.