Need help in procedure

Question

Hi Experts,
I have wrote a procedure which is being fired by a trigger and update or insert the Attendance_day table on the basis of punch string, the below issue is coming when employee do two regular shift.
[code]
select * from ATTENDANCEMASTER where DATE_PUNCH>='01-aug-2013' and EMP_CD in('E03497');
SNO
EMP_CD
DATE_PUNCH
TIME_PUNCH
PREFIX
INOUT
8027551423
E03497   
1-Aug-13
8:53
200
I
8027890076
E03497   
1-Aug-13
19:01
200
O
8027980116
E03497   
2-Aug-13
8:56
200
I
8028070441
E03497   
2-Aug-13
17:43
200
O
8028071247
E03497   
3-Aug-13
8:49
200
I
8028160480
E03497   
3-Aug-13
17:43
200
O
8028160680
E03497   
3-Aug-13
22:51
200
I
8028161035
E03497   
4-Aug-13
6:54
200
O
8028661326
E03497   
6-Aug-13
8:51
200
I
8028840273
E03497   
6-Aug-13
18:55
200
O
8028841247
E03497   
7-Aug-13
8:56
200
I
This table is being updated after employees swipe the card. If u look @ the record of 3rd aug the employee has done two shift 1st in 1st shift(9-6pm) and another on 3rd shift (11pm-to next day of 7am). After this table the main attendnace_day table is being updated
SELECT * FROM ATTENDANCE_DAY WHERE EMP_CODE IN('E03497') AND ATTD_DATE >='01/AUG/2013';
attd_date
emp_code
in_time
out_time
status
shift
day_no
chg_date
chg_user
chg_term
result
punch_str
1-Aug-13
E03497   
8:53
19:01
(null)
G0013
5
1-Aug-13
STAR     
PAPNABMS      
-08:53 , -19:01
2-Aug-13
E03497   
8:56
17:43
(null)
G0013
6
2-Aug-13
STAR     
PAPNABMS      
-08:56 , -17:43
3-Aug-13
E03497   
8:49
17:43
(null)
G0013
7
4-Aug-13
PRITESH  
21PAPNADIXIT  
-08:49 , -17:43 , -22:51,*-17:43
6-Aug-13
E03497   
8:51
18:55
(null)
G0013
3
6-Aug-13
STAR     
PAPNABMS      
-08:51 , -18:55
7-Aug-13
E03497   
8:56
G0013
4
7-Aug-13
STAR     
PAPNABMS      
0
The out time in aug 3rd record is 17:43 but as employee has done two shifts the out time must be:
8028161035
E03497   
4-Aug-13
6:54
200
O
That's why I need to change the procedure in way that it should update the attendance_day table on the basis of IN OUT flag and must capture these types of records properly.
The Procedure is mentioned below:
[code]
CREATE OR REPLACE
PROCEDURE UPDATE_ATTENDANCE
    AS_EMP_CODE   CHAR,
    AS_DATE_PUNCH DATE,
    AS_TIME_PUNCH CHAR
AS
BEGIN
  DECLARE
    a_time_punch workshft.in_time%type := AS_TIME_PUNCH;
    a_work_shift employee.work_shift%type;
    a_shift_intime workshft.in_time%type;
    a_lunch_time workshft.lunch_time%type;
    a_hol_tblno holiday.hol_tblno%type;
    a_fin_entity site.fin_entity%type;
    a_prv_date DATE := AS_DATE_PUNCH - 1;
    a_count    NUMBER(5);
    a_count1   NUMBER(5);
    CURSOR c1
    IS
      SELECT work_shift
      FROM
        (SELECT tran_date eff_date,
          work_shift_o work_shift,
          conf_date,
          chg_date
        FROM employee_det_change
        WHERE emp_code = AS_EMP_CODE
        AND tran_date  > AS_DATE_PUNCH
        AND status     = 'C'
      UNION ALL
      SELECT eff_Date,
        work_shift__fr work_shift,
        conf_date,
        chg_date
      FROM emp_employ_events
      WHERE emp_code = AS_EMP_CODE
      AND eff_date   > AS_DATE_PUNCH
      AND confirmed  = 'Y'
      ORDER BY eff_date,
        conf_date,
        chg_date;
    BEGIN
      SELECT b.fin_entity
      INTO a_fin_entity
      FROM employee a,
        site b
      WHERE a.emp_code = AS_EMP_CODE
      AND b.site_code  = a.work_site;
      SELECT COUNT(*)
      INTO a_count
      FROM work_shift
      WHERE emp_code = AS_EMP_CODE
      AND AS_DATE_PUNCH BETWEEN from_dt AND to_dt;
      IF (a_count > 0) THEN
        SELECT shift
        INTO a_work_shift
        FROM work_shift
        WHERE emp_code = AS_EMP_CODE
        AND AS_DATE_PUNCH BETWEEN from_dt AND to_dt;
      ELSE
        FOR i IN c1
        LOOP
          a_work_shift := i.work_shift;
          EXIT;
        END LOOP;
        IF (a_work_shift IS NULL) THEN
          SELECT work_shift
          INTO a_work_shift
          FROM employee
          WHERE emp_code = AS_EMP_CODE;
        END IF;
      END IF;
      SELECT in_time,
        lunch_time
      INTO a_shift_intime,
        a_lunch_time
      FROM workshft
      WHERE shift = a_work_shift
      AND day_no  = TO_CHAR(AS_DATE_PUNCH,'D');
      SELECT COUNT(*)
      INTO a_count
      FROM attendance_day
      WHERE attd_date = AS_DATE_PUNCH
      AND emp_code    = AS_EMP_CODE;
      IF (a_count     > 0) THEN
        IF (A_FIN_ENTITY IN ('IC','HU')) THEN
          ------UPDATE HERE-----
          UPDATE attendance_day
          SET out_time = a_time_punch,
            punch_str  = punch_str || ' , -' || AS_TIME_PUNCH,
            work_hour     = (ddf_time_in_mm(a_time_punch)-ddf_time_in_mm(in_time))
          WHERE attd_date = AS_DATE_PUNCH
          AND emp_code    = AS_EMP_CODE;
        ELSE
          IF (ddf_time_in_mm(a_time_punch) < (ddf_time_in_mm(a_shift_intime) + 30)) THEN
            UPDATE attendance_day
            SET PUNCH_STR = PUNCH_STR || ' , -' || AS_TIME_PUNCH
            WHERE attd_date = AS_DATE_PUNCH
            AND emp_code    = AS_EMP_CODE;
          ELSE
            ------UPDATE HERE-----
            UPDATE attendance_day
            SET out_time = a_time_punch,
              punch_str  = punch_str || ' , -' || AS_TIME_PUNCH,
              work_hour     = (ddf_time_in_mm(a_time_punch)-ddf_time_in_mm(in_time))
            WHERE attd_date = AS_DATE_PUNCH
            AND emp_code    = AS_EMP_CODE;
          END IF;
        END IF;
      ELSE
        SELECT COUNT(*)
        INTO a_count1
        FROM work_shift
        WHERE emp_code = AS_EMP_CODE
        AND a_prv_date BETWEEN from_dt AND to_dt
        AND shift =
          (SELECT shift
          FROM workshft
          WHERE shift   = work_shift.shift
          AND day_no    = TO_CHAR(a_prv_date,'D')
          AND (out_time > '24:00'
          OR out_time   < in_time)
        SELECT ddf_get_holtblno(AS_EMP_CODE,AS_DATE_PUNCH) INTO a_hol_tblno FROM dual;
        SELECT COUNT(*)
        INTO a_count
        FROM holiday
        WHERE hol_tblno = a_hol_tblno
        AND hol_date = AS_DATE_PUNCH;
        IF ((A_COUNT1 > 0) OR (DDF_TIME_IN_MM(A_TIME_PUNCH) < (DDF_TIME_IN_MM(A_SHIFT_INTIME) - 120)) OR (A_COUNT > 0)) THEN
          IF (a_fin_entity IN ('IC','HU') AND a_count1 > 0) THEN
            SELECT COUNT(*)
            INTO a_count
            FROM attendance_day a,
              workshft b
            WHERE a.attd_date = a_prv_date
            AND a.emp_code = AS_EMP_CODE
            AND b.shift = a.shift
            AND b.day_no = a.day_no
            AND (ddf_time_in_mm(a_time_punch)+1440) <= (ddf_time_in_mm(b.out_time) + (
              CASE
                WHEN b.out_time < b.in_time
                THEN 1440
                ELSE 0
              END) + 300);
          ELSE
            SELECT COUNT(*)
            INTO a_count
            FROM attendance_day
            WHERE attd_date = a_prv_date
            AND emp_code    = AS_EMP_CODE
            AND out_time   IS NULL;
          END IF;
          IF (a_count     > 0) THEN
            A_TIME_PUNCH := TO_CHAR((TO_NUMBER(SUBSTR(A_TIME_PUNCH,1,2))+24)) || ':' || SUBSTR(A_TIME_PUNCH,4,2);
            ------UPDATE HERE-----
            UPDATE attendance_day
            SET out_time = a_time_punch,
              punch_str  = punch_str
              || ' , -'
              || a_time_punch,
              work_hour     = (ddf_time_in_mm(a_time_punch)-ddf_time_in_mm(in_time))
            WHERE attd_date = a_prv_date
            AND emp_code    = AS_EMP_CODE;
          ELSE
            ------UPDATE HERE-----
            INSERT
            INTO attendance_day
                attd_date,
                emp_code,
                in_time,
                shift,
                day_no,
                chg_date,
                chg_user,
                chg_term,
                punch_str,
                lunch_time
              VALUES
                AS_DATE_PUNCH,
                AS_EMP_CODE,
                a_time_punch,
                a_work_shift,
                TO_CHAR(AS_DATE_PUNCH,'D'),
                sysdate,
                USER,
                userenv('terminal'),
                || AS_TIME_PUNCH,
                a_lunch_time
          END IF;
        ELSE
          INSERT
          INTO attendance_day
              attd_date,
              emp_code,
              in_time,
              shift,
              day_no,
              chg_date,
              chg_user,
              chg_term,
              punch_str,
              lunch_time
            VALUES
              AS_DATE_PUNCH,
              AS_EMP_CODE,
              a_time_punch,
              a_work_shift,
              TO_CHAR(AS_DATE_PUNCH,'D'),
              sysdate,
              USER,
              userenv('terminal'),
              '-' || AS_TIME_PUNCH,
              a_lunch_time
        END IF;
      END IF;
    END;
  END;
[code]
Thnx in advance, help will be appreciated..

Answer 1

Sorry, totally lost in procedural logic (maybe others could see some ways of improvement)
PROCEDURE UPDATE_ATTENDANCE
    AS_EMP_CODE   CHAR,
    AS_DATE_PUNCH DATE,
    AS_TIME_PUNCH CHAR
AS
BEGIN
DECLARE
    a_time_punch workshft.in_time%TYPE := AS_TIME_PUNCH;
    a_work_shift employee.work_shift%TYPE;
    a_shift_intime workshft.in_time%TYPE;
    a_lunch_time workshft.lunch_time%TYPE;
    a_hol_tblno holiday.hol_tblno%TYPE;
    a_fin_entity site.fin_entity%TYPE;
    a_prv_date DATE := AS_DATE_PUNCH - 1;
    a_count    NUMBER(5);
    a_count1   NUMBER(5);
-------------------------------changes 13082013 starts-------------------
    a_count11 workshft.in_time%TYPE;
    a_count22 workshft.in_time%TYPE;
-------------------------------changes 13082013 ends-------------------
CURSOR c1 IS
      SELECT work_shift
        FROM(SELECT tran_date eff_date,work_shift_o work_shift,conf_date,chg_date
               FROM employee_det_change
              WHERE emp_code = AS_EMP_CODE
                AND tran_date > AS_DATE_PUNCH
                AND status = 'C'
             UNION ALL
             SELECT eff_date,work_shift__fr work_shift,conf_date,chg_date
               FROM emp_employ_events
              WHERE emp_code = AS_EMP_CODE
                AND eff_date > AS_DATE_PUNCH
                AND confirmed = 'Y'
       ORDER BY eff_date,conf_date,chg_date;
BEGIN
      SELECT b.fin_entity
        INTO a_fin_entity
        FROM employee a,
             site b
       WHERE a.emp_code = AS_EMP_CODE
         AND b.site_code = a.work_site;
      SELECT COUNT(*)
        INTO a_count
        FROM work_shift
       WHERE emp_code = AS_EMP_CODE
         AND AS_DATE_PUNCH BETWEEN from_dt AND to_dt;
      IF (a_count > 0) THEN
          SELECT shift
            INTO a_work_shift
            FROM work_shift
           WHERE emp_code = AS_EMP_CODE
             AND AS_DATE_PUNCH BETWEEN from_dt AND to_dt;
      ELSE
          FOR i IN c1
          LOOP
            a_work_shift := i.work_shift;
            EXIT;
          END LOOP;
          IF (a_work_shift IS NULL) THEN
            SELECT work_shift
              INTO a_work_shift
              FROM employee
             WHERE emp_code = as_emp_code;
          END IF;
      END IF;
      SELECT in_time,lunch_time
        INTO a_shift_intime,a_lunch_time
        FROM workshft
       WHERE shift = a_work_shift
         AND day_no = TO_CHAR(AS_DATE_PUNCH,'D');
      SELECT COUNT(*)
        INTO a_count
        FROM attendance_day
       WHERE attd_date = AS_DATE_PUNCH
         AND emp_code = AS_EMP_CODE;
      IF (a_count > 0) THEN
        IF (a_fin_entity IN ('IC','HU')) THEN
          UPDATE attendance_day
             SET out_time = a_time_punch,
                 punch_str = punch_str || ' , -' || as_time_punch,
                 work_hour = (ddf_time_in_mm(a_time_punch) - ddf_time_in_mm(in_time))
           WHERE attd_date = AS_DATE_PUNCH
             AND emp_code = AS_EMP_CODE;
        ELSE
          IF (ddf_time_in_mm(a_time_punch) < (ddf_time_in_mm(a_shift_intime) + 30)) THEN
            UPDATE attendance_day
               SET punch_str = punch_str || ' , -' || as_time_punch
             WHERE attd_date = AS_DATE_PUNCH
               AND emp_code = AS_EMP_CODE;
          ELSE
            UPDATE attendance_day
               SET out_time = a_time_punch,
                   punch_str = punch_str || ' , -' || as_time_punch,
                   work_hour = (ddf_time_in_mm(a_time_punch) - ddf_time_in_mm(in_time))
             WHERE attd_date = AS_DATE_PUNCH
               AND emp_code = AS_EMP_CODE;
          END IF;
        END IF;
      ELSE
        SELECT COUNT(*)
          INTO a_count1
          FROM work_shift
         WHERE emp_code = AS_EMP_CODE
           AND a_prv_date BETWEEN from_dt AND to_dt
           AND shift = (SELECT shift
                          FROM workshft
                         WHERE shift = work_shift.shift
                           AND day_no = TO_CHAR(a_prv_date,'D')
                           AND (out_time > '24:00' OR out_time < in_time)
        SELECT ddf_get_holtblno(as_emp_code,as_date_punch)
          INTO a_hol_tblno
          FROM dual;
        SELECT COUNT(*)
          INTO a_count
          FROM holiday
         WHERE hol_tblno = a_hol_tblno
           AND hol_date = AS_DATE_PUNCH;
        IF ((a_count1> 0) OR (ddf_time_in_mm(a_time_punch) < (ddf_time_in_mm(a_shift_intime) - 120)) OR (a_count > 0)) THEN
          IF (a_fin_entity IN ('IC','HU') AND a_count1 > 0) THEN
            SELECT COUNT(*)
              INTO a_count
              FROM attendance_day a,
                   workshft b
             WHERE a.attd_date = a_prv_date
               AND a.emp_code= AS_EMP_CODE
               AND b.shift = a.shift
               AND b.day_no= a.day_no
               AND ddf_time_in_mm(a_time_punch)+1440 <= ddf_time_in_mm(b.out_time) + CASE WHEN b.out_time < b.in_time THEN 1440 ELSE 0 END + 300;
          ELSE
            SELECT COUNT(*)
              INTO a_count
              FROM attendance_day
             WHERE attd_date = a_prv_date
               AND emp_code = AS_EMP_CODE
               AND out_time IS NULL;
          END IF;
-------------------------------changes 13082013 starts-------------------
          SELECT MAX(TIME_PUNCH)
            INTO A_COUNT11
            FROM ATTENDANCEMASTER
           WHERE DATE_PUNCH = A_PRV_DATE
             AND EMP_CD = AS_EMP_CODE
             AND INOUT='I';
          SELECT OUT_TIME
            INTO A_COUNT22
            FROM ATTENDANCE_DAY
           WHERE EMP_CODE = AS_EMP_CODE
             AND ATTD_DATE = a_prv_date;
          DBMS_OUTPUT.PUT_LINE('value of In TIme : ' ||TO_CHAR(A_COUNT22)|| ' , Out Time : '|| TO_CHAR(A_COUNT11));
          IF (A_COUNT11 > A_COUNT22) THEN
            a_count:=1;
          ELSE
            a_count:=0;
          END IF;
-------------------------------changes 13082013 ends-------------------
          IF (a_count > 0) THEN
            A_TIME_PUNCH := TO_CHAR((TO_NUMBER(SUBSTR(A_TIME_PUNCH,1,2))+24)) || ':' || SUBSTR(A_TIME_PUNCH,4,2);
            UPDATE attendance_day
               SET out_time = a_time_punch,
                   punch_str = punch_str || ' , -' || a_time_punch,
                   work_hour = (ddf_time_in_mm(a_time_punch) - ddf_time_in_mm(in_time))
             WHERE attd_date = a_prv_date
               AND emp_code = AS_EMP_CODE;
          ELSE
            INSERT INTO attendance_day(attd_date,emp_code,in_time,shift,day_no,chg_date,chg_user,chg_term,punch_str,lunch_time)
            VALUES (AS_DATE_PUNCH,AS_EMP_CODE,a_time_punch,a_work_shift,TO_CHAR(AS_DATE_PUNCH,'D'),SYSDATE,USER,USERENV('terminal'),'-'|| AS_TIME_PUNCH,a_lunch_time);
            END IF;
        ELSE
          INSERT INTO attendance_day(attd_date,emp_code,in_time,shift,day_no,chg_date,chg_user,chg_term,punch_str,lunch_time)
          VALUES (AS_DATE_PUNCH,AS_EMP_CODE,a_time_punch,a_work_shift,TO_CHAR(AS_DATE_PUNCH,'D'),SYSDATE,USER,USERENV('terminal'),'-'|| AS_TIME_PUNCH,a_lunch_time);
        END IF;
      END IF;
END;
You might be better off just storing the punch data into attendancemaster table (allowing browsing, changes, confirmations, ...) and using sql to update attendance_day table in one shot just before the table is needed for further processing
Regards
Etbin