Neurodegenerative Select statement , i don't know why !

Question

create or replace procedure GetReportData (LETTERNO NUMBER)
IS
PATIENTID NUMBER;
BEGIN
select L.LETTERDATE , L.PERSONSCOUNT , GS.GROUPDESC , GS.GROUPDATE , GS.PERSONSCOUNT ,
TOS.TESTNOTES , PS.PATIENTNAME , PS.DATEOFBIRTH , PS.ADDRESS , PS.MOBILE , PS.IDENTITYNUMBER,
TS.SAMPLEID , TW.FIELDID , TW.FIELDVALUE ,RF.FIELDNAME , RF.MALEMINVALUE , RF.MALEMAXVALUE ,TOS.PATIENTID INTO PATIENTID
FROM
TBLLETTERS L ,
TBLGROUPS GS ,
TBLTESTORDERS TOS ,
TBLPATIENTS PS,
TBLTESTSAMPLES TS,
TBLTESTS TW,
TBLREPORTFIELDS RF
WHERE L.LETTERID = GS.LETTERID AND
GS.GROUPID = TOS.GROUPID AND
TOS.PATIENTID = PS.PATIENTID AND
TS.TESTORDERID = TOS.TESTORDERID AND
TS.TESTORDERID = TW.TESTORDERID AND
TW.FIELDID = RF.REPORTFIELDID AND
L.LETTERID = LETTERNO;
END GetReportData;
there is a problem
it tells me that into clause is missing , and if i inserted the into clause it tell me missing data
i don't know why
any help will be greatly appreciated

Answer 1

What do you want to do with this select?
You can't select 17 columns into a single patientid variable
Either declare a cursor and a variable of the cursor row type and fetch into that
Or declare enough variables
Or only select 1 column
CREATE OR REPLACE PROCEDURE GetReportData (LETTERNO NUMBER)
IS
  CURSOR c1
  IS
  select L.LETTERDATE , L.PERSONSCOUNT , GS.GROUPDESC , GS.GROUPDATE , GS.PERSONSCOUNT ,
    TOS.TESTNOTES , PS.PATIENTNAME , PS.DATEOFBIRTH , PS.ADDRESS , PS.MOBILE , PS.IDENTITYNUMBER,
    TS.SAMPLEID , TW.FIELDID , TW.FIELDVALUE ,RF.FIELDNAME , RF.MALEMINVALUE , RF.MALEMAXVALUE ,TOS.PATIENTID
  FROM
    TBLLETTERS L ,
    TBLGROUPS GS ,
    TBLTESTORDERS TOS ,
    TBLPATIENTS PS,
    TBLTESTSAMPLES TS,
    TBLTESTS TW,
    TBLREPORTFIELDS RF
  WHERE L.LETTERID = GS.LETTERID AND
    GS.GROUPID = TOS.GROUPID AND
   TOS.PATIENTID = PS.PATIENTID AND
   TS.TESTORDERID = TOS.TESTORDERID AND
   TS.TESTORDERID = TW.TESTORDERID AND
   TW.FIELDID = RF.REPORTFIELDID AND
   L.LETTERID = LETTERNO;
v1 c1%rowtype;
BEGIN
OPEN c1;
FETCH c1 INTo v1;
CLOSE c1;
presumably you're going to do something with this?
END GetReportData;