ORA-01422 error

Question

Hello,
I am very new about oracle and I have a problem. I am using stored procedure like this;
CREATE OR REPLACE PROCEDURE SP_SELECTKISIBYUSERNAME
MY_AD OUT VARCHAR2,
MY_SOYAD OUT VARCHAR2,
MY_KULLANICIADI OUT VARCHAR2,
MY_SCLNO OUT NUMBER,
KullaniciAdi IN VARCHAR2
AS
BEGIN
SELECT IKY_OZLUK.SCLNO, IKY_OZLUK.AD, IKY_OZLUK.SOYAD, IKY_KULLANICI.KULLANICIADI INTO MY_SCLNO,MY_AD,MY_SOYAD,MY_KULLANICIADI
     FROM IKY_KULLANICI , IKY_OZLUK
     WHERE IKY_KULLANICI.SCLNO=IKY_OZLUK.SCLNO
     AND IKY_KULLANICI.KULLANICIADI = KullaniciAdi;
END;
I call the procedure from visual studio .net. the code I used is:
internal DataSet SelectAdSoyad(string KullaniciAdi)
               OracleConnection connection=new OracleConnection(connectionString);
               connection.Open();
               OracleCommand command=new OracleCommand();
               command.Connection=connection;
               command.CommandText="SP_SELECTKISIBYUSERNAME";
               command.CommandType=CommandType.StoredProcedure;
               OracleParameter inputParameter;
               OracleParameter outputParameter;
               outputParameter=command.Parameters.Add("MY_AD",OracleType.VarChar,20);
               outputParameter.Direction=ParameterDirection.Output;
               outputParameter=command.Parameters.Add("MY_SOYAD",OracleType.VarChar,20);
               outputParameter.Direction=ParameterDirection.Output;
               outputParameter=command.Parameters.Add("MY_KULLANICIADI",OracleType.VarChar,8);
               outputParameter.Direction=ParameterDirection.Output;
               outputParameter=command.Parameters.Add("MY_SCLNO",OracleType.Number,5);
               outputParameter.Direction=ParameterDirection.Output;
               inputParameter=command.Parameters.Add("KULLANICIADI",OracleType.VarChar,8);
               inputParameter.Direction=ParameterDirection.Input ;
               inputParameter.Value=KullaniciAdi;
               OracleDataAdapter dataAdapter=new OracleDataAdapter();
               dataAdapter.SelectCommand=command;
               dataAdapter.TableMappings.Add("Table","KULLANICI");
               DataSet dataSet=new DataSet();
               dataAdapter.Fill(dataSet);
               return dataSet;
and on the page_load of default.aspx I used the code;
private void Page_Load(object sender, System.EventArgs e)
               // Put user code to initialize the page here
               string searchString;
               string userName;
               int myPos;
               searchString =Request.ServerVariables["Remote_User"];
               myPos = searchString.IndexOf(@"\");
               myPos = (myPos + 1);
               userName=(searchString.Substring(myPos)).Trim();
               clsMI kisiUserName=new clsMI();
               DataSet dsMaster=kisiUserName.SelectAdSoyad(userName);
               Response.Write(dsMaster.Tables["KULLANICI"].Rows[0]["MY_SCLNO"].ToString());
the code is returning the error;
ORA-01422: exact fetch returns more than requested number of rows ORA-06512: pozition "TUBPER.SP_SELECTKISIBYUSERNAME", line 14 ORA-06512: position line 1
The question I want to ask is this;
I run the query part of the procedure in the sql plus (of course with variable)
SQL> SELECT IKY_OZLUK.SCLNO, IKY_OZLUK.AD, IKY_OZLUK.SOYAD, IKY_KULLANICI.KULLANICIADI
2 FROM IKY_KULLANICI , IKY_OZLUK
3 WHERE IKY_KULLANICI.SCLNO=IKY_OZLUK.SCLNO
4 AND IKY_KULLANICI.KULLANICIADI = 'etufan';
SCLNO AD SOYAD KULLANIC
62066 EMRAH TUFAN etufan
SQL>
as you can see, there is only one row returns.
So what is the problem.

Answer 1

Ok,
The error message 'ORA-01422: exact fetch returns more than requested number of rows ORA-06512: pozition "TUBPER.SP_SELECTKISIBYUSERNAME", line 14 ORA-06512: position line 1' is telling you that the select statement is returning more than one row, when you're doing a SELECT ... INTO. It also tells you where (line 14).
Your later sqlplus example shows that one row should be returned if the IN parameter, KullaniciAdi = etufan. This suggests that whatever you are passing in, it isn't etufan.
If you're using Visual Studio you should be able to debug this section
searchString =Request.ServerVariables["Remote_User"];
myPos = searchString.IndexOf(@"\");
myPos = (myPos + 1);
userName=(searchString.Substring(myPos)).Trim(); and find out what userName actually is. (I would look carefully at @"\" as a backslash is an escape character).
The oracle part I suggested is a standard way to catch these sort of errors. Essentially you wrap up a statement that might fail in a BEGIN...END block, and the EXCEPTION part allows you to do something when the statement fails.
try
BEGIN
SELECT IKY_OZLUK.SCLNO, IKY_OZLUK.AD, IKY_OZLUK.SOYAD, IKY_KULLANICI.KULLANICIADI INTO MY_SCLNO,MY_AD,MY_SOYAD,MY_KULLANICIADI
FROM IKY_KULLANICI , IKY_OZLUK
WHERE IKY_KULLANICI.SCLNO=IKY_OZLUK.SCLNO
AND IKY_KULLANICI.KULLANICIADI = KullaniciAdi;
EXCEPTION
WHEN TOO_MANY_ROWS THEN
insert into error_table (message)
values('parameter = ' || KullaniciAdi);
END
Obviously you need to create error_table with a suitable message column, but it will show you what was being passed into the procedure.
alternatively you have some output parameters where you could put the results to diagnose the problem;
the EXCEPTION clause could be
EXCEPTION
WHEN TOO_MANY_ROWS THEN
MY_AD := KullaniciAdi,
END;
You could extend that to put the result of a
SELECT COUNT(1) FROM
FROM IKY_KULLANICI , IKY_OZLUK
WHERE IKY_KULLANICI.SCLNO=IKY_OZLUK.SCLNO
AND IKY_KULLANICI.KULLANICIADI = KullaniciAdi;
and put the result into MY_SCLNO, so you could work with them in your .NET application.
Hope that's some ore help.