Oracle exception handling

Question

is this right way do to coding and exception handling
2 cases
if we get overwrite = 1 then update else insert.
I am not sure i have handled proper user defined exception.
Please advise.
create or replace procedure get_rc1(in_file_name in VARCHAR2, overwrite number) is
o_error_number number;
err_exception EXCEPTION;
begin
IF overwrite = 1 THEN
UPDATE store
SET uploaded_by = 'ram'
WHERE file_name = in_file_name;
dbms_output.put_line ('update');
IF (SQL%ROWCOUNT > 0)
THEN
history_log(p_key_id => '123',
desc => 'v_his_desc',
key_word => 'p1' ,
ser_id => 'ram',
status => NULL,
p_error_number => o_error_number);
IF o_error_number <> 0
THEN
RAISE err_exception;
END IF;
END IF;
ELSE
dbms_output.put_line ('insert');
INSERT
INTO store
ID
,FILE_LENGTH
,FILE_NAME
,DOCUMENT_IMAGE
,UPLOADED_DATE
,UPLOADED_BY
,MIME_TYPE
VALUES
1234,
12345,
'123',
NULL ,
sysdate,
'[email protected]',
'balaji'
IF (SQL%ROWCOUNT > 0)
THEN
history_log(p_key_id => '123',
desc => 'v_his_desc',
key_word => 'p2' ,
ser_id => 'ram',
status => NULL,
p_error_number => o_error_number);
IF o_error_number <> 0
THEN
RAISE err_exception;
END IF;
END IF;
END IF;
-- maintaining the history and setting the message
commit;
exception
when others then
dbms_output.put_line ( sqlerrm);
END;

Answer 1

Hi,
user4485803 wrote:
is this right way do to coding and exception handling
2 cases
if we get overwrite = 1 then update else insert.
I am not sure i have handled proper user defined exception.
Please advise.When posting formatted text on this site, type these 6 characters:
\(small letters only, inside curly brackets) before and after each section of formatted text, to preserve spacing.
create or replace procedure get_rc1(in_file_name in VARCHAR2, overwrite number) is
o_error_number number;
err_exception EXCEPTION;
begin
IF overwrite = 1 THEN
UPDATE store
SET uploaded_by = 'ram'
WHERE file_name = in_file_name;
dbms_output.put_line ('update');
IF (SQL%ROWCOUNT > 0)
THEN
history_log(p_key_id => '123',
desc => 'v_his_desc',
key_word => 'p1' ,
ser_id => 'ram',
status => NULL,
p_error_number => o_error_number);
IF o_error_number <> 0Did you mean IF o_error_number 1= 0
?  This site doesn't like to display the &lt;&gt; inequality operator.  Use the equivalent != operator when posting here.
THEN
RAISE err_exception;
END IF;
END IF;
ELSE
dbms_output.put_line ('insert');
INSERT
INTO store
ID
,FILE_LENGTH
,FILE_NAME
,DOCUMENT_IMAGE
,UPLOADED_DATE
,UPLOADED_BY
,MIME_TYPE
VALUES
1234,
12345,
'123',
NULL ,
sysdate,
'[email protected]',
'balaji'
IF (SQL%ROWCOUNT > 0)
THEN
history_log(p_key_id => '123',
desc => 'v_his_desc',
key_word => 'p2' ,
ser_id => 'ram',
status => NULL,
p_error_number => o_error_number);
IF o_error_number <> 0
THEN
RAISE err_exception;
END IF;
END IF;
END IF;
-- maintaining the history and setting the message
commit;
exception
when others then
dbms_output.put_line ( sqlerrm);
END;That looks like the correct way to raise an error.
If you don't have an EXCEPTION section, then PL/SQL will display an error message, including the line number where the error was detected.  If the error occurred deep in a series of called procedures, the error message will include information about what procedures were called, and where.  All of that is potentially very important information, and all of that is lost if you have your own EXCEPTION handler, like the one above.  Acutally, it would be better to call the code above a exception *hider* , not a handler, because all it's really doing is hiding details about any error.
Use an EXCEPTION sedction only when you can improve on the default exception handling.  Even then, you rarely want to use WHEN *OTHERS* ; you want to check for specific errors.  For example...
EXCEPTION
WHEN err_exception
THEN
END;
If any exception other than err_exception occurs, this will not hide it.