Passing variables to a shell script

Question

Hello all,
I have an applescript that is passing two variables to a shell script. Both variables are being passed, but the script isn't running as I would expect and I can't figure out what it's doing and why.
Here is the applescript:
delay 5
tell me to activate
display dialog "Please enter the following information."
property RoomNumber : ""
display dialog "Enter the room number and building (ie 1312CAC):" default answer RoomNumber
set the RoomNumber to text returned of the result
property StationNumber : ""
display dialog "Enter the Station Number:" default answer StationNumber
set the StationNumber to text returned of the result
do shell script ("echo " & RoomNumber & StationNumber & " | /Users/labadmin/Desktop/labbuild.sh")
and here is the shell script
#!/bin/sh
RoomNumber="$1"
StationNumber="$2"
compname=($RoomNumber$StationNumber)
scutil --set ComputerName $compname
scutil --set LocalHostName $compname
scutil --set HostName $compname
echo "Done setting the computer name"
The only name it sets is the ComputerName. LocalHost is blank and hostname is set to Localhost
Can someone see what I'm doing wrong here?
Thank you in advanced.

Answer 1

The line
do shell script ("echo " & RoomNumber & StationNumber & " | /Users/labadmin/Desktop/labbuild.sh")
should be
do shell script ("/Users/labadmin/Desktop/labbuild.sh " & quoted form of RoomNumber & " " & quoted form of StationNumber)
In your original code, you are using echo to pass the variables to stdin of the script instead of as command-line parameters. You also don't handle the case where a value is left blank.