Please Suggest, How to make this view efficient ?

Question

Hi there,
Could you please suggest me,how to make the following VIEW (QUERY) efficient regarding performance point of view.
CREATE OR REPLACE VIEW XXX_TRX_TO_NUM_V
(ROW_NUM, ORIG_TRX_NUM, TRX_NUMBER, TRX_DATE, PURCHASE_ORDER,INTERFACE_HEADER_ATTRIBUTE6, INTERFACE_HEADER_ATTRIBUTE1, INTERFACE_HEADER_ATTRIBUTE5, BILL_TO_CONTACT_ID, REMIT_TO_ADDRESS_ID, BILL_TO_CUSTOMER_ID, BILL_TO_SITE_USE_ID, ORG_ID)
AS
Select rownum row_num,trx_number orig_trx_num,to_number(a.trx_number) trx_number,a.trx_date,a.purchase_order,a.interface_header_attribute1
,a.interface_header_attribute6,a.interface_header_attribute5,a.bill_to_contact_id
,a.remit_to_address_id,a.bill_to_customer_id,a.bill_to_site_use_id,a.org_id
from ra_customer_trx_all a
where a.trx_number is not null
and a.trx_number not in
(select trx_number
from
(select rownum,/*+ ALL_ROWS ,16 */ r.trx_number,ltrim(rtrim(translate(/*+ ALL_ROWS ,16 */ r.TRX_number,'0123456789',' '), ' ' ), ' ' ) tx
from ra_customer_trx_all r)
where tx is not null)
order by trx_number
Thanks in Advance !
Shahzad

Answer 1

I think you have the hints in the wrong place - as far as I was aware, the hint had to come straight after the SELECT/UPDATE/INSERT/DELETE key word - but I could be wrong as I've never really tried it elsewhere. Also, unless the optimiser mode for your database is set to FIRST_ROWS or RULE (god help you!:), ALL_ROWS is the default behaviour.
Basically what you are trying to say is bring me back all ra_customer_trx_all rows that have purely numeric trx_numbers right?
Why, if you need to be able to represent trx_number as a number, do you have non-numeric data in there???? That's a bit dodgy isn't it?
Anyway, what about:
CREATE TABLE dt_test_num (id varchar2(10))
insert
into
     dt_test_num
select
     chr(47 + rownum)
from
     all_tables
where
     rownum <= 20
select
     to_number(id),
     id
from
     dt_test_num
where
     translate(id,'0123456789',' ') IS NULL
update
     dt_test_num
set
     id=id||chr(67-rownum)
select
FROM
     dt_test_num
select
     to_number(id),
     id
from
     dt_test_num
where
     translate(id,'0123456789',' ') IS NULL
/Also, you are selecting rownum and aliasing it. Why? rownum will be assigned before the sort.
HTH
David
Message was edited by:
david_tyler
Hello
Slight correction to the where clause. Art first I thought you didn't need the trim on there, but that was just down to the number sequence in translate...
SQL> select nvl(translate('1A','1234567890',''),'NULL') from dual
  2  /
NVL(
NULL
SQL> select nvl(translate('1A','1234567890',' '),'NULL') from dual
  2  /
NV
A
SQL> select nvl(translate('1','1234567890',' '),'NULL') from dual
  2  /
N
SQL> select nvl(translate('2','1234567890',' '),'NULL') from dual
  2  /
NVL(
NULL
SQL> select nvl(translate('2','0123456789',' '),'NULL') from dual
  2  /
NVL(
NULL
SQL> select nvl(translate('1','0123456789',' '),'NULL') from dual
  2  /
NVL(
NULL
SQL> select nvl(translate('0','0123456789',' '),'NULL') from dual
  2  /
N
SQL> select nvl(TRIM(translate('0','0123456789',' ')),'NULL') from dual
  2  /
NVL(
NULL
SQL> select nvl(TRIM(translate('1','0123456789',' ')),'NULL') from dual
  2  /
NVL(
NULLTranslate still confuses me :-(