PLSQL tuning.

Question

hi,
i have a piece of code like the one below. please help be in optimizing it better.
open vcursor for select *..........where.....
loop
fetch vcursor into .......a,b,c.
var a = fn(a,b,c)
'place a in an array..
end loop..
is there a way to fetch everything at one shot into an array and then pass each value from array to the fn to make it efficient.
thoughts PLEASE.

Answer 1

This is the procedure..
CREATE OR REPLACE FUNCTION sp_get_tariff_adjustment_test (
     p_type               IN INTEGER,      /* 0 -channel, 1 -govt charges */
     p_channel          IN VARCHAR2,      /* the channel code, may be null */
     p_effective_date     IN DATE,     /* effective date to find the charges / discounts at */
     p_serviceref          IN VARCHAR2     /* the service ref */
RETURN TARIFF_ADJUSTMENT_ARRAY
AS
v_error_code          INTEGER := -20102;
v_tariff_adjustment          TARIFF_ADJUSTMENT;
v_adjustments_array          TARIFF_ADJUSTMENT_ARRAY := TARIFF_ADJUSTMENT_ARRAY();
v_row_num                NUMBER := 0;
     type v_cursor_type     Is ref cursor;
     type v_flat is table of tariffadjustment.FLAT%type;
     type v_scale is table of tariffadjustment.scale%type;
     type v_override is table of tariffadjustment.override%type;
     flats v_flat;
     scales v_scale;
     overrides v_override;
BEGIN
     dbms_output.put_line('executing tariff test proc');
     IF p_type = 0 THEN
          -- find the channel tariff adjustments
          IF p_channel is not null THEN
               OPEN v_cursor FOR
               select c.flat, c.scale, c.override
               from channeldefinition a, channeltariffadjustment b, tariffadjustment c
               where a.name = p_channel and
               a.channeldefinitionref = b.channeldefinitionref and
               b.serviceref = p_serviceref and
               p_effective_date > b.effectivefrom and
               p_effective_date <= b.effectiveto and
               b.tariffadjustmentref = c.tariffadjustmentref;
                    FETCH v_cursor bulk collect into flats, scales, overrides;
                    CLOSE v_cursor;
                    for i in flats.first .. flats.last
                    loop
                    v_tariff_adjustment := TARIFF_ADJUSTMENT(flats(i), scales(i), overrides(i));
                    v_adjustments_array.extend;
                    v_row_num := v_row_num + 1;
                    v_adjustments_array(v_row_num) := v_tariff_adjustment;
                    dbms_output.put_line(scales(i));
                    END LOOP;
          END IF;
     ELSE
          raise_application_error(v_error_code, 'Invalid p_type option [' || p_type || ']. Valid options are 0 or 1.');
     END IF;
RETURN v_adjustments_array;
END;
Message was edited by:
user455305