Problem with bean controller

Question

i have an entity controller below.
i also have a jsp page. and an entity class called officer.
on the jsp, i have a link for creating a new officer which basically executes
the method createSetup() below and loads the new jsp for entering the new officer details. on this new jsp i have a link that actually persists the offficer and basically it calls the method create below. if you check at the method create
its is supposed to do some validation. if any ofthe fields is empty, it should not
persist the officer. but it still does even if all fields are empty. what is wrong with my code. flow control or?
* OfficerController.java
* Created on February 1, 2008, 6:43 AM
* To change this template, choose Tools | Template Manager
* and open the template in the editor.
package entities;
import java.util.ArrayList;
import java.util.Collection;
import javax.annotation.Resource;
import javax.faces.application.FacesMessage;
import javax.faces.context.FacesContext;
import javax.faces.model.DataModel;
import javax.faces.model.ListDataModel;
import javax.persistence.EntityManager;
import javax.persistence.EntityManagerFactory;
import javax.persistence.PersistenceUnit;
import javax.persistence.Query;
import javax.transaction.UserTransaction;
* @author user
public class OfficerController {
    /** Creates a new instance of OfficerController */
    public OfficerController() {
    private Officer officer;
    private DataModel model;
    private String searchStr;
    private boolean isSearch;
    private boolean isAdmin=true;
    public boolean isIsAdmin() {
        return isAdmin;
    public void setIsAdmin(boolean isAdmin) {
        this.isAdmin = isAdmin;
    public boolean isIsSearch() {
        return isSearch;
    public void setIsSearch(boolean isSearch) {
        this.isSearch = isSearch;
    public String getSearchStr() {
        return searchStr;
    public void setSearchStr(String searchStr) {
        this.searchStr = searchStr.toUpperCase();
    @Resource
    private UserTransaction utx;
    @PersistenceUnit(unitName = "GMODPU")
    private EntityManagerFactory emf;
    private EntityManager getEntityManager() {
        return emf.createEntityManager();
    private int batchSize = 20;
    private int firstItem = 0;
    public Officer getOfficer() {
        return officer;
    public void setOfficer(Officer officer) {
        this.officer = officer;
    public DataModel getDetailOfficers() {
        return model;
    public void setDetailOfficers(Collection<Officer> m) {
        model = new ListDataModel(new ArrayList(m));
    public String createSetup() {
        this.officer = new Officer();
        return "officer_create";
    public String create() {
        if(valid())
             EntityManager em = getEntityManager();
        try {
            utx.begin();
            em.persist(officer);
            utx.commit();
            addSuccessMessage("Officer was successfully created.");
        } catch (Exception ex) {
            try {
                addErrorMessage(ex.getLocalizedMessage());
                utx.rollback();
            } catch (Exception e) {
                addErrorMessage(e.getLocalizedMessage());
        } finally {
            em.close();
      else{
           addErrorMessage("not valid");
      return "officer_list";
    public String detailSetup() {
        setOfficerFromRequestParam();
        return "officer_detail";
    public String editSetup() {
        setOfficerFromRequestParam();
        return "officer_edit";
    public String edit() {
        EntityManager em = getEntityManager();
        try {
            utx.begin();
            officer = em.merge(officer);
            utx.commit();
            addSuccessMessage("Officer was successfully updated.");
        } catch (Exception ex) {
            try {
                addErrorMessage(ex.getLocalizedMessage());
                utx.rollback();
            } catch (Exception e) {
                addErrorMessage(e.getLocalizedMessage());
        } finally {
            em.close();
        return "officer_list";
    public String destroy() {
        EntityManager em = getEntityManager();
        try {
            utx.begin();
            Officer officer = getOfficerFromRequestParam();
            officer = em.merge(officer);
            em.remove(officer);
            utx.commit();
            addSuccessMessage("Officer was successfully deleted.");
        } catch (Exception ex) {
            try {
                addErrorMessage(ex.getLocalizedMessage());
                utx.rollback();
            } catch (Exception e) {
                addErrorMessage(e.getLocalizedMessage());
        } finally {
            em.close();
        return "officer_list";
    public Officer getOfficerFromRequestParam() {
        EntityManager em = getEntityManager();
        try{
            Officer o = (Officer) model.getRowData();
            o = em.merge(o);
            return o;
        } finally {
            em.close();
    public void setOfficerFromRequestParam() {
        Officer officer = getOfficerFromRequestParam();
        setOfficer(officer);
    public DataModel getOfficers() {
        EntityManager em = getEntityManager();
        try{
            Query q;
           if(!isSearch){
            q = em.createQuery("select object(o) from Officer as o order by o.fullName");
            else {
            q = em.createQuery("select object(o) from Officer as o where (o.fullName like '%"+searchStr+"%' or o.extension like '%"+searchStr+"%' or o.room like '%"+searchStr+"%' or o.designation like '%"+searchStr+"%' or o.department like '%"+searchStr+"%') order by o.fullName");
            q.setMaxResults(batchSize);
            q.setFirstResult(firstItem);
            model = new ListDataModel(q.getResultList());
            return model;
        } finally {
            em.close();
    public static void addErrorMessage(String msg) {
        FacesMessage facesMsg = new FacesMessage(FacesMessage.SEVERITY_ERROR, msg, msg);
        FacesContext fc = FacesContext.getCurrentInstance();
        fc.addMessage(null, facesMsg);
    public static void addSuccessMessage(String msg) {
        FacesMessage facesMsg = new FacesMessage(FacesMessage.SEVERITY_INFO, msg, msg);
        FacesContext fc = FacesContext.getCurrentInstance();
        fc.addMessage("successInfo", facesMsg);
    public Officer findOfficer(Integer id) {
        EntityManager em = getEntityManager();
        try{
            Officer o = (Officer) em.find(Officer.class, id);
            return o;
        } finally {
            em.close();
    public String searchOfficer() {
        isSearch=true;
        firstItem = 0;
        return "search_list";
    public String showOfficers() {
        isSearch=false;
        firstItem = 0;
        return "officer_list";
    public int getItemCount() {
        EntityManager em = getEntityManager();
        try{
             int count=0;
             if(!isSearch){
                count = ((Long) em.createQuery("select count(o) from Officer as o").getSingleResult()).intValue();
            else {
             count = ((Long) em.createQuery("select count(o) from Officer as o where (o.fullName like '%"+searchStr+"%' or o.extension like '%"+searchStr+"%' or o.room like '%"+searchStr+"%' or o.designation like '%"+searchStr+"%' or o.department like '%"+searchStr+"%')").getSingleResult()).intValue();
            return count;
        } finally {
            em.close();
    public int getFirstItem() {
        return firstItem;
    public int getLastItem() {
        int size = getItemCount();
        return firstItem + batchSize > size ? size : firstItem + batchSize;
    public int getBatchSize() {
        return batchSize;
    public String next() {
        if (firstItem + batchSize < getItemCount()) {
            firstItem += batchSize;
        if(!isSearch)
            return "officer_list";
        else
            return "search_list";
    public String prev() {
        firstItem -= batchSize;
        if (firstItem < 0) {
            firstItem = 0;
        if(!isSearch)
            return "officer_list";
        else
            return "search_list";
    private boolean valid()
          if(this.officer.getFullName()==null)
          addErrorMessage("fullName is empty");
          return false;
          else if(this.officer.getExtension()==null){
          addErrorMessage("extension is empty");
          return false;     
          else if(this.officer.getRoom()==null){
          addErrorMessage("room is empty");
          return false;
          else if(this.officer.getDesignation()==null){
          addErrorMessage("designation is empty");
          return false;
          else if(this.officer.getDepartment()==null){
          addErrorMessage("department is empty");
          return false;
          else if(this.officer.getEmail()==null){
          addErrorMessage("email is empty");
          return false;
          else
             return true;
}

Answer 1

Hendrik-Jan,
This is fixed in R11 release.
You could try making a sublass and implement serializable in the subclass.
Steven Davelaar,
Jheadstart team.