Problem with scaling picture

Question

i got this little programm which opens an image. now, unfortunatelly almost all pictures are to big to fit in a frame. therefore i tryed to scale it. for some reason i get this outofmemoryerror. i have absolutely no clue how i could solve this problem.
my code:
the frame:
public class ImageFrame extends JFrame {
    ImagePanel impanel = new ImagePanel();
    Container c = getContentPane();
    public ImageFrame() {
        super("ImageFrame");
        setSize(500,500);
        setLocation(300,300);
        setDefaultCloseOperation(EXIT_ON_CLOSE);
        c.add(impanel);
        setMenuBar(new MyMenuBar());
        setVisible(true);
    class MyMenuBar extends MenuBar {
        public MyMenuBar() {
            Menu m ;
            MenuItem mi;
            m = new Menu("File");
            mi = new MenuItem("Open");
            mi.addActionListener(new ActionListener(){
                public void actionPerformed(ActionEvent e) {
                    impanel.openImage();
            m.add(mi);
            add(m);
}the panel (with the error):
public class ImagePanel extends JPanel {
    Image image;
    Insets insets;
    String file;
    public void setFile(String file) {
        this.file = file;
    @SuppressWarnings("static-access")
    @Override
    public void paintComponent(Graphics g){
        if (file!=null) {           
            Graphics2D g2d = (Graphics2D) g;
            if (insets == null) {
                insets = getInsets();
            ImageIcon icon = new ImageIcon(file);
            image = icon.getImage();
            Image scale = image.getScaledInstance(400, -1, image.SCALE_SMOOTH);
            //HERE I GOT THE ERROR! WITHOUT THE LINE ABOVE THE PROGRAMM WORKS.
            g2d.drawImage(scale, insets.left, insets.top, this);
        repaint();
    public void openImage() {
        try{
            String Filename = openfile();
            if(Filename!=null) setFile(Filename);
            repaint();
        } catch(Exception ex){}
    String openfile(){
        FileDialog fd=new FileDialog(new Frame(),"File Select");
        fd.show();
        String fullpath=fd.getDirectory()+fd.getFile();
        fd.dispose();
        return fullpath;
}hope someone can help me out here. thanks in advance.

Answer 1

gianni88 wrote:
thanks, i moved the repaint() into the actionPerformed part. is that a better place?
where could i go with the scaling part? what is the reason why i get this error?I claim you can get away with no repaints:
code:
1. Read the image
2. rescale it. Here is a good article: [http://today.java.net/pub/a/today/2007/04/03/perils-of-image-getscaledinstance.html]
3. Set this to be the icon on a JLabel that is already in your GUI:
imageLabel.setIcon(new ImageIcon(rescaledImage));Done!