Procedure Doesn't return values

Question

Hello,
I have a stored procedure which has varchar2 as IN and sys_recursor has OUT parameters.
CREATE OR REPLACE PROCEDURE check_values (
     my_values            IN          emp.dept_no%TYPE,
     p_cursor        OUT sys_refcursor
AS
     quoteValues     VARCHAR2 (256);
BEGIN
     SELECT     '''' || REPLACE(my_values, ',', ''',''') || ''''
       INTO     quoteValues
       FROM     DUAL;
     OPEN p_cursor  FOR
          SELECT          emp_no,
                         emp_name,
            FROM     emp
           WHERE     dept_no IN (quoteValues);
END check_values;
/The problem I am facing is in where condition, if I give quoteValues it doesn't fetch me any records when I execute the procedure from sqlplus, but if I am giving
my_values it does fetch me records. I am receiving IN parameters like 9856,9712,8723, so first I put single quote around the emp_no and pass that to where condition.
How can I resolve this issue?
Thanks

Answer 1

user20090209 wrote:
So why then it is not getting executed? if I hard code the above values in where condition it executes fine.Look at your WHERE clause:
WHERE     dept_no IN (quoteValues);How many expressions there are in IN list? Right, only one. So no matter what the value of quoteValues is, that WHOLE value will be compared to dept_no. What you are trying to do can be done via dynamic SQL, LIKE operator or collection.
Dynamic SQL:
CREATE OR REPLACE PROCEDURE check_values (
     my_values            IN          emp.dept_no%TYPE,
     p_cursor        OUT sys_refcursor
AS
     quoteValues     VARCHAR2 (256);
BEGIN
     OPEN p_cursor  FOR
          'SELECT          emp_no,
                         emp_name,
            FROM     emp
           WHERE     dept_no IN (' || my_values || ')';
END check_values;
/ LIKE operator:
CREATE OR REPLACE PROCEDURE check_values (
     my_values            IN          emp.dept_no%TYPE,
     p_cursor        OUT sys_refcursor
AS
     quoteValues     VARCHAR2 (256);
BEGIN
     OPEN p_cursor  FOR
          SELECT          emp_no,
                         emp_name,
            FROM     emp
           WHERE     ',' || my_values || ',' LIKE '%,' || dept_no || ',%';
END check_values;
/ Collection:
CREATE OR REPLACE PROCEDURE check_values (
     my_values            IN          sys.OdciVarchar2List,
     p_cursor        OUT sys_refcursor
AS
     quoteValues     VARCHAR2 (256);
BEGIN
     OPEN p_cursor  FOR
          SELECT          emp_no,
                         emp_name,
            FROM     emp
           WHERE     dept_no IN (SELECT * FROM TABLE(my_values));
END check_values;
/ and pass my_values as sys.OdciVarchar2List('2345','1245','9076').
SY.