Procedure with Cursor

Question

I have the following code:
CREATE OR REPLACE PROCEDURE RENTALPAYMENTS( p_PROPERTY_DETAIL_ID LMR_PROPERTY_DETAILS.LMR_PROPERTY_DETAIL_ID%TYPE )
IS
CURSOR property_detail_cur IS SELECT RENT, BOND, START_DATE, LEASE_PERIOD, PAYMENT_INTERVAL, PROP_PROPERTY_ID, TEN_TENANT_ID
FROM LMR_PROPERTY_DETAILS WHERE LMR_PROPERTY_DETAIL_ID = p_PROPERTY_DETAIL_ID;
v_rent LMR_PROPERTY_DETAILS.RENT%TYPE;
v_bond LMR_PROPERTY_DETAILS.BOND%TYPE;
v_startdate LMR_PROPERTY_DETAILS.START_DATE%TYPE;
v_lease_period LMR_PROPERTY_DETAILS.LEASE_PERIOD%TYPE;
v_payment_interval LMR_PROPERTY_DETAILS.PAYMENT_INTERVAL%TYPE;
v_property_id LMR_PROPERTY_DETAILS.PROP_PROPERTY_ID%TYPE;
v_tenant_id LMR_PROPERTY_DETAILS.TEN_TENANT_ID%TYPE;
BEGIN
OPEN property_detail_cur;
LOOP
FETCH property_detail_cur INTO v_rent, v_bond, v_startdate, v_lease_period, v_payment_interval, v_property_id, v_tenant_id;
DBMS_OUTPUT.PUT_LINE('RENT: '||v_rent);
DBMS_OUTPUT.PUT_LINE('BOND: '||v_bond);
DBMS_OUTPUT.PUT_LINE('START DATE: '||v_startdate);
DBMS_OUTPUT.PUT_LINE('LEASE PERIOD: '||v_lease_period);
DBMS_OUTPUT.PUT_LINE('PAYMENT INTERVAL: '||v_payment_interval);
DBMS_OUTPUT.PUT_LINE('PROPERTY ID: '||v_property_id);
DBMS_OUTPUT.PUT_LINE('TENANT ID: '||v_tenant_id);
EXIT WHEN property_detail_cur%NOTFOUND;
END;
It should be obvious looking at the code what I am attempting to do.
I get the following error when running on the SQL Commandline in Oracle APEX:
Error at line 35: PLS-00103: Encountered the symbol ";" when expecting one of the following:
loop
It highlights line 3.

Answer 1

It should be obvious looking at the code what I am attempting to do.There could be a difference with what your code does, and what you are attempting to do... 'cause what your code does is not compile, and that is probably not what your attempting to do... ;)
Anyway, you are missing the END LOOP;
The way you go through the cursor is row-by-row (a.k.a slow-by-slow), and you don't need al those local variables:
CREATE OR REPLACE PROCEDURE RENTALPAYMENTS( p_PROPERTY_DETAIL_ID LMR_PROPERTY_DETAILS.LMR_PROPERTY_DETAIL_ID%TYPE )
IS
begin
   for rec in (
      SELECT RENT, BOND, START_DATE, LEASE_PERIOD, PAYMENT_INTERVAL, PROP_PROPERTY_ID, TEN_TENANT_ID
      FROM LMR_PROPERTY_DETAILS
      WHERE LMR_PROPERTY_DETAIL_ID = p_PROPERTY_DETAIL_ID
   loop
      DBMS_OUTPUT.PUT_LINE('RENT: '||rec.rent);
      DBMS_OUTPUT.PUT_LINE('BOND: '||rec.bond);
      DBMS_OUTPUT.PUT_LINE('START DATE: '||rec.startdate);
      DBMS_OUTPUT.PUT_LINE('LEASE PERIOD: '||rec.lease_period);
      DBMS_OUTPUT.PUT_LINE('PAYMENT INTERVAL: '||rec.payment_interval);
      DBMS_OUTPUT.PUT_LINE('PROPERTY ID: '||rec.property_id);
      DBMS_OUTPUT.PUT_LINE('TENANT ID: '||rec.tenant_id);
   end loop;
END;
/.. not tested of course...