Remove and SortedSet

Question

Hi all,
I'm just trying to remove the first item from a sorted set yet for some reason I'm having no luck. Here's the code
public class Main
    static  private Comparator smallestDistanceo = new Comparator ()
        public int compare (Object v, Object u)
           return compare ((Integer) v, (Integer) u);
        public int compare (Integer v, Integer u)
            int results = v.intValue () -  u.intValue ();
            if(results == 0)
                return -1;
            else
                return results;
    static SortedSet test = new TreeSet (smallestDistanceo);
    public static void main (String[] args)
        test.add (new Integer(3));
        test.add (new Integer(1));
        test.add (new Integer(2));
        for(Iterator i = test.iterator (); i.hasNext ();)
            Integer curr=(Integer)i.next ();
            System.out.print (curr.intValue ());
        if(test.remove(first))
            System.out.print("\nRemoved\n");
        else
            System.out.print("\nNot Removed\n");
        for(Iterator i = test.iterator (); i.hasNext ();)
            Integer curr=(Integer)i.next ();
            System.out.print (curr.intValue ());
}Yet for some reason the list just keeps coming back with nothing removed.
I'm sure it just something simple but can't see it for the life of me. Any ideas?

Answer 1

Yet for some reason the list just keeps coming back with nothing
removed. I'm sure it just something simple but can't see it for the life
of me. Any ideas?Your Comparator is broken: even if two objects are equal, you
return -1 indicating that the left operand object is smaller than the right
operand object, iow: your comparator never treats two objects as equal.
Even more: if you populate your SortedSet with Integers, you
don't need a user supplied Comparator at all; Integers know perfectly
well how to compare themselves against other integers.
The solution is simple: remove your Comparator and let the built-in
Integer comparator do the rest together with the SortedSet.
kind regards,
Jos