Select condition not work, possible mistake

Question

I have simple select like
String sStatus=req.getParameter("processStatus")==null?"":req.getParameter("processStatus");
I can get the value of
sStatus
but my else is not working, what is the possible mistake?
if(sStatus.equals("#"))
Sql+=" and basicStatus=1 order by family_income asc ";                              
else
Sql+=" and basicStatus=1 and ProcessStatus='"+sStatus+ "' order by family_income asc ";                         
I try sql in db db like and basicStatus=1 and ProcessStatus='"New' order by family_income asc      it work fine, so??
Thank you

Answer 1

Hi jverd,
thank you fot the reply, but before I only nedd to executeQuery my sql once, but, if I use PreparedStatement, then I have to
executeQuery as many as the conditions I have , any way, right now I change my code to
String Sql="SELECT * FROM student2 as s, student_financial_info2 as f where s.student_id=f.student_id ";
                //search for Id, so we don't care about status and how many row in one page
                if (university_ID !=""){                   
                          Sql+=" and s.student_id=? order by family_income asc ";
                          ps = conn.prepareStatement(Sql);
                          ps.setString(1,university_ID );
                          ps.executeUpdate();
                          connectionPool.returnConnection(conn);
                //for group search
                else{
                   if(search.equals("All")){              
                        if(basicStatus.equals("basicStatus"))                     
                             Sql+=" and ProcessStatus=? and basicStatus=? order by family_income asc ";
                                      Sql+=" limit " + currentRow + ",100"; 
                                      ps = conn.prepareStatement(Sql);
                                         ps.setString(1, FStatus);
                                         ps.setInt(2,1);
                                         ps.executeUpdate();
                                         connectionPool.returnConnection(conn);        
                   //for department search
                    else{
                        if(basicStatus.equals("basicStatus")){
                          Sql+=" and faculty =? and ProcessStatus=? and basicStatus=? order by family_income asc";
                          ps = conn.prepareStatement(Sql);
                          ps.setString(1,  search);
                           ps.setString(2, FStatus);
                           ps.setInt(3,1);
                           ps.executeUpdate();
                            connectionPool.returnConnection(conn);}
                        else{
                          Sql+=" and faculty ='"+search+ "' order by family_income asc";
                          ps = conn.prepareStatement(Sql);
                          ps.setString(1,  search);
                          ps.executeUpdate();                 
                            connectionPool.returnConnection(conn);
                }// out elseI get error on String Sql="SELECT * FROM student2 as s, student_financial_info2 as f where s.student_id=f.student_id ";
          //search for Id, so we don't care about status and how many row in one page
          if (university_ID !=""){                   
                    Sql+=" and s.student_id=? order by family_income asc ";
                    ps = conn.prepareStatement(Sql);
                    ps.setString(1,university_ID );
                    ps.executeUpdate();
                    connectionPool.returnConnection(conn);
          //for group search
          else{
          if(search.equals("All")){              
               if(basicStatus.equals("basicStatus"))               
                    Sql+=" and ProcessStatus=? and basicStatus=? order by family_income asc ";
*                    Sql+=" limit " + currentRow + ",100";*
*                    ps = conn.prepareStatement(Sql);*
*                                   ps.setString(1, FStatus);*
*                                   ps.setInt(2,1);*
*                                   ps.executeUpdate();*
*                                   connectionPool.returnConnection(conn);*
          //for department search
          else{
               if(basicStatus.equals("basicStatus")){
          Sql+=" and faculty =? and ProcessStatus=? and basicStatus=? order by family_income asc";
               ps = conn.prepareStatement(Sql);
               ps.setString(1, search);
                    ps.setString(2, FStatus);
                    ps.setInt(3,1);
                    ps.executeUpdate();
                    connectionPool.returnConnection(conn);}
               else{
               Sql+=" and faculty ='"+search+ "' order by family_income asc";
               ps = conn.prepareStatement(Sql);
               ps.setString(1, search);
               ps.executeUpdate();           
                    connectionPool.returnConnection(conn);
          }// out else
I got error on the blod part JDBC error:Parameter index out of range (1 > number of parameters, which is 0).
java.sql.SQLException: Parameter index out of range (1 > number of parameters, w
hich is 0). How com the index is start on 0?
Thank you