SELECT in CASE

Question

CASE v_res_bl
WHEN 'A' THEN RETURN pkg_a.get_id(c_yes,p_id);
WHEN 'B' THEN RETURN pkg_a.get_id(c_no,p_id);
WHEN 'C' THEN
select a
INTO v_res_bl
from table
join 1
join 2
join 3
where 1
and 2;
select a
INTO v_res_bl
from table
join 1
join 2
join 3
where 2
and 2;
CASE v_res_bl1
WHEN 'A' THEN RETURN pkg_a.get_id(c_yes,p_id);
WHEN 'B' THEN RETURN pkg_a.get_id(c_no,p_id);
END CASE;
END CASE;
Can I use this ? Is it correct?

Answer 1

Well, first you CASE v_res_bl, and in case of 'C' you select into the same variable and CASE another one (v_res_bl1). Is that the logic you want? At least, it is confusing.
Perhaps an IF..ELSIF construction would be more readable and easier to debug or modify, if necessary.
Furthermore, try to use exactly one return command in a function. Assign the desired values to a variable and return that value at the end of the function. Again, this will help in terms of debugging and modifying the function in the future and will be more structured and easier to understand for other developers.
if v_res_bl = 'A' then
   v_ret := xy;
elsif v_res_bl = 'B' then
   v_ret := yz;
elsif v_res_bl = 'C' then
   select...
   select...
   if v_res_bl1 /* please give this another name! */ = 'A' then
      v_ret := ab;
   elsif v_res_bl1 = 'B' then
      v_ret := bc;
   end if;
end if;
return v_ret;Just a proposal...
Regards,
Gerd