Selection on single-click with custom TreeCellEditor

Question

Hi,
In a JTree with a custom treecell editor (contains checkbox, label with icon) that overrides abstractcelleditor, selection of nodes does not highlight the selection on a single click. The selection is highlighted on a double click. clicking on the checkbox works fine. any ideas? the treecellrenderer works fine. So if i remove the custom editor and only have the renderer (for checkbox, label and icon) selections are highlighted properly.
Thanks!

Answer 1

Ok, came up with a solution - it makes keyboard navigation and mouse-based multiple selection work. Here's the fixed code:
creating the tree :
JTree tree = new JTree( root  );
tree.setUI( new MyTreeUI() );
tree.setCellRenderer( new OverlayTreeCellRenderer() );
tree.setCellEditor( new OverlayTreeCellRenderer() );
tree.setEditable(true);
tree.getSelectionModel().setSelectionMode(TreeSelectionModel.DISCONTIGUOUS_TREE_SELECTION);
tree.setInvokesStopCellEditing( true );
scrollPane.setViewportView( tree );
add( scrollPane );the renderer / editor:
  protected static class OverlayTreeCellRenderer extends JPanel implements TreeCellRenderer, TreeCellEditor
    protected Color selBdrColor = UIManager.getColor( "Tree.selectionBorderColor" );
    protected Color selFG = UIManager.getColor( "Tree.selectionForeground" );
    protected Color selBG = UIManager.getColor( "Tree.selectionBackground" );
    protected Color txtFG = UIManager.getColor( "Tree.textForeground" );
    protected Color txtBG = UIManager.getColor( "Tree.textBackground" );
    protected JCheckBox visibleCheckBox = new JCheckBox();
    protected JLabel overlayName = new JLabel();
    protected JCheckBox showLabelCheckBox = new JCheckBox();
    protected LinkedList<CellEditorListener> listeners = new LinkedList<CellEditorListener>();
    protected final ActionListener checkBoxListener = new ActionListener() {
      public void actionPerformed ( ActionEvent ae )
        if ( stopCellEditing() )
          fireEditingStopped();
    protected final MouseListener labelListener = new MouseAdapter() {       
      public void mouseReleased ( MouseEvent e )
        if ( stopCellEditing() )
          fireEditingStopped();
     * Constructor.
    public OverlayTreeCellRenderer ()
      setLayout( new BoxLayout( this, BoxLayout.LINE_AXIS ) );
      visibleCheckBox.setOpaque( false );
      showLabelCheckBox.setOpaque( false );
      add( visibleCheckBox );
      add( overlayName );
      add( showLabelCheckBox );
      setBackground( txtBG );
      setForeground( txtFG );     
      visibleCheckBox.addActionListener( checkBoxListener );
      showLabelCheckBox.addActionListener( checkBoxListener );
      overlayName.addMouseListener( labelListener );
     * Returns the renderer
    public Component getTreeCellRendererComponent ( JTree tree, Object value,
        boolean selected, boolean expanded, boolean leaf, int row,
        boolean hasFocus )
      DefaultMutableTreeNode node = (DefaultMutableTreeNode) value;           
      OverlayDescriptor data = (OverlayDescriptor) node.getUserObject();
      overlayName.setText( data.overlayName );
      visibleCheckBox.setSelected( data.visible );
      showLabelCheckBox.setSelected( data.label );   
      if ( selected )
        setBackground( selBG );
        setForeground( selFG );
      else
        setBackground( txtBG );
        setForeground( txtFG );
      return this;
    // ------------------------------------------------- Cell Editor
    // Returns the editor
    public Component getTreeCellEditorComponent ( JTree tree, Object value,
        boolean isSelected, boolean expanded, boolean leaf, int row )
      return getTreeCellRendererComponent( tree, value, true, expanded, leaf, row, true );
    // Implement the CellEditor methods.
    public void cancelCellEditing ()
    // Stop editing only if the user entered a valid value.
    public boolean stopCellEditing ()
      requestFocusInWindow();
      return true;
    // This method is called when editing is completed.
    // It must return the new value to be stored in the cell.
    public Object getCellEditorValue ()
      return new OverlayDescriptor( overlayName.getText(), showLabelCheckBox.isSelected(), visibleCheckBox.isSelected() );
    // Start editing when the mouse button is clicked.
    public boolean isCellEditable ( EventObject eo )
      return true;
    public boolean shouldSelectCell ( EventObject eo )
      return true;
    // Add support for listeners.
    public void addCellEditorListener ( CellEditorListener cel )
      listeners.add( cel );
    public void removeCellEditorListener ( CellEditorListener cel )
      listeners.remove( cel );
    protected void fireEditingStopped ()
      if ( listeners.size() > 0 )
        ChangeEvent ce = new ChangeEvent( this );
        for ( CellEditorListener l : listeners )
          l.editingStopped( ce );
  }subclass of BasicTreeUI:
   * Fix multiple-selection handling in BasicTreeUI which doesn't appear to work
   * when the tree has a custom editor.
  protected static class MyTreeUI extends BasicTreeUI {   
    protected boolean startEditing ( TreePath path, MouseEvent event )
       * BasicTreeUI startEditing(..) method doesn't handle multiple selection
       * well. This circumvents that for when Ctrl or Shift is held down by
       * first saving the current selection, and then restoring it after calling
       * super.startEditing(..).
      ArrayList<TreePath> selectedPaths = null;
      if ( tree.getSelectionCount() > 0 && event.isControlDown() )
        selectedPaths = new ArrayList<TreePath>( tree.getSelectionCount() + 1 );
        for ( TreePath p : tree.getSelectionPaths() )
          selectedPaths.add( p );
        if ( !tree.isPathSelected( path ) )
          selectedPaths.add( path );
        else
          selectedPaths.remove( path );
      else if ( tree.getSelectionCount() > 0 && event.isShiftDown() )
        int endRow = tree.getRowForPath( path );
        int startRow = tree.getAnchorSelectionPath() == null ? endRow : tree
            .getRowForPath( tree.getAnchorSelectionPath() );
        if ( startRow > endRow )
          int temp = endRow;
          endRow = startRow;
          startRow = temp;
        selectedPaths = new ArrayList<TreePath>( endRow - startRow + 1 );
        for ( int row = startRow; row <= endRow; row++ )
          selectedPaths.add( tree.getPathForRow( row ) );
      boolean val = super.startEditing( path, event );
      if ( selectedPaths != null )
        tree.setSelectionPaths( selectedPaths.toArray( new TreePath[0] ) );
      return val;
  };