Selector bug?

Question

Hello.
I've written sample socket server on Java using java.nio.* and expirienced problem that seemed to be solved here: [http://bugs.sun.com/view_bug.do?bug_id=6403933]. Behaviour is like described in bug report: after some connections Selector doesn't wait a timeout, it executes ten times a millisecond.
According to bug database this should be fixed in 6u4(b02), we have 6u16(b01) and Linux 2.6.28. How come that 6u16 doesn't contain fix added in 6u4? is that possible?
Code goes here:
public void work(long timeout) {
        int retval = 0;
        try {
            retval = m_selector.select(timeout);
        catch (Exception e) {
            System.out.println(e.getMessage());
        if (retval == 0)
            return;
        Iterator it = m_selector.selectedKeys().iterator();
        while (it.hasNext()) {
            SelectionKey key = (SelectionKey)it.next();
            it.remove();
            if (!key.isAcceptable())
                continue;
            try {
                Socket socket = m_sockl.accept();
                  System.out.println("socket accepted");
                m_workerPool.add(socket);
            catch (IOException e) {
            catch (PoolFullException e) {
                System.err.println("pool is full");
    }The function is executed in loop:
while (m_running) {
    serverFacade.work(100);
}

Answer 1

ejp wrote:
in real life clients will disconnect when they want and how they want, so I can't rely on closing channels on server side.That doesn't make sense to me. In real life, both the client and the server have to close their channels. If you're decermenting the client count you should be closing the channel. Alternatively maybe you shouldn'ty be decrementing the client count?They have to, but they often don't ((: For example, what happens with your software when connection broke?
I should write a production code, not a laboratorial one, so I want to be shure that my software will work as expected under any circumstances.
Okay, current code (which still causes immediate select exits):    public void run() {
        Selector selector;
        try {
            selector = Selector.open();
        catch (IOException e) {
            System.err.println("ServerWorker: cannot open selector");
            return;
        System.out.println("worker running, have " + m_commandHandlers.size() + " command handlers");
        while (!m_stopped) {
            int n;
            addNewClients(selector);
            if (m_clients <= 0)
                continue;
            try {
                n = selector.select(m_timeout);
            catch (IOException e) {
                System.err.println("selector.select error" + e.getMessage());
                return;
            if (this.interrupted())
                continue;
            if (n == 0) {
                System.out.println("continue " + System.currentTimeMillis());
                continue;
            System.out.println("select exited");
            Iterator it = selector.selectedKeys().iterator();
            while (it.hasNext()) {
                SelectionKey key = (SelectionKey)it.next();
                it.remove();
                if (!key.isReadable())
                    continue;
                System.out.println("got some message from client");
                if (!proceedInput(key)) {
                    System.out.println("closing client channel");
                    try {
                        key.channel().close();
                    catch (IOException e) {
                        System.err.println("channel close failed: " + e.getMessage());
                    key.cancel();
                    m_clients--;
    }Is this right?