Simplel complex report query

Question

hi guru's
i had prepared two complex reports seperately having the same Selection-screen , internal tables and declerations...now i have to combine both the reports into one single report....based upon <b>one field (i.e, filed PROCESS_TYPE)</b> of Selection-criteria(i.e, S_PR_TYP ) i have to display 2 outputs..One for SHC and another for CONF.....But the Logic  and Header display for the 2 output's is different   ........please let me know where should i write the logic ....and how the logic should be build....
the code is as follows :
<u><b>The code which is common for both the reports:</b></u>
$$********************************************************************
$$    TABLES DECLERATION
$$********************************************************************
TABLES: crmd_orderadm_h,
        crmd_orderadm_i,
        bbp_pdigp.
$$********************************************************************
$$  TYPE-POOLS
$$********************************************************************
TYPE-POOLS: slis, list.
$$********************************************************************
$$    GLOBAL TYPES
$$********************************************************************
TYPES: BEGIN OF y_str1,
       CLIENT         TYPE CRMD_ORDERADM_H-CLIENT,
       guid           TYPE crmd_orderadm_h-guid,
       object_id      TYPE crmd_orderadm_h-object_id,
       object_type    TYPE crmd_orderadm_h-object_type,
       process_type   TYPE crmd_orderadm_h-process_type,
       created_at     TYPE crmd_orderadm_h-created_at,
       changed_at     TYPE crmd_orderadm_h-changed_at,
       archiving_flag TYPE crmd_orderadm_h-archiving_flag,
       deliv_date     TYPE bbp_pdigp-deliv_date,
       final_entry    TYPE bbp_pdigp-final_entry,
       del_ind        TYPE bbp_pdigp-del_ind,
       END OF y_str1.
TYPES: BEGIN OF y_str2,
       guid1          TYPE crmd_orderadm_h-guid,
       object_id      TYPE crmd_orderadm_h-object_id,
       object_type    TYPE crmd_orderadm_h-object_type,
       process_type   TYPE crmd_orderadm_h-process_type,
       created_at     TYPE crmd_orderadm_h-created_at,
       changed_at     TYPE crmd_orderadm_h-changed_at,
       archiving_flag TYPE crmd_orderadm_h-archiving_flag,
       guid2          TYPE crmd_orderadm_i-guid,
       header         TYPE crmd_orderadm_i-header,
       guid3          TYPE bbp_pdigp-guid,
       deliv_date     TYPE bbp_pdigp-deliv_date,
       final_entry    TYPE bbp_pdigp-final_entry,
       del_ind        TYPE bbp_pdigp-del_ind,
       END OF y_str2.
$$********************************************************************
$$    GLOBAL CONSTANTS
$$********************************************************************
CONSTANTS: C_BLANK_F(1)           TYPE C VALUE 'X',
           C_DEL_IND_F(1)         TYPE C VALUE 'X',
           C_ARCHIVING_FLAG(1)    TYPE C VALUE 'X',
           C_FINAL_ENTRY_F(1)     TYPE C VALUE 'X',
           C_FINAL_ENTRY_SPACE(1) TYPE C VALUE ' ',
           C_CBA_SPACE(1)         TYPE C VALUE ' ',
           C_DEL_SPACE(1)         TYPE C VALUE ' '.
$$********************************************************************
$$    Global Elementary Variables
$$********************************************************************
DATA: w_ld_lines                 TYPE i,
      w_ld_linesc(10)            TYPE c,
      w_del_ind                  TYPE c,
      w_final_entry              TYPE c,
      w_COUNT_cba                TYPE I VALUE 0,
      w_count_f                  TYPE I VALUE 0,
      W_BLANK_F                  TYPE C,
      W_FINAL_ENTRY_F            TYPE C,
      W_DEL_COUNT                TYPE I VALUE 0,
      W_PER_CBA1                 TYPE P decimals 3,
      W_PER_CBA                  TYPE P decimals 2,
      W_PER_E_LINE               TYPE I,
      W_N                        TYPE I.
$$********************************************************************
$$    GLOBAL INTERNAL TABLES (custom structure)
$$********************************************************************
DATA:   t_str_sc1 TYPE STANDARD TABLE OF y_str1 INITIAL SIZE 1.
DATA:   t_str_sc2 TYPE STANDARD TABLE OF y_str2 INITIAL SIZE 1.
DATA:   t_header      TYPE   slis_t_listheader,
        w_header      TYPE   slis_listheader,
        e_line        LIKE   w_header-info.
DATA:   v_index       LIKE SY-TABIX.
        v_index = '1'.
$$********************************************************************
$$    GLOBAL FIELD-SYMBOLS
$$********************************************************************
FIELD-SYMBOLS: <FS_STR1> TYPE Y_STR1,
               <FS_STR2> TYPE Y_STR2.
$$********************************************************************
$$    PARAMETERS & SELECT-OPTIONS
$$********************************************************************
SELECTION-SCREEN: BEGIN OF BLOCK b1 WITH FRAME TITLE text-001.
SELECT-OPTIONS: s_scno   FOR crmd_orderadm_h-object_id,
                s_pr_typ FOR crmd_orderadm_h-process_type NO INTERVALS NO DATABASE SELECTION NO-EXTENSION DEFAULT 'SHC',
                s_change FOR crmd_orderadm_h-changed_at.
SELECTION-SCREEN END OF BLOCK b1.
$$********************************************************************
$$    START-OF-SELECTION
$$********************************************************************
START-OF-SELECTION.
  REFRESH t_str_sc1.
  SELECT client
         guid
         object_id
         object_type
         process_type
         created_at
         changed_at
         archiving_flag
         FROM crmd_orderadm_h INTO TABLE t_str_sc1
         WHERE object_id IN s_scno AND  changed_at IN s_change AND process_type IN s_pr_typ.
  IF sy-subrc <> 0.
    MESSAGE I002.
  ENDIF.
  LOOP AT t_str_sc1 ASSIGNING <FS_STR1>.
    REFRESH t_str_sc2.
    SELECT a~guid
           a~object_id
           a~object_type
           a~process_type
           a~created_at
           a~changed_at
           a~archiving_flag
           b~guid
           b~header
           c~guid
           c~deliv_date
           c~final_entry
           c~del_ind
      INTO TABLE t_str_sc2
      FROM crmd_orderadm_h AS a INNER JOIN crmd_orderadm_i AS b
        ON aguid eq bheader INNER JOIN bbp_pdigp AS c
        ON bguid eq cguid
     WHERE a~guid eq <FS_STR1>-guid.
<u><b>THE LOGIC FOR FIRST REPORT:</b></u>
*"logic for displaying Delivery date at Header level
      SORT T_STR_SC2 BY DELIV_DATE.
      DESCRIBE TABLE T_STR_SC2 LINES W_N.
     READ TABLE T_STR_SC2 WITH KEY DELIV_DATE = T_STR_SC2-DELIV_DATE INTO <FS_STR2>-deliv_date.
      READ TABLE T_STR_SC2 INDEX v_index ASSIGNING <FS_STR2>.
      IF SY-SUBRC = 0.
        <FS_STR1>-deliv_date = <FS_STR2>-deliv_date.
        MODIFY  T_STR_SC1 FROM <FS_STR1> TRANSPORTING DELIV_DATE.
      ENDIF.
*"Setting up the flags for the entire items in CRMD_ORDERADM_H as per the scenario
    LOOP AT T_STR_SC2 ASSIGNING <FS_STR2> WHERE HEADER EQ <FS_STR1>-GUID.
      IF <FS_STR2>-DEL_IND NE 'X'.
        IF <FS_STR2>-FINAL_ENTRY NE 'X'.
          W_BLANK_f = C_BLANK_F.
        ELSE.
          W_FINAL_ENTRY_F = C_FINAL_ENTRY_F.
        ENDIF.
      ENDIF.
    ENDLOOP.
*"Logic started at item level
    LOOP AT T_STR_SC2 ASSIGNING <FS_STR2> WHERE HEADER EQ <FS_STR1>-GUID.
      IF W_BLANK_F NE 'X'.
        IF W_FINAL_ENTRY_F NE 'X'.
*" Displaying the status for Del 'X' , Final_entry ' ', Archive_flag 'X'.
          <FS_STR1>-DEL_IND = C_DEL_IND_F.
         W_DEL_COUNT = W_DEL_COUNT + 1.
          <FS_STR1>-FINAL_ENTRY = C_FINAL_ENTRY_SPACE.
          <FS_STR1>-ARCHIVING_FLAG = C_ARCHIVING_FLAG.
         w_COUNT_cba = w_COUNT_cba + 1.
          MODIFY  T_STR_SC1 FROM <FS_STR1> TRANSPORTING DEL_IND FINAL_ENTRY ARCHIVING_FLAG.
        ELSE.
*" Displaying the status for Del ' ' , Final_entry 'X', Archive_flag 'X'.
          <FS_STR1>-FINAL_ENTRY = C_FINAL_ENTRY_F.
         w_count_f  = w_count_f  + 1.
          <FS_STR1>-DEL_IND = C_DEL_SPACE.
          <FS_STR1>-ARCHIVING_FLAG = C_ARCHIVING_FLAG.
         w_COUNT_cba = w_COUNT_cba + 1.
          MODIFY  T_STR_SC1 FROM <FS_STR1> TRANSPORTING FINAL_ENTRY DEL_IND ARCHIVING_FLAG.
        ENDIF.
      ELSE.
*" Displaying the status for Del ' ' , Final_entry ' ', Archive_flag ' '.
        <FS_STR1>-DEL_IND = C_DEL_SPACE.
        <FS_STR1>-FINAL_ENTRY = C_FINAL_ENTRY_SPACE.
        <FS_STR1>-ARCHIVING_FLAG = C_CBA_SPACE.
        MODIFY  T_STR_SC1 FROM <FS_STR1> TRANSPORTING DEL_IND FINAL_ENTRY ARCHIVING_FLAG .
      ENDIF.
    ENDLOOP.    "end of t_str_sc2
    if  <FS_STR1>-DEL_IND eq C_DEL_IND_F.
         W_DEL_COUNT = W_DEL_COUNT + 1.
    endif.
   if <FS_STR1>-FINAL_ENTRY eq C_FINAL_ENTRY_F.
            w_count_f  = w_count_f  + 1.
   endif.
  if  <FS_STR1>-ARCHIVING_FLAG eq C_ARCHIVING_FLAG.
           w_COUNT_cba = w_COUNT_cba + 1.
    endif.
    CLEAR: W_BLANK_F , W_FINAL_ENTRY_F.
*"Logic ended at item level
  ENDLOOP.    "end of t_str_sc1
*" when Transaction type is SHC
IF <FS_STR1>-process_type EQ 'SHC'.
DESCRIBE TABLE t_str_sc1 LINES w_ld_lines.
  w_ld_linesc = w_ld_lines.
  CONCATENATE ' TOTAL NO OF RECORDS SELECTED:' w_ld_linesc INTO e_line SEPARATED BY space.
*" Percentage of Archived SC's
  W_PER_E_LINE = w_ld_lines.
  W_PER_CBA1 = W_COUNT_CBA / W_PER_E_LINE.
  W_PER_CBA = W_PER_CBA1 * 100.
*" Displaying the total no of records fetched for DB
  FORMAT COLOR 7.
  WRITE:/9 e_line .
  WRITE:/10 'TOTAL NO OF FINAL ENTRIES SELECTED:',        w_count_f.
  WRITE:/10 'TOTAL NO OF DELETE ENTRIES SELECTED:',       W_DEL_COUNT.
  WRITE:/10 'TOTAL NO OF ENTRIES SELECTED FOR ARCHIVING:',w_COUNT_cba.
  SKIP.
  WRITE:/10 'PERCENTAGE OF CAN BE ARCHIVED:',W_PER_CBA,'%'.
  FORMAT COLOR 3.
  SKIP.
  WRITE:/30 '#### SC HAVING FINAL ENTRY INDICATOR FOR ALL ITEM IN SRM #####'.
  FORMAT COLOR OFF.
  WRITE:/30(63) SY-ULINE.
  ULINE.
*" Displaying Headings for the Report
NEW-LINE SCROLLING.
  WRITE:/3        'Transaction No',                          18  sy-vline,
         19       'Transaction Type',                        36  sy-vline,
         37       'Business Trans.Cat',                      56  sy-vline,
         57       'Created On',                              68  sy-vline,
         69(10)   'Changed On',                              84  sy-vline,
         85       'Delivery date',                           99  sy-vline,
        100       'Final Entry Ind',                        115  sy-vline,
        116       'Deletion Ind',                           129  sy-vline,
        130       'Can be Archived',                        146  sy-vline.
SET LEFT SCROLL-BOUNDARY COLUMN 19.
  ULINE.
$$********************************************************************
$$    DISPLAY DATA AT HEADER LEVEL FOR SHC
$$********************************************************************
*" Sort the SC in Sequence
  SORT t_str_sc1 BY object_id.
  IF SY-SUBRC = 0.
*" Displaying the Report at Header level
    LOOP AT t_str_sc1 ASSIGNING <FS_STR1>.
      IF NOT <FS_STR1>-archiving_flag IS INITIAL.
        FORMAT COLOR 7.
      ELSE.
        FORMAT COLOR 3.
      ENDIF.
  WRITE:/3        <FS_STR1>-object_id,                       18  sy-vline,
         19       <FS_STR1>-process_type,                    36  sy-vline,
         37       <FS_STR1>-object_type,                     56  sy-vline,
         57       <FS_STR1>-created_at,                      68  sy-vline,
         69(10)   <FS_STR1>-changed_at,                      84  sy-vline,
         85       <FS_STR1>-deliv_date,                      99  sy-vline,
        100       <FS_STR1>-final_entry,                    115  sy-vline,
        116       <FS_STR1>-del_ind,                        129  sy-vline,
        130       <FS_STR1>-archiving_flag,                 146  sy-vline.
    ENDLOOP.   "end of t_str_sc1 displaying at header level
  ENDIF.    "End of SY-SUBRC
*ENDCASE.
ENDIF.   "End of displaying Transaction type as SHC
*" when Transaction type is CONF
IF <FS_STR1>-process_type EQ 'CONF'.
  DESCRIBE TABLE t_str_sc1 LINES w_ld_lines.
  w_ld_linesc = w_ld_lines.
  CONCATENATE ' TOTAL NO OF RECORDS SELECTED:' w_ld_linesc INTO e_line SEPARATED BY space.
*" Percentage of Archived SC's
  W_PER_E_LINE = w_ld_lines.
  W_PER_CBA1 = W_COUNT_CBA / W_PER_E_LINE.
  W_PER_CBA = W_PER_CBA1 * 100.
*" Displaying Headings for the Report
*" Displaying the total no of records fetched for DB
  FORMAT COLOR 7.
  WRITE:/9 e_line .
WRITE:/10 'TOTAL NO OF FINAL ENTRIES SELECTED:',        w_count_f.
  WRITE:/10 'TOTAL NO OF DELETE ENTRIES SELECTED:',       W_DEL_COUNT.
  WRITE:/10 'TOTAL NO OF ENTRIES SELECTED FOR ARCHIVING:',w_COUNT_cba.
  SKIP.
  WRITE:/10 'PERCENTAGE OF CAN BE ARCHIVED:',W_PER_CBA,'%'.
  FORMAT COLOR 3.
  SKIP.
  WRITE:/30 '#### SC HAVING FINAL ENTRY INDICATOR FOR ALL ITEM IN SRM #####'.
  FORMAT COLOR OFF.
  WRITE:/30(63) SY-ULINE.
  ULINE.
NEW-LINE SCROLLING.
  WRITE:/3        'Transaction No',                          18  sy-vline,
         19       'Transaction Type',                        36  sy-vline,
         37       'Business Trans.Cat',                      56  sy-vline,
         57       'Created On',                              68  sy-vline,
         69(10)   'Changed On',                              84  sy-vline,
         85       'Delivery date',                           99  sy-vline,
       100       'Final Entry Ind',                        115  sy-vline,
        100       'Deletion Ind',                           112  sy-vline,
        113       'Can be Archived',                        129  sy-vline.
SET LEFT SCROLL-BOUNDARY COLUMN 19.
  ULINE.
*$$********************************************************************
*$$    DISPLAY DATA AT HEADER LEVEL
*$$********************************************************************
*" Sort the SC in Sequence
  SORT t_str_sc1 BY object_id.
  IF SY-SUBRC = 0.
*" Displaying the Report at Header level
    LOOP AT t_str_sc1 ASSIGNING <FS_STR1>.
      IF NOT <FS_STR1>-archiving_flag IS INITIAL.
        FORMAT COLOR 7.
      ELSE.
        FORMAT COLOR 3.
      ENDIF.
  WRITE:/3        <FS_STR1>-object_id,                       18  sy-vline,
         19       <FS_STR1>-process_type,                    36  sy-vline,
         37       <FS_STR1>-object_type,                     56  sy-vline,
         57       <FS_STR1>-created_at,                      68  sy-vline,
         69(10)   <FS_STR1>-changed_at,                      84  sy-vline,
         85       <FS_STR1>-deliv_date,                      99  sy-vline,
       100       <FS_STR1>-final_entry,                    115  sy-vline,
        100       <FS_STR1>-del_ind,                        112  sy-vline,
        113       <FS_STR1>-archiving_flag,                 129  sy-vline.
    ENDLOOP.   "end of t_str_sc1 displaying
  ENDIF.  "End of SY-SUBRC
ENDIF.  "End of displaying Transaction type as CONF
<b><u>
THE LOGIC FOR THE SECOND REPORT</u></b>
LOOP AT t_str_sc1 ASSIGNING <FS_STR1>.
      REFRESH t_str_sc2.
      SELECT a~guid
             a~object_id
             a~object_type
             a~process_type
             a~created_at
             a~changed_at
             a~archiving_flag
             b~guid
             b~header
             c~guid
             c~deliv_date
             c~final_entry
             c~del_ind
        INTO TABLE t_str_sc2
        FROM crmd_orderadm_h AS a INNER JOIN crmd_orderadm_i AS b
          ON aguid eq bheader INNER JOIN bbp_pdigp AS c
          ON bguid eq cguid
       WHERE a~guid eq <FS_STR1>-guid.
       IF NOT t_str_sc2[] is INITIAL.
      LOOP AT T_STR_SC2 ASSIGNING <FS_STR2>.
       IF <FS_STR2>-DEL_IND NE C_DEL_SPACE.        " if x
          <FS_STR2>-DEL_IND = C_DEL_IND_F.
          <FS_STR2>-ARCHIVING_FLAG = C_ARCHIVING_FLAG.
          MODIFY T_STR_SC2 FROM <FS_STR2> .
        ELSE.         "if ' '
          EXIT.
        ENDIF.
      ENDLOOP.    "End loop of t_str_sc2
      MOVE <FS_STR2>-DEL_IND TO <FS_STR1>-DEL_IND.
      MOVE <FS_STR2>-ARCHIVING_FLAG TO <FS_STR1>-ARCHIVING_FLAG.
      MODIFY T_STR_SC1 FROM <FS_STR1>.
    ELSE.   " For sy-subrc
      <FS_STR1>-REMARKS = c_itnf.
      MODIFY T_STR_SC1 FROM <FS_STR1>.
    ENDIF.    " End of sy-subrc
  IF <FS_STR1>-DEL_IND eq C_DEL_IND_F.
         W_DEL_COUNT = W_DEL_COUNT + 1.
  ENDIF.
  IF  <FS_STR1>-ARCHIVING_FLAG eq C_ARCHIVING_FLAG.
        w_COUNT_cba = w_COUNT_cba + 1.
  ENDIF.
  ENDLOOP.  "End loop of t_str_sc1
********************************" when Transaction type is CONF
*******************************IF <FS_STR1>-process_type EQ 'CONF'.
  DESCRIBE TABLE t_str_sc1 LINES w_ld_lines.
  w_ld_linesc = w_ld_lines.
  CONCATENATE ' TOTAL NO OF RECORDS SELECTED:' w_ld_linesc INTO e_line SEPARATED BY space.
*" Percentage of Archived SC's
  W_PER_E_LINE = w_ld_lines.
  W_PER_CBA1 = W_COUNT_CBA / W_PER_E_LINE.
  W_PER_CBA = W_PER_CBA1 * 100.
*" Displaying Headings for the Report
*" Displaying the total no of records fetched for DB
  FORMAT COLOR 7.
  WRITE:/9 e_line .
WRITE:/10 'TOTAL NO OF FINAL ENTRIES SELECTED:',        w_count_f.
  WRITE:/10 'TOTAL NO OF DELETE ENTRIES SELECTED:',       W_DEL_COUNT.
  WRITE:/10 'TOTAL NO OF ENTRIES SELECTED FOR ARCHIVING:',w_COUNT_cba.
  SKIP.
  WRITE:/10 'PERCENTAGE OF CAN BE ARCHIVED:',W_PER_CBA,'%'.
  FORMAT COLOR 3.
  SKIP.
  WRITE:/30 '#### SC HAVING FINAL ENTRY INDICATOR FOR ALL ITEM IN SRM #####'.
  FORMAT COLOR OFF.
  WRITE:/30(63) SY-ULINE.
  ULINE.
  NEW-LINE SCROLLING.
  WRITE:/3        'Transaction No',                          18  sy-vline,
         19       'Transaction Type',                        36  sy-vline,
         37       'Business Trans.Cat',                      56  sy-vline,
         57       'Created On',                              68  sy-vline,
         69(10)   'Changed On',                              84  sy-vline,
        100       'Deletion Ind',                           112  sy-vline,
        113       'Can be Archived',                        129  sy-vline,
        130       'Remarks',                                 150  sy-vline.
  SET LEFT SCROLL-BOUNDARY COLUMN 19.
  ULINE.
*$$********************************************************************
*$$    DISPLAY DATA AT HEADER LEVEL
*$$********************************************************************
*" Sort the SC in Sequence
  SORT t_str_sc1 BY object_id.
  IF SY-SUBRC = 0.
*" Displaying the Report at Header level
    LOOP AT t_str_sc1 ASSIGNING <FS_STR1>.
      IF NOT <FS_STR1>-archiving_flag IS INITIAL.
        FORMAT COLOR 7.
      ELSE.
        FORMAT COLOR 3.
      ENDIF.
      WRITE:/3        <FS_STR1>-object_id,                       18  sy-vline,
             19       <FS_STR1>-process_type,                    36  sy-vline,
             37       <FS_STR1>-object_type,                     56  sy-vline,
             57       <FS_STR1>-created_at,                      68  sy-vline,
             69(10)   <FS_STR1>-changed_at,                      84  sy-vline,
            100       <FS_STR1>-del_ind,                        112  sy-vline,
            113       <FS_STR1>-archiving_flag,                 129  sy-vline,
            130       <FS_STR1>-REMARKS,                        150  sy-vline.
    ENDLOOP.   "end of t_str_sc1 displaying
  ENDIF.  "End of SY-SUBRC
**********************ENDIF.  "End of displaying Transaction type as CONF

Answer 1

Very difficult to give you a solution without having access to the actual data and tables and some basic relationship model to explain the entities of the tables.
But one thing I found that makes dealing complex queries a lot easier - easier to code and to read and to maintain - is to use the WITH clause. This allows the type of modularisation of code that we're using in other languages.
The basic syntax is:WITH <alias1> AS(
  SELECT ...
<alias2> AS(
  SELECT ...
<aliasn> AS(
  SELECT ...
SELECT
FROM alias1, .. aliasnThis allows you to create distinct query sets once - and then re-use these again in joins, selects, and even other sub-sets.
The resulting SQL is a lot les stressful on the eye and makes the whole "processing logic" of getting to the results much easier to analyse, follow and understand.