Slow output

Question

Hi forums!
I have a big problem with some code, I've really hacked this down to the simplest example possible for forum use..I have a file of stuff for the printer. Average about 22 Kbytes. It's currently taking 16-17 seconds for it to print. It hangs on the line
bos.write(buff);Now, working from the port speed which I've set in windows @ 128000 kbits/s, this seems way too long. I calculate that should be about 1.4 seconds?
I can write the same file to the Parallel port and its almost instant. I'm guessing I'm doing something wrong? Any help appreciated thanks!
package paulie;
import gnu.io.CommPortIdentifier;
import gnu.io.CommPortOwnershipListener;
import gnu.io.NoSuchPortException;
import gnu.io.PortInUseException;
import gnu.io.SerialPort;
import gnu.io.UnsupportedCommOperationException;
import java.io.BufferedOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.io.OutputStream;
public class WriteDemoTextToPrinter implements CommPortOwnershipListener {
     private OutputStream os;
     private BufferedOutputStream bos;
     private CommPortIdentifier portId;
     private SerialPort serialPort;
     private String portname = "COM8";
     public static void main(String[] args){
          new WriteDemoTextToPrinter().run();
     public void run() {
          try {     
               portId = CommPortIdentifier.getPortIdentifier(portname);
               portId.addPortOwnershipListener(this);     
               serialPort = (SerialPort)portId.open("MyPortApp2", 3024);
               serialPort.setSerialPortParams(128000, SerialPort.DATABITS_8,
                         SerialPort.STOPBITS_1,
                         SerialPort.PARITY_NONE);
               os = serialPort.getOutputStream();
               bos = new BufferedOutputStream(os);     
               File f = new File ("C:\\Program Files\\testProg\\printOutput");
               FileInputStream fi= new FileInputStream (f);
               byte[] buff = new byte[25000]; //file is average 22 Kbytes
               fi.read(buff);
               fi.close();
               bos.write(buff);
               bos.flush(); os.flush(); bos.close(); os.close(); serialPort.close();
          } catch (IOException e) {
               System.out.print("WriteDemoTextToPrinter:IO Exception Caught.");
          } catch (NoSuchPortException e) {
               e.printStackTrace();
          } catch (PortInUseException e) {
               e.printStackTrace();
          } catch (UnsupportedCommOperationException e) {
               e.printStackTrace();
     @Override
     public void ownershipChange(int arg0) {
          System.out.println("OwnershipChanged : " + arg0 + ": Current owner " + portId.getCurrentOwner());
}Edited by: fenderman on Jan 29, 2010 8:55 AM
Edited by: fenderman on Jan 29, 2010 8:56 AM
Edited by: fenderman on Jan 29, 2010 8:56 AM
Edited by: fenderman on Jan 29, 2010 8:58 AM

Answer 1

               byte[] buff = new byte[25000]; //file is average 22 KbytesAs you are using buffered output and you are writing to a slow device, the size of the buffer is pretty immaterial. It doesn't need to be that large. 8k would be more than enough.
               fi.read(buff);
               fi.close();
               bos.write(buff);
               bos.flush(); os.flush(); bos.close(); os.close(); serialPort.close();As noted above, this is just plain wrong.
int count;
while ((count = fi.read(buff)) > 0)
  bos.write(buff, 0, count);
bos.close();
fis.close();All the flushes and the other closes except maybe SerialPort.close() are redundant.