Slow Update

Question

Hello everyone,
Ok, here goes. I have an update within a loop. It's updating a table, and using values from the loop for the where clause. The table is indexed, and the update is using the index. Here's the issue, after about 1000 records, it begins to slow down. I have a commit set after every 500 records. Any ideas??
update table1
set dt1 = sysdate,
val1 = 'Y'
where col1 = v_rec1.col1
and col2 = v_rec1.col2;
Any ideas would be appreciated.
Thanks!

Answer 1

Yes, you don't need PL/SQL procedural code (loops) to do this - it can and should be done in a single SQL statement as one transaction with one commit. The cursor loop and the periodic commits make it slower and consume more resources (undo, redo).
If you post more details, we can help you come up with the SQL statement. Maybe something like:
update t1
   set dt1 = sysdate, val1 = 'Y'
where (col1, col2) in (select ..., ...
                          from ...);where the select statement in the IN clause is what you have as your cursor.