Sorting values added to an array

Question

Hi,
I've written some code to sort value in an array as I add them, but I can't get it to work properly. So far I have:
public boolean add(int next)
        int last, temp, previous;
        if (size < 1) // checks whether any values have been added to determine correct value for previous.
            previous = size;
        else
            previous = size - 1;
        if (size < arraySize) //determines whether array is full or not
            last = numberList[previous];
            if (next > last)
                numberList[size] = next;
                size++;
            else if (next < last)
                temp = last;
                numberList[previous] = next;
                numberList[size] = temp;
                size++;
            numberAdded = true;
            return numberAdded;
        }Which does add the numbers, but they aren't arranged into the proper order. When I look over it I can't see anything that stands out as being wrong, so I was wondering whether anybody could see anything?
Thanks for your help,

Answer 1

endasil wrote:
nickd_101 wrote:
I don't want a loop in this case, as i want to put the values into the correct position (with respect to the previous one) as they're added into the array. Basically, my idea is that the previous value is checked against the new value and then they are swapped if the previous value is larger than the new or kept as is if not.So you're saying that if you added
1, 2, 4, 5, 3
you'd want the resultant order to be
1, 2, 4, 3, 5?
Because by your logic that's what would happen. The most that can ever happen by your logic is that a new entry would be at most 1 away from the end of the array.
P.S. use an SortedSet, given that your code doesn't allow duplicate values anyway.
Edited by: endasil on Nov 19, 2007 2:15 PMThanks for the response. What I meant is that I would eventually want it in ascending order 1,2,3,4,5. What I thought I was doing was sorting the comparing the new value with the preceding everytime a number was added so that it would always go in consecutive order. So, for example say the numbers were added to the array one by one in the order 3,5,4,1,2; 3 would be compared to 5 and there would be no change in the position. As i've typed this out i've just realised the massive logical error i've made! Could you point me in the right direction to get this to work as i'm new to this. I've managed to get a pre-defined array sorting as normal, but for this i need to sort everytime I add a new value?
Thanks again