Strange situation

Question

hello guys
i am very new to this forum section...
i am having a strange problem...i am creating a a database by connecting to oracle server of my college. i remotely login to the server through ssh. i have some text files which have fields that are to be inserted into the database.
so i used the split() function to split the fileds in the text file (having comma as a seperator)... and began inserting this way
BufferedReader br1 = new BufferedReader(new FileReader("Download.txt"));
String str1=br1.readLine();
String query2 = "create table download(" + str1 + "," + "primary key(ssn,sid)" + ")" ;
int result1 = stmt.executeUpdate(query2);
String x1;
while((x1=br1.readLine())!=null){
String [] results = x1.split(",");
String query1 = "insert into download values('" + results[0] + "','" + results[1] + "','" + results[2] + "')" ;
stmt.executeUpdate(query1);
this was good and it got updated in the database
download.txt has 3 fileds and it went well
but with this
BufferedReader br2 = new BufferedReader(new FileReader("Song.txt"));
String str2=br2.readLine();
String query3 = "create table song(" + str2 + "," + "primary key(sid)" + ")" ;
int result2 = stmt2.executeUpdate(query3);
String x2;
while((x2=br2.readLine())!=null){
String [] results = x2.split(",");
//System.out.println(results[0]+" "+results[1]+" "+results[2]+" "+results[3]);
String query1 = "insert into song values('" + results[0] + "','" + results[1] + "','" + results[2] + "','" + results[3] + "')" ;
stmt2.executeUpdate(query1);
song.txt has 4 fields and 20 rows. but when i executed this i have got an exception ora:00917 i.e.. missing comma,, but the database got updated only with first 8 rows. i used exactly the same syntax with the both..
am i missing something obvious...

Answer 1

Use a prepared statement instead of trying to construct the string dynamically.