Stuck inside an infinite While Loop :-/

Question

Hi all,
When I write this program using the top-down structural method, it runs fine but when I use the call method inside the while loop, it doesn't test the "if" condition. It becomes a never-ending loop. :-/
import java.util.Random;
public class WhileLoop {
      public static void main(String[] args) {
        int random1;
        Random die1 = new Random();
        random1 = die1.nextInt(6) + 1;
        WhileLoop r = new WhileLoop();
        while (random1 != 5) {
          if (random1 != 5) {
           r.doRandom();
          if (random1 == 5) {
            System.out.println("you win! ");
         int random1;
      public void doRandom() {
         Random die1 = new Random();
         random1 = die1.nextInt(6) + 1;
         System.out.println("random1 = " + random1);
  }If I replace the line " r.doRandom(); " with " random1 = die1.nextInt(6) + 1; System.out.println("random1 = " + random1); " the program will check the "if" condition and stops when it finds the number 5. What's wrong with my code?
Thanks for your help.

Answer 1

DrLaszloJamf wrote:
{color:#3D2B1F }You have two, unrelated variables that happen to both be named random1.{color}Opps! Must have missed it. Using two unrelated variables with the same name was, unintentional ~ //yea, right (blush). Thanks for pointing it out. :-)
Encephalopathic wrote:
you never change random1 from within the while loop. You think you do, but it's a different random1 that you're changing, a non-static one that is an instance variable.okay~ but does it mean that 'random1' from the method within the while-loop cannot be used for comparison purpose? I tried using a 'return' value from the doRandom method and use that value inside the "if" condition, but it also does not terminate the loop. The only way it's going to work is by using the solution DrLaszlo gave? Is there any other way to do this by using a call method?
Thanks!