[svn] 2622: TextBox and TextGraphic now call applyDisplayObjectProperties() at the end of their draw() method, like all other GraphicElements.

Question

Revision: 2622
Author: [email protected]
Date: 2008-07-24 16:13:32 -0700 (Thu, 24 Jul 2008)
Log Message:
TextBox and TextGraphic now call applyDisplayObjectProperties() at the end of their draw() method, like all other GraphicElements. This method handles setting the visibiliy of the GraphicElement's DisplayObject, among other things.
Note: We should make it unnecessary for each GraphicElement subclass to have to call applyDisplayObjectProperties() at the end of draw(). The GraphicElement base class should ensure that this gets called at the appropriate time.
Group now calls draw() on graphic elements even if they are invisible, because otherwise applyDisplayObjectProperties() never gets called and the TextLines stay visible. Group was assuming that the only visible stuff in a GraphicElement is drawn with Graphics calls, which isn't the case.
This change is OK for now because every GraphicElement currently has its own DisplayObject, but it will need to be rethought when GraphicElements share DisplayObjects.
Reviewer: Chet
Bug: MXMLG-206 ("Setting visible property on TextGraphic does nothing")
QA: Peter, please add a Mustella test case for the 'visible property of TextBox and TextGraphic
Doc: No
Ticket Links:
http://bugs.adobe.com/jira/browse/MXMLG-206
Modified Paths:
flex/sdk/trunk/frameworks/projects/flex4/src/flex/core/Group.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/graphics/TextBox.as
flex/sdk/trunk/frameworks/projects/flex4/src/flex/graphics/TextGraphic.as

Answer 1

Changes for spine–aligned head:
public class StickManTool extends JPanel
    public StickManTool ()
        limbs [16] = new Limb (lankle, lfoot, 1);
        head = new Head2D (limbs[0]);
    protected void paintComponent (Graphics g)
        head.draw(graphics);
    private void updateLimbs (Point start, Point end)
        head.setPosition();
class Head2D extends Ellipse2D.Double
    public static double width = 30;   // width of head
    public static double height = 40;  //height of head
    Point atlas;
    Point pelvis;
    private AffineTransform xform = new AffineTransform();
    public Head2D(Limb spine)
        super ();
        atlas = spine.movingJoint;
        pelvis = spine.fixedJoint;
        setPosition();
    public void setPosition()
        // Find angle of spine.
        double dy = atlas.y - pelvis.y;
        double dx = atlas.x - pelvis.x;
        double theta = Math.atan2(dy, dx);
        //System.out.printf("theta = %.1f%n", Math.toDegrees(theta));
        // Find center of head as extension along spine from atlas.
        double cx = atlas.x + (height/2)*Math.cos(theta);
        double cy = atlas.y + (height/2)*Math.sin(theta);
        // Move to origin of head.
        xform.setToTranslation(cx-width/2, cy-height/2);
        // Rotate head about its center.
        xform.rotate(theta+Math.PI/2, width/2, height/2);
    public void draw(Graphics2D g2)
        g2.draw(xform.createTransformedShape(this));
    public double getWidth () { return width; }
    public double getHeight () { return height; }
    public void setWidth (double widthIn) { width = widthIn; }
    public void setHeight (double heightIn) { height = heightIn; }
}