Too many values when trying insert records by bulk collect

Question

Hi
Can anyone advice on the bulk collect error please?
Following is my code where I am getting too many values error...
TYPE p_empid_type IS TABLE OF emp%ROWTYPE;
      v_empid               p_empid_type;
   BEGIN
      SELECT DISTINCT emp_id , 'ABC'
      BULK COLLECT INTO v_empid
                 FROM emp
                WHERE empid IN (SELECT ord_id
                                   FROM table_x
                                  WHERE column_x = 'ABC');
      FORALL i IN v_empid.FIRST .. v_empid.LAST
         INSERT INTO my_table
              VALUES v_empid(i);
      COMMIT;
PL/SQL: ORA-00913: too many values in line - BULK COLLECT INTO v_empid

Answer 1

Hello, since you're SELECTing a constant string, why not:
TYPE p_empid_type IS TABLE OF INTEGER;
      v_empid               p_empid_type;
   BEGIN
      SELECT DISTINCT emp_id
      BULK COLLECT INTO v_empid
                 FROM emp
                WHERE empid IN (SELECT ord_id
                                   FROM table_x
                                  WHERE column_x = 'ABC');
      FORALL i IN v_empid.FIRST .. v_empid.LAST
         INSERT INTO my_table
              VALUES v_empid(i), 'ABC';
Edit Untested: may not work
This would be the best BULK COLLECT of all:
INSERT /*+ APPEND */ INTO my_table
SELECT DISTINCT emp_id , 'ABC'
  FROM emp
WHERE empid IN (SELECT ord_id
      FROM table_x
     WHERE column_x = 'ABC');
      COMMIT;