Trigger Issue while updating same table

Question

Hi all,
I am creating one after insert trigger on table tests, which will check, if application id is null, application will be fetched from another table and update the table
tests table. But this trigger is not updating the application id of the table tests
CREATE OR REPLACE
TRIGGER TB_REC_APPL_TESTS1
AFTER INSERT ON tests FOR EACH ROW
DECLARE
v_application_id NUMBER;
v_rec_appl_tests_id NUMBER;
v_a_recruit_id NUMBER;
PRAGMA AUTONOMOUS_TRANSACTION;
BEGIN
v_rec_appl_tests_id := :NEW.rec_appl_tests_id;
v_a_recruit_id := :NEW.a_recruit_id;
IF :NEW.a_applic_id IS NULL THEN
SELECT a_applic_id INTO v_application_id FROM recruit WHERE a_recrut_id = v_a_recruit_id;
dbms_output.PUT_LINE(v_application_id||'-'||v_rec_appl_tests_id);
UPDATE tests SET a_applic_id = v_application_id
WHERE rec_appl_tests_id = v_rec_appl_tests_id;--:NEW.rec_appl_tests_id;
END IF;
commit;
END;
Thanks in advance,
Pal

Answer 1

user546710 wrote:
Hi all,
I am creating one after insert trigger on table tests, which will check, if application id is null, application will be fetched from another table and update the table
tests table. But this trigger is not updating the application id of the table tests
CREATE OR REPLACE
TRIGGER TB_REC_APPL_TESTS1
AFTER INSERT ON tests FOR EACH ROW
DECLARE
v_application_id NUMBER;
v_rec_appl_tests_id NUMBER;
v_a_recruit_id NUMBER;
PRAGMA AUTONOMOUS_TRANSACTION;
BEGIN
v_rec_appl_tests_id := :NEW.rec_appl_tests_id;
v_a_recruit_id := :NEW.a_recruit_id;
IF :NEW.a_applic_id IS NULL THEN
SELECT a_applic_id INTO v_application_id FROM recruit WHERE a_recrut_id = v_a_recruit_id;
dbms_output.PUT_LINE(v_application_id||'-'||v_rec_appl_tests_id);
UPDATE tests SET a_applic_id = v_application_id
WHERE rec_appl_tests_id = v_rec_appl_tests_id;--:NEW.rec_appl_tests_id;
END IF;
commit;
END;
Thanks in advance,
Palyou are creating triger on the table and updating it. It will not allow to update since you are firing trigger on same table.
Best practice is to use other table to update or any other operation.