Update changed records

Question

I am developing an application using forms 6i. I can save the records. I can browse my records and edit. on saving after editing i get an error that UNABLE TO INSERT RECORD. I am trying to save the same record that has some changes done on it.
In my application i have an update button and has the following script in the WHEN BUTTON PRESSED trigger
update investor set taxpayer_id = :investor.taxpayer_id, name = :investor.name, regdate = :investor.regdate, location = :investor.location,
          address1 = :investor.address1, address2 = :investor.address2, address3 = :investor.address3
          where taxpayer_id = :investor.taxpayer_id;
          commit;
          clear_form;
can any one assist me to rewrite my script so as my changes can be saved.
Note: taxpayer_id is a primary key

Answer 1

Tell us a bit more about the form block itself.
You say you can browse and edit. Is this block querying the INVESTOR table then, the one that you mention in the button PL/SQL code?
When you get the Unable to Insert record, press Display Error (usually Shift+F1) - that might help. Perhaps it's an index violation or a mandatory column missing?
Are you inserting records here via the block, or is it just query and update?
My opinion is that coding DML statements directly in the button code like this is not good practise. I always prefer to do DML from Forms transactional triggers. This gives you proper rollback control without you worrying about it. Doing your update followed by a commit in the PL/SQL might give you the Forms error "No changes to commit" if no blocks have changed. Also you are committing the entire form changes in that PL/SQL code which might not be what you are expecting?