Update in procedure

Question

This update statement works fine on its own but when it is in the procedure nothing gets updated. I was wondering why this occurs.
update table
set end_date = to_date(End_Date, 'dd-mon-rrrr'),
action_num = 51
where id = valid id
the procedure is as follows:
for cur1 in Child_Cur loop
for Cur2 in Parent_Cur(child_id) loop
end_date = cur2.end_date
update statement from above
commit
end loop
end loop
cur1 selects all the child information
cur2 selects the parent_id and end date of the parent.

Answer 1

Assuming that end_date = cur2.end_date is a typo in posting (it should be := for assignment), there may be confusion between the variable end_date and the two different columns named end_date.
Further, you are updating the parent cursor and committing inside the loop which should raise a fetch out of sequence error. I would guess that in your procedure, you have:
EXCEPTION WHEN OTHERS THEN
   NULL;or something similar that traps and mask the error. This is probalby the slowest way to do it. The updaet can (and should) be done in a single sql statement. Something like:
UPDATE parent_table p
SET end_date = (SELECT end_date
                FROM child_table c
                WHERE p.id = c.id)
WHERE p.action_num = 51 and
      EXISTS (SELECT end_date
                FROM child_table c
                WHERE p.id = c.id)TTFN
John