Uploading problem with my servlet..

Question

Hi All,
I have spent almost several hours yesterday trying to figure this out.
Here is the issue.
I have written a servlet that uploads the files, not it works flawlessly with text files but when I upload binary data then there is a 2 bytes difference beetween the actual file and the file I upload. Hence corrupting the binary files.
Can some one who might have come accross this shed some light...?
thanks again

Answer 1

Show us your code. Remember to use
[code]...[/code] tags or the "code"
button on the forum posting form.I have attached my core, I am just trying to make this work at this point so please forgive my lack of docs coding ...
import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletInputStream;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
public class TestUpload extends HttpServlet {
    private URL contextPath;
    private String FILE_SEPARATOR;
    private static final String FILE_SEPARATOR_PROPERTY = "file.separator";
    private static final String MULTIPART_BEGIN_STRING = "Content-Disposition";
    private static final String MULTIPART_CONTENT_TYPE = "Content-Type";
    private static final String MULTIPART_BOUNDARY_FLAG = "-----------------------------";
    public void init(ServletConfig servletConfig) throws ServletException {
        super.init(servletConfig);
        try {
            contextPath = servletConfig.getServletContext().getResource("/uploads");
            FILE_SEPARATOR = System.getProperty(FILE_SEPARATOR_PROPERTY);
        } catch (MalformedURLException mfe) {
            mfe.printStackTrace();
    public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        doWork(request, response);
    public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        doWork(request, response);
    public void doWork(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        processRequest(request);
        //sendResponse(request,response);
    public synchronized void processRequest(HttpServletRequest request) throws ServletException, IOException {
        ServletInputStream servletInputStream = request.getInputStream();
        FileOutputStream fileOutputStream = null;
        int buffLen = 1024;
        int lineCtr = 0;
        String boundaryStart = "", boundaryEnd = "";
        boolean isOK = true, isData = false;
        String fileName = "";
        String previousLine = "";
        byte[] prevBytes = new byte[buffLen];
        int preRead = 0;
        int pre = 0;
        byte[] inputBytes = new byte[buffLen];
        int readLen = 0;
        while ((readLen = servletInputStream.readLine(inputBytes, 0, buffLen)) > -1) {
            String line = new String(inputBytes, 0, readLen).trim();
            //System.out.println(lineCtr+" LINE - "+line);
            if (line != null && line.indexOf(MULTIPART_BOUNDARY_FLAG) > -1 && boundaryStart.equals("")) {//parse multipart data
                boundaryStart = line.trim();
                boundaryEnd = boundaryStart + "--".trim();
                System.out.println("Start Parsing:" + boundaryStart);
            } else if (line != null && line.indexOf(boundaryEnd) > -1) {//end parsing multipart data for one file
                System.out.println("End Parsing:" + boundaryEnd/*+"\nPrevious Line was = ["+previousLine.trim()+"]"*/);
                if (isData && prevBytes != null) {
                    String tline = getLine(previousLine.getBytes());
                    System.out.println(lineCtr + " WRITING LAST LINE - " + tline);
                    updateFile(tline.getBytes(), tline.getBytes().length, fileOutputStream);
                    //updateFile(prevBytes, preRead, fileOutputStream);
                closeFile(fileOutputStream, fileName);
                boundaryStart = "";
                boundaryEnd = "";
                fileName = "";
                fileOutputStream = null;
                preRead = 0;
                isData = false;
            } else {
                if (fileName.equals("") && line != null && line.indexOf(MULTIPART_BEGIN_STRING) > -1) {
                    fileName = getFileName(line);
                    fileOutputStream = createWriteFile(fileName);
                    System.out.println("fileName = " + fileName);
                } else if (!fileName.equals("") && line != null && line.indexOf(MULTIPART_CONTENT_TYPE) > -1) {
                    continue;
                } else if (isOK && line != null && line.length() == 0) {
                    continue;
                } else {
                    if (isData) {
                        //System.out.println(lineCtr+" WRITING LINE - "+ previousLine+"\nXX prevBytes="+new String(prevBytes,0,preRead));
                        updateFile(previousLine.getBytes(), preRead, fileOutputStream);
                    isOK = false;
                    isData = true;
                    previousLine = new String(inputBytes, 0, readLen);
                    preRead = previousLine.getBytes().length;//readLen;
                    //System.out.println("prevBytes = "+new String(prevBytes,0,preRead));
            lineCtr++;
        }//end of while loop
    public String getFileName(String line) {
        String fileName = "";
        if (line != null && line.indexOf("filename") > -1) {
            if (line.indexOf("\"") > -1) {
                line = line.replaceAll("\"", "");
            if (line.indexOf("\n") > -1) {
                line = line.replaceAll("\n", "");
            if (line.indexOf("\r") > -1) {
                line = line.replaceAll("\r", "");
            String[] arr = line.split(" ");
            String strA = arr[arr.length - 1];
            if (strA != null && strA.indexOf("=") > -1) {
                String[] strB = strA.split("=");
                if (strB != null && strB.length > 1) {
                    fileName = strB[strB.length - 1];
                    if (fileName.indexOf("\\") > -1) {
                        fileName = fileName.substring(fileName.lastIndexOf("\\") + 1);
                    if (fileName.indexOf("/") > -1) {
                        fileName = fileName.substring(fileName.lastIndexOf("/"));
        return fileName;
    public FileOutputStream createWriteFile(final String fileName) {
        FileOutputStream fos = null;
        if (fileName != null && !fileName.equals("")) {
            File file = new File(contextPath.getPath());
            file.mkdirs();
            //System.out.println("contextpath = "+contextPath+"\nfileName = "+fileName+"\nabsolute path = "+file.getAbsolutePath());
            try {
                String strFileName = file.getAbsolutePath() + FILE_SEPARATOR + fileName.trim();
                System.out.println("Begin: FILE Create:" + strFileName);
                fos = new FileOutputStream(new File(strFileName));
            } catch (IOException ioe) {
                ioe.printStackTrace();
        return fos;
    public void closeFile(FileOutputStream fileOutputStream, String fileName) {
        try {
            if (fileOutputStream != null) {
                fileOutputStream.flush();
                fileOutputStream.close();
                File file = new File(contextPath.getPath());
                String strFileName = file.getAbsolutePath() + FILE_SEPARATOR + fileName.trim();
                System.out.println("End: FILE Close:" + strFileName);
            } else {
                System.out.println("File objet is NULL");
        } catch (IOException ioe) {
            ioe.printStackTrace();
    public void updateFile(byte[] readData, final int readLength, FileOutputStream fileOutputStream) {
        if (fileOutputStream != null) {
            try {
                //System.out.println("LINE:"+line);
                fileOutputStream.write(readData, 0, readLength);
                //System.out.println("fileOutputStream= "+((null==fileOutputStream)?"NULL":"NOT NULL"));
            } catch (IOException ioe) {
                ioe.printStackTrace();
    private synchronized String getLine(byte[] bytes) throws IOException {
        int read = bytes.length, index;
        String line = null;
        if (read != -1) {
            line = new String(bytes, 0, read);
            if ((index = line.indexOf('\n')) >= 0) line = line.substring(0, index - 1);
            line.trim();
        return line;
}Please I hope some one can shed some light.
Its clear to me that there is a logical error thats because of my lack of understanding of the input/output stream the way its being transferred to servlet and then being parsed before written. But I have not been able to put my head around.
Thanks for any one who tries to help