Using Collections

Question

HI EXPERTS
i want to implement the below procedure using pl/sql collections can any one suggest for the followinG
create or replace procedure test_proc
is
cursor c1 is select * from temp;
cursor c1 is select * from MONITORING;
i temp%rowtype;
j MONITORING%type;
begin
open c1
loop
if (I.RES_CODE = '02' and i.CUST_ACCNO = j.CUST_ACCNO and i.CUST_MMID = j.CUST_MMID and i.CUST_MOBNO = j.CUST_MOBNO) then
Insert into APP
(CUST_ACCNO,CUST_MOBNO,CUST_MMID,REMARKS,RES_CODE)
SELECT I.CUST_ACCNO,I.CUST_MOBNO,I.CUST_MMID,i.RES_CODE,'03'
FROM temp I
WHERE EXISTS (SELECT NULL FROM MONITORING M WHERE M.CUST_ACCNO = I.CUST_ACCNO AND M.CUST_MOBNO = I.CUST_MOBNO AND M.CUST_MMID = I.CUST_MMID)
AND I.RES_CODE = '02';
elsif (I.RES_CODE = '02' and (i.CUST_ACCNO != j.CUST_ACCNO or i.CUST_MMID != j.CUST_MMID or i.CUST_MOBNO != j.CUST_MOBNO)) then
Insert into APP
(CUST_ACCNO,CUST_MOBNO,CUST_MMID,REMARKS,RES_CODE)
SELECT I.CUST_ACCNO,I.CUST_MOBNO,I.CUST_MMID,i.RES_CODE,'04'
FROM temp I
WHERE NOT EXISTS (SELECT NULL FROM MONITORING M WHERE M.CUST_ACCNO = I.CUST_ACCNO AND M.CUST_MOBNO = I.CUST_MOBNO AND M.CUST_MMID = I.CUST_MMID)
AND I.RES_CODE = '02';
elsif I.RES_CODE != '02' then
Insert into APP
(CUST_ACCNO,CUST_MOBNO,CUST_MMID,REMARKS,RES_CODE)
SELECT I.CUST_ACCNO,I.CUST_MOBNO,I.CUST_MMID,i.RES_CODE,'02'
FROM temp I
WHERE I.RES_CODE != '02';
exit whenc1
end loop;
close c1;
end;
/

Answer 1

Didn't you have a discussion just yesterday about Re: Collections:?
As was discussed in your previous thread, if the goal is to improve efficiency, it would be more efficient to get rid of the cursors and to just issue SQL statements to insert all the rows at once. Using collections may be an improvement over slow row-by-row processing but set-based processing will be even more efficient.
In yesterdays thread, multiple people showed you how to use collections. Is there some specific problem/ question that you have? Presumably, the goal of you posting here is to learn how to use collections on your own, not to post all of your procedures one at a time and ask others to rewrite them using collections.
The code you posted can't possibly compile. For example, you have two different declarations of the c1 cursor that query two completely different tables. There is an "exit whenc1" call that doesn't appear to match to any loop. Your code is also rather hard to follow since it is not formatted. If you put the tag \ (6 characteers all lower case) immediately before and after a code snippet, the forum will maintain all the spacing.  That makes the code much, much easier to read.
Justin