Using / returning double

Question

Hey peeps
after some guidance
ok, so my lecturer for programming is quite well known in the java world, although thats probs going to get shot down now :D he wrote bluej and the text book objects first. This week he set me an assignment and i have done all the base tasks and all the challenge tasks, but we get marked for comment considteny and layout of brackets etc to.
so one of the challenge tasks was to return an avergae playing time using double, is the correct way, the 100% correct way of doing this
    public double averageTrackLength()
        return (double) totalPlayingTime / tracksPlayed;
    }or does it need editing
thanks very much

Answer 1

ok, i think i worded it wrong, what i mean is, have i used the double function correctly, as in, to return a double value to you only need
public double averageTrackLength()
        return (double) totalPlayingTime / tracksPlayed;
    }becuase some people online from what i have read suggest this is how to do ti
public double divide(){
   return (double)x / (double)y;
}which is "correct"? :D
also, finally, sorry to get on all of your tits, i have a concern with my commenting, have i just over killed commenting :D
* This class is used to interact with the interface in order
* to let the user play the appropriate songs. Checks are in
* order to ensure that valid entry of selection means no
* programme crashes, and all relevant fields have been initialised.
* The track is selected by the user, then they can push play
* on the interface, once this is done, if a new track is selected
* the current track will stop, be reset to the beginning, and on
* the users selection of play, the new track shall begin. The stop
* button allwos the user to stop the track, at which point it rewinds
* it to the beginning again.
* @author Ricki Lambert
* @version 0.1 (19/10/2008)
public class Player
    private PlayList playList; //Holds an object of PlayList class
    private Track track; //Holds an object of Track class
    private int tracksPlayed; //Used to store the int sum of tracks played
    private int totalPlayingTime; //Used to store the integer value of the toal playing time
     * This is the constructor for the Player class. It sets the
     * tracksPlayed field to 0 and the same for totalPlayingTime. Also
     * it creates a new playList from the Playlist class. Every object
     * of Player will now be initialised with these fields values.
    public Player()
        playList = new PlayList("audio");
        tracksPlayed = 0;
        totalPlayingTime = 0;
     * Return the track collection currently loaded in this player.
    public PlayList getPlayList()
        return playList;
     * This method is used to play music in the G.U.I
     * The method is called, and every time this happens, the counter adds
     *one to the tracksPlayed variable. Then we check if the variable (that holds an object of Track)
     *is null. If it is we return (exit the method) to avoid crashing the programme. If not, call the stop method
     *using an internal method call, then call the play method of the track object we created. At the end, we add
     *the total length of the track to the totalPlayingTime variable.
    public void play()
        tracksPlayed = tracksPlayed + 1;
        if (track == null){
            return;
        stop();
        track.play();
        totalPlayingTime = totalPlayingTime + track.getDuration();
     * Checks to see if the track object is null, if so exit the method
     * using return, if not, call the stop method of the track object and
     * then call the rewind method to put that track to the beginning.
    public void stop()
        if (track == null){
            return;
        track.stop();
        track.rewind();
     * To set the track we check if the track object is not null.
     * Then if it is call the stop method by
     * using an internal method call. Then we just assign the
     * track object to the playlists getTrack method (this uses
     * the parameter to pass the number required to the method)
    public void setTrack(int trackNumber)
        if (track != null){
            stop();
        track = playList.getTrack(trackNumber);
     * Get the track name and return it. If the track is null
     * then return an empty string, else return the tracks name
     * by calling the objects method
    public String getTrackName()
        if (track == null){
            return "";
        else{
        return track.getName();
     * Return information about the currently selected track. The information
     * contains the track name and playing time, in the format
     *    track-name (playing time)
     * Return an empty string if no track is selected.
    public String getTrackInfo()
        if (track == null){
            return "";
        else{
        return "The track is called " + track.getName() + " The Track lasts for " +
                track.getDuration() + " seconds" ;
     * Return the integer value of the tracksPlayed variable
    public int getNumberOfTracksPlayed()
        return tracksPlayed;
     * Return the integer value of the totalPlayingTime variable
    public int getTotalPlayedTrackLength()
        return totalPlayingTime;
     * Return the result of totalPlayingTime divided by tracksPlayed
     * This is returned as a double data type value.
    public double averageTrackLength()
        return (double) totalPlayingTime / tracksPlayed;
}Edited by: compSciUndergrad on Oct 19, 2008 12:58 PM
Edited by: compSciUndergrad on Oct 19, 2008 12:58 PM