Variable losing its value

Question

Hi there,
I have written an explicit cursor (procedure given below) and the issue I have is, when the cursor runs the sql statement
(CURSOR csr_address is
SELECT rtrn_id,
entp_abn,prog_program_cd,
sched_nbr,schd_version_yr,
litm_line_item_nbr, revise_val_text
FROM RETURN_LINE_ITEMS
WHERE sched_nbr = '000'
AND prog_program_cd = '01' AND litm_line_item_nbr in ('016','023')
AND rtrn_id = v1_rtrn_id;)
against a particular return id, it fetches 2 rows; one for line item 016 and the other one for line item 023 where in the litm_line_item_nbr for 016 is 016 and for litm_line_item_nbr for 023 is 023.
Once that's done, (I have used a For loop cursor), it loops through as follows:
FOR country_rec in csr_address LOOP
v_line_item_16 := country_rec.litm_line_item_nbr;
if v_line_item_16 = '016' then
v_line_item_16 :='016'
end if;
v_line_item_23 := country_rec.litm_line_item_nbr;
if v_line_item_23 = '023' then
v_line_item_23 :='023'
end if;
-- v_temp_line_item_23:=v_line_item_23;
v_revise_val_text_16 := country_rec.revise_val_text;
v_revise_val_text_23 := country_rec.revise_val_text;
END LOOP;
When it loops for the 1st time, it does bring the value that I am looking for . Currently the value for "v_line_item_16 := country_rec.litm_line_item_nbr" is "016" and v_line_item_23 := country_rec.litm_line_item_nbr is "null". That's fine. Again it loops through for the 2nd time and then the value for v_line_item_16 := country_rec.litm_line_item_nbr becomes 023 (which is wrong and I wanted it to be blank) and then value for variable v_line_item_23 := country_rec.litm_line_item_nbr becomes 023.
Due to the above mismatch of values, I am not able to retain the original value of v_line_item_16 which should be 016 and it turns itself into 023. Is there any way around it?
Please help.
My complete code is below for easier understanding:
CREATE OR REPLACE procedure test_sandeep is
v1_bin number:=402511083;
v1_rtrn_id number:=2163180;
v_line_item_16 RETURN_LINE_ITEMS.LITM_LINE_ITEM_NBR%TYPE;
v_line_item_23 RETURN_LINE_ITEMS.LITM_LINE_ITEM_NBR%TYPE;
v_revise_val_text_16 RETURN_LINE_ITEMS.REVISE_VAL_TEXT%TYPE;
v_revise_val_text_23 RETURN_LINE_ITEMS.REVISE_VAL_TEXT%TYPE;
V_COUNTRY_CODE cg_ref_codes.rv_low_value%type;
p_ENTPBIN EDF_NOA_RETURNS.ENTP_ABN%TYPE;
-- v_temp_line_item_16 varchar2(3);
-- v_temp_line_item_23 varchar2(3);
-- v1_bin:=402511083;
-- v1_rtrn_id:=2163180;
CURSOR csr_address is
SELECT rtrn_id,
entp_abn,prog_program_cd,
sched_nbr,schd_version_yr,
litm_line_item_nbr, revise_val_text
FROM RETURN_LINE_ITEMS
WHERE sched_nbr = '000'
AND prog_program_cd = '01' AND litm_line_item_nbr in ('016','023')
AND rtrn_id = v1_rtrn_id;
Begin
-- select count
FOR country_rec in csr_address LOOP
v_line_item_16 := country_rec.litm_line_item_nbr;
if v_line_item_16 = '016' then
v_line_item_16 :='016';
end if;
v_line_item_23 := country_rec.litm_line_item_nbr;
if v_line_item_23 = '023' then
v_line_item_23 :='023';
end if;
-- v_temp_line_item_23:=v_line_item_23;
v_revise_val_text_16 := country_rec.revise_val_text;
v_revise_val_text_23 := country_rec.revise_val_text;
END LOOP;
If (v_line_item_16 = '016' and v_revise_val_text_16 is not null) and (v_line_item_23 = '023' and v_revise_val_text_23 is null) then
v_revise_val_text_16:=v_revise_val_text_16;
if v_revise_val_text_16 = 'CA' then
-- get the country Code
SELECT RV_LOW_VALUE INTO V_COUNTRY_CODE from cg_ref_codes
where rv_low_value = (select revise_val_text from return_line_items where rtrn_id = v1_rtrn_id
and revise_val_text ='CA')
and rv_domain = 'CODE COUNTRY';
end if;
-- Condition 2 :
elsif (v_line_item_16 = '016' and v_revise_val_text_16 is not null) and (v_line_item_23 = '023' and v_revise_val_text_23 is not null) then
v_revise_val_text_23 := v_revise_val_text_23;
if v_revise_val_text_23 = 'CA' then
-- get the country code
SELECT RV_LOW_VALUE INTO V_COUNTRY_CODE from cg_ref_codes
where rv_low_value = (select revise_val_text from return_line_items where rtrn_id = v1_rtrn_id
and revise_val_text ='CA')
and rv_domain = 'CODE COUNTRY';
end if;
-- Condition 3 :
elsif (v_line_item_16 = '016' and v_revise_val_text_16 is not null) and (v_line_item_23 ='023' and v_revise_val_text_23 is null) then
v_revise_val_text_16 := v_revise_val_text_16;
if v_revise_val_text_16 <> 'CA' then
-- get the country code
SELECT RV_LOW_VALUE INTO V_COUNTRY_CODE from cg_ref_codes
where rv_low_value = (select revise_val_text from return_line_items where rtrn_id = v1_rtrn_id
and revise_val_text = v_revise_val_text_16)
and rv_domain = 'CODE COUNTRY';
end if;
-- Condition 4 :
elsif (v_line_item_16 = '016' and v_revise_val_text_16 is not null) and (v_line_item_23 = '023' and v_revise_val_text_23 is not null) then
v_revise_val_text_23 := v_revise_val_text_23;
if (v_revise_val_text_16 = 'CA' and v_revise_val_text_23 <> 'CA') then
-- get the country code
SELECT RV_LOW_VALUE INTO V_COUNTRY_CODE from cg_ref_codes
where rv_low_value = (select revise_val_text from return_line_items where rtrn_id = v1_rtrn_id
and revise_val_text = v_revise_val_text_23)
and rv_domain = 'CODE COUNTRY';
end if;
-- Condition 5 :
elsif (v_line_item_16 = '016' and v_revise_val_text_16 is not null) and (v_line_item_23 = '023' and v_revise_val_text_23 is not null) then
v_revise_val_text_23 := v_revise_val_text_23;
if (v_revise_val_text_16 <> 'CA' and v_revise_val_text_23 <> 'CA') then
-- get the country code
SELECT RV_LOW_VALUE INTO V_COUNTRY_CODE from cg_ref_codes
where rv_low_value = (select revise_val_text from return_line_items where rtrn_id = v1_rtrn_id
and revise_val_text = v_revise_val_text_23)
and rv_domain = 'CODE COUNTRY';
end if;
end if;
End;
Edited by: user11934091 on Jul 21, 2010 9:43 AM

Answer 1

Because you are doing it all wrong in your loop. I assume '016' and '023' to be constants.
A better way would be to pivot your rows into columns. I am not sure what version you are using, but if is before 11g, then let's do it the old way.
Your cursor should be:
CURSOR csr_address is
WITH sub_tmp AS (
SELECT rtrn_id,
entp_abn,prog_program_cd,
sched_nbr,schd_version_yr,
litm_line_item_nbr, revise_val_text
FROM RETURN_LINE_ITEMS
WHERE sched_nbr = '000'
AND prog_program_cd = '01' AND litm_line_item_nbr in ('016','023')
AND rtrn_id = v1_rtrn_id),
qry_pivot AS (
SELECT
MAX((CASE
WHEN litm_line_item_nbr = '016' THEN litm_line_item_nbr
ESLE NULL
END)) AS line_item_16,
MAX((CASE
WHEN litm_line_item_nbr = '023' THEN litm_line_item_nbr
ESLE NULL
END)) AS line_item_23,
SELECT line_item_16, line_item_23
FROM qry_pivot;
Then from the cursor, no need to loop. You can FETCH columns line_item_16, line_item_23
Edited by: dongzky on Jul 22, 2010 7:04 PM (forgot to add MAX function