Very slow running SQL

Question

Hello I have a stored procedure that I am using to load 5 tables from a stagin table. It reads each line and populates these tables. The staging table has 200K rows in it and I commit every 10,000 rows. Once released to production the staging table will have around 23 million rows in it to be processed. It is running very poorly. I am running Oracle 9.2.0.6. Here is the stored procedure. Any suggestions on how to make it faster. Is there a way to use bulk binding/insert and would that be better?
Thank you,
David
CREATE OR REPLACE procedure SP_LOAD_STAGED_CUST (runtime_minutes int)
is
staged_rec STAGE_CUSTOMER%ROWTYPE;
end_time          date     default sysdate + (nvl(runtime_minutes,1440)/1440);
test_row_id     number(38);
in_table_cnt     number(38);
BEGIN
-- POPULATE LOCATION AND ASSOCIATE TABLES AS NEEDED
insert into TMP_LOCATION (update_location_cd, country_cd, locale_cd)
select      distinct update_location_cd,
     country_cd,
     locale_cd
from stage_customer
update TMP_Location
set location_id = location_seq.nextval
insert /*+ APPEND */ into location
( location_id, location_cd, location_desc, short_description, sales_channel_id, location_type_id,
location_category_id, addr1, addr2, addr3, city, state_cd, postal_cd, country_cd, region_id,
timezone_id, locale_cd, currency_cd, phone_num, alt_phone_num, fax_num, alt_fax_num,
email_addr, alt_email_addr, is_default, create_modify_timestamp)
select
location_id,
update_location_cd,
null,
null,
fn_sales_channel_default(),
null,
null,
null, null, null,
null, null, null ,
nvl(country_cd, 'USA'),
null, null,
locale_cd,
'USD',
null, null, null, null, null, null,
0,
sysdate
from TMP_LOCATION
where update_location_cd not in (select location_cd from location);
commit
insert into TMP_ASSOCIATE (associate_number, update_location_cd)
select      associate_number, min(update_location_cd)
     from stage_customer
where associate_number is not null
group by associate_number;
update TMP_ASSOCIATE
set associate_id = associate_seq.nextval
insert /*+ APPEND */ into associate
select
associate_id ,
null,
associate_number,
(select nvl(location_id, fn_location_default())
     from location
     where location.location_cd = tmp_associate.update_location_cd)
from TMP_ASSOCIATE
where not exists (select associate_id from associate
          where associate.associate_number = tmp_associate.associate_number)
delete from tmp_associate;
commit;
insert into TMP_ASSOCIATE (associate_number, update_location_cd)
select      alt_associate_number, min(update_location_cd)
     from stage_customer
where alt_associate_number is not null
group by alt_associate_number
update TMP_ASSOCIATE
set associate_id = associate_seq.nextval
insert /*+ APPEND */ into associate
select
associate_id ,
null,
associate_number,
(select nvl(location_id, fn_location_default())
     from location
     where location.location_cd = tmp_associate.update_location_cd)
from TMP_ASSOCIATE
where not exists (select associate_id from associate
          where associate.associate_number = tmp_associate.associate_number);
commit;
select min(row_id) -1 into test_row_id from stage_customer ;
WHILE sysdate < end_time
LOOP
select *
into staged_rec
from Stage_Customer
where row_id = test_row_id + 1;
if staged_rec.row_id is null
then
COMMIT;
EXIT;
end if;
-- EXIT WHEN staged_rec.row_id is null;
-- INSERTS TO CUSTOMER TABLE (IN LOOP - DATA FROM STAGE CUSTOMER TABLE)
insert /*+ APPEND */ into customer (
     customer_id,
     customer_acct_num,
     account_type_id,
     acct_status,
     discount_percent,
     discount_code,
     uses_purch_order,     
     business_name,
     tax_exempt_prompt,
     is_deleted,
     name_prefix,
     first_name,
     middle_name,
     last_name,
     name_suffix,
     nick_name,
     alt_first_name,
     alt_last_name,
     marketing_source_id,
     country_cd,
     locale_cd,
     email_addr,
     email_addr_valid,
     alt_email_addr,
     alt_email_addr_valid,
     birth_date,
     acquisition_sales_channel_id,
     acquisition_location_id,
     home_location_id,
     salesperson_id,
     alt_salesperson_id,
     customer_login_name,
     age_range_id,
     demographic_role_id,
     education_level_id,
     gender_id,
     household_count_id,
     housing_type_id,
     income_range_id,
     lifecycle_type_id,
     lifetime_value_score_id,
     marital_status_id,
     religious_affil_id
values (      
     staged_rec.row_id,
     staged_rec.customer_acct_num,
     nvl(staged_rec.account_type_id, fn_account_type_default()),
     1,
     staged_rec.discount_percent,
     staged_rec.discount_cd,
     staged_rec.pos_allow_purchase_order_flag,
     staged_rec.business_name,
     staged_rec.pos_tax_prompt,
     staged_rec.is_deleted,
     staged_rec.name_prefix,
     staged_rec.first_name,
     staged_rec.middle_name,
     staged_rec.last_name,
     staged_rec.name_suffix,
     staged_rec.nick_name,
     staged_rec.alt_first_name,
     staged_rec.alt_last_name,
     staged_rec.new_marketing_source_id,
     staged_rec.country_cd,
     staged_rec.locale_cd,
     staged_rec.email_addr,
     nvl2(staged_rec.email_addr,1,0),
     staged_rec.alt_email_addr,
     nvl2(staged_rec.alt_email_addr,1,0),
     staged_rec.birth_date,
     staged_rec.SALES_CHANNEL_ID,
     (select location_id from location where location_cd = staged_rec.update_location_cd),
     (select location_id from location where location_cd = staged_rec.update_location_cd),
     (select min(a.associate_id) from associate a
          where staged_rec.associate_number = a.associate_number
          and a.location_id =
               (select location_id from location where location_cd = staged_rec.update_location_cd)),
     (select min(a.associate_id) from associate a
          where staged_rec.alt_associate_number = a.associate_number
          and a.location_id =
               (select location_id from location where location_cd = staged_rec.update_location_cd)),
     staged_rec.customer_login_name,
     fn_age_range_default(),
     fn_demographic_role_default(),
     fn_education_level_default(),
     fn_gender_default(),
     fn_household_cnt_default(),
     fn_housing_type_default(),
     fn_income_range_default(),
     fn_lifecycle_type_default(),
     fn_lifetime_val_score_default(),
     fn_marital_status_default(),
     fn_religious_affil_default()
-- INSERTS TO PHONE TABLE ( IN LOOP -DATA FROM STAGE CUSTOMER TABLE)
if staged_rec.home_phone is not null
then
insert /*+ APPEND */ into phone ( customer_id, phone_type_id, phone_num, is_valid, is_primary)
     values (staged_rec.row_id, 1, staged_rec.home_phone, 1, 1);
end if;
if staged_rec.work_phone is not null
then
insert /*+ APPEND */ into phone (customer_id, phone_type_id, phone_num, is_valid,is_primary)
     values (staged_rec.row_id, 2, staged_rec.work_phone, 1, 0);
end if;
if staged_rec.mobile_phone is not null
then
insert /*+ APPEND */ into phone ( customer_id, phone_type_id, phone_num, is_valid, is_primary)
     values (staged_rec.row_id, 3, staged_rec.home_phone, 1, 0);
end if;
if staged_rec.work_phone is not null
then
insert /*+ APPEND */ into phone (customer_id, phone_type_id, phone_num, is_valid,is_primary)
     values (staged_rec.row_id, 4, staged_rec.work_phone, 1, 0);
end if;
-- INSERTS TO CUSTOMER ADDR TABLE ( IN LOOP - DATA FROM STAGE CUSTOMER TABLE)
if staged_rec.address1 is not null
then
insert /*+ APPEND */ into customer_addr (customer_id, address_type_id, address1, address2, address3, city, state_cd, postal_cd, country_cd, region_id,
               is_primary, is_valid, cannot_standardize, is_standardized)
     values (staged_rec.row_id, fn_address_type_default(), staged_rec.address1, staged_rec.address2, staged_rec.address3,
          staged_rec.city, staged_rec.state_cd, staged_rec.postal_cd, staged_rec.country_cd, staged_rec.region, 1, 1, 0, 0);
end if;
-- INSERTS TO CUSTOMER_STATE_TAX_ID
if staged_rec.pos_default_tax_id is not null
then
insert /*+ APPEND */ into customer_state_tax_id (state_cd, customer_id, tax_id, expiration_date)
     values (staged_rec.state_cd, staged_rec.row_id, staged_rec.pos_default_tax_id,
          staged_rec.pos_tax_id_expiration_date);
end if;
-- REMOVE STAGE CUSTOMER ROW (IN LOOP - DELETE CUSTOMER FROM STAGE_CUSTOMER TABLE)
delete from stage_customer
where row_id = staged_rec.row_id;
-- COMMIT AFTER EVERY 10,000 CUSTOMERS
if mod(staged_rec.row_id, 100) = 0
then
commit;
end if;
-- INCREMENT ROW ID TO BE RETRIEVED
test_row_id := test_row_id + 1;
END LOOP;
EXCEPTION
     WHEN NO_DATA_FOUND
     THEN
     COMMIT;
END;
Message was edited by:
JesusLuvR
Message was edited by:
JesusLuvR

Answer 1

You want to do as much processing as you can in single large sql statements, not row by row. You also want to do as few statemetns as possible. Most of what you are doing looks to me like it could be done as a series of single sql statements. For example, the three statements that populate location ca nbe condensed to a single statement like:
INSERT /*+ APPEND */ INTO location
   (location_id, location_cd, location_desc, short_description, sales_channel_id,
    location_type_id, location_category_id, addr1, addr2, addr3, city, state_cd,
    postal_cd, country_cd, region_id, timezone_id, locale_cd, currency_cd,
    phone_num, alt_phone_num, fax_num, alt_fax_num, email_addr, alt_email_addr,
    is_default, create_modify_timestamp)
SELECT location_seq.NEXTVAL, update_location_cd, NULL, NULL,
       fn_sales_channel_default(), NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
       NVL(country_cd, 'USA'), NULL, NULL, locale_cd, 'USD', NULL, NULL, NULL,
       NULL, NULL, NULL, 0, sysdate
FROM (SELECT DISTINCT update_location_cd, country_cd, locale_cd
      FROM stage_customer
      WHERE update_location_cd NOT IN (SELECT location_cd FROM location);You can easily do a similar change to the statemetns populating associates.
I don't, off hand, see anything in the intert into customers that seems to require row by row processing. Just do it in a large insert. I would also be tempted to replace the many values of the form (select location_id from location where location_cd = staged_rec.update_location_cd) to a join with location. As far as I can see, you would only need one copy of location.
I also notince that you have a number of function calls in the values list. I would look carefully at whether you need them at all, since they seem to have no parameters, so should return the same value every time. Minimally, I would consider calling them once each, storing the values in variables and use those variables in the insert.
HTH
John