VMware PowerCli PowerShell Script - Stack Functions

Question

   
Using this as a starting block.
http://pubs.vmware.com/view-52/index.jsp?topic=%2Fcom.vmware.view.integration.doc%2Fview_integration_powershell.5.7.html
I want to combine two of the functions, and have the variables use ".txt" files with my new and old datastores listed.
I've edited it a bit, combining the two functions, and creating variables for new and old lists, but I'm not sure if the context I used is correct, or if I can just paste the functions together like this.
Before I run this against my VMware View Connection server, anything stand out as wrong?
# A PowerShell function to add new, then remove old datastores from an automatic pool.
# UpdateDatastoresForAutomaticPool
# Parameters
# $Pool Pool ID of pool to be updated.
# $OldDatastore Full path to OldDatastore.txt to be removed.
# $NewDatastore Full path to NewDatastore.txt to be added.
$Pool = "C:\powercli\PersistentPools.txt"
$OldDatastore = "C:\powercli\OldDatastore.txt"
$NewDatastore = "C:\powercli\NewDatastore.txt"
function RemoveDatastoreFromAutomaticPool
{ param ($Pool, $OldDatastore)
$PoolSettings = (Get-Pool -pool_id $Pool)
$currentdatastores = $PoolSettings.datastorePaths
$datastores = ""
foreach ($path in $currentdatastores.split(";")){
if(-not ($path -eq $OldDatastore)){
$datastores = $datastores + "$path;"
Update-AutomaticPool -pool_id $Pool -datastorePaths $datastores
function AddDatastoreToAutomaticPool
{ param ($Pool, $NewDatastore)
$PoolSettings = (Get-Pool -pool_id $Pool)
$datastores = $PoolSettings.datastorePaths + ";$NewDatastore"
Update-AutomaticPool -pool_id $Pool -datastorePaths $datastores
Thanks,
-Matt
There's no place like 127.0.0.1

Answer 1

Other than the specific commandlets of "Update-AutomaticPool -pool_id -datastorePaths", this is PowerShell script, right?
I'm not looking for support for the functions themselves.  But VMware only gives these scripts as individual functions.
I want to stack their functions one after another in a script, and use text files with lists of data, instead of specifying them one at a time to the script.
Function 1 as supplied by VMware
Define a PowerShell function to add a datastore to an automatic pool.
# AddDatastoreToAutomaticPool
# Parameters
# $Pool Pool ID of pool to be updated.
# $Datastore Full path to datastore to be added.
function AddDatastoreToAutomaticPool
{ param ($Pool, $Datastore)
$PoolSettings = (Get-Pool -pool_id $Pool)
$datastores = $PoolSettings.datastorePaths + ";$Datastore"
Update-AutomaticPool -pool_id $Pool -datastorePaths $datastores
Function 2 as supplied by VMware
Define a PowerShell function to add a datastore to an automatic pool.
# AddDatastoreToAutomaticPool
# Parameters
# $Pool Pool ID of pool to be updated.
# $Datastore Full path to datastore to be added.
function AddDatastoreToAutomaticPool
{ param ($Pool, $Datastore)
$PoolSettings = (Get-Pool -pool_id $Pool)
$datastores = $PoolSettings.datastorePaths + ";$Datastore"
Update-AutomaticPool -pool_id $Pool -datastorePaths $datastores
I'm just looking for advise as to weather I'm approaching this from the right angle.
In my original post I made an attempt at pasting them together, then editing the parameter lines to use a text file instead of supplying an individual entry on the cmd line with the script.   I think I did it right, but I'm not sure if the way these
functions are written, that they will parse through each of the text files.
Thanks,
-Matt
There's no place like 127.0.0.1