What's Rong This Procedure

Question

create or replace PROCEDURE multi_lots (
--errbuf    OUT    VARCHAR2,
                    --retcode   OUT    NUMBER,
                   --  p_item_id IN NUMBER ,
                     p_lot_number in varchar2 ,
                     p_no_of_lots in number ) AS
                    -- p_qty in number,
                   --  p_grade in varchar2) AS
    cursor c1 is
select *
    from mtl_lot_numbers
    where
    lot_number = p_lot_number;
    --v_temp c1%rowtype;
    per_count number:=0;
  BEGIN
             for i in c1
loop
  /*insert into generate_multi_lots
  (no_of_lots  , qty, grade , item_id,lot_number)
  values
  (p_no_of_lots,p_qty/p_no_of_lots,p_grade,p_item_id,p_lot_number||' - '||i);
insert into xyz
-- (grade_code , inventory_item_id,lot_number , organization_id , last_update_date , last_updated_by , creation_date , created_by )
(INVENTORY_ITEM_ID,
ORGANIZATION_ID,
LOT_NUMBER,
LAST_UPDATE_DATE,
LAST_UPDATED_BY,
CREATION_DATE,
CREATED_BY)
values
(I.INVENTORY_ITEM_ID,i.organization_id,
p_lot_number,
i.LAST_UPDATE_DATE,
i.LAST_UPDATED_BY,
i.CREATION_DATE,
i.CREATED_BY);
-- values
  --(p_grade,p_item_id,p_lot_number||' - '||i , '500' , sysdate,2 , sysdate ,3);
  commit;
per_count := per_count + 1;
     EXIT WHEN per_count = p_no_of_lots;
END loop;
end;this is my query for insert thru procedure..
if i passed no_of_lots for example 2 then 2 lines shud be insert but the problem is only 1 line insert if i passed n e value in parameter..
what's rong??
plzZ hElp

Answer 1

From your code, you loop is based on the SQL
select *
from mtl_lot_numbers
where
lot_number = p_lot_number;
Check for the parameter p_lot_number, how many records exist....I guess it would be 1 for all the lot numbers. That's why the loop ends up before checking the exit condition. Also check the values of p_lot_number, p_no_of_lots...
Other wsie change the loop count from cursor to p_no oflots which you are not using anywhere else
For i in 1..p_no_lots
end loop
Edited by: SBH on Jun 29, 2010 12:10 AM