Why do I get this Out of memory, how can I prevent it?

Question

Hello
I have an annoying problem that never has occured before....
I use JSP with Beans, I know that the problem lies in my method "setIntotable()"
because its just that method that is called in current JSP-page when I get this Out of Memory error.
All information regarding matches+players are stored in a mysql-database
When I'm about to summerize everything and create a new "table" with fresh data+ranking I get this Out of memory error. I havent made any changes so I think its strange that I suddenly get this error. Below is my syntax:
......................syntax for method "setIntotable()".........................................
public void setIntotable(){
int noOfRows;
String fnamn1 = "";
String enamn1 = "";
String fnamn2 = "";
String enamn2 = "";
Vector matcher = new Vector();
matcher = readTider();
Vector players = getPlayers();
Player player1 = new Player();
Player player2 = new Player();
try {
Connection con2 = DriverManager.getConnection(fileURL, "", "");
Statement u = con2.createStatement();
String s = "TRUNCATE TABLE totaltiddiv";
u.execute(s);
u.close();
con2.close();
int q = 1;
Connection con = DriverManager.getConnection(fileURL, "", "");
Statement updateStatement = con.createStatement();
for (int i = 0; i < matcher.size(); i++) { //matcher  has a 200<size
Totaltid t = (Totaltid) matcher.elementAt(i); //Se below which parameters Totaltiddiv has
String query1 = "INSERT INTO totaltiddiv VALUES('" + t.tidnr + "','" +
t.tidnrinv + "','" + q + "','" + t.bana + "','" + t.tid + "','" +
t.datum + "','" + Integer.toString(Integer.parseInt(t.division)) +
"','" + t.matchindex + "','" + Integer.parseInt(t.division) + "','" +
0 + "','" + "','','" + "','" + "','','" + "','" + "','" + "div" +
Integer.toString(Integer.parseInt(t.division)) + "rank" +
t.matchindex.substring(0, 1) + "','" + "div" +
Integer.toString(Integer.parseInt(t.division)) + "rank" +
t.matchindex.substring(1, 2) + "','" + "','" + "','" + "','" +
"','" + "','" + "','" + "','" + "','" + "','" + "','" + "')";
noOfRows = updateStatement.executeUpdate(query1);
q++;
updateStatement.close();
Statement selectStatement = con.createStatement();
for (int i = 0; i < matcher.size(); i++) {
Totaltid t = (Totaltid) matcher.elementAt(i);
String query2 = "SELECT * FROM playerdiv WHERE totalkey='" + t.p1key +
ResultSet rs2 = selectStatement.executeQuery(query2);
while (rs2.next()) {
fnamn1 = rs2.getString("fnamn");
enamn1 = rs2.getString("enamn");
rs2.close();
String query3 = "SELECT * FROM playerdiv WHERE totalkey='" + t.p2key +
ResultSet rs3 = selectStatement.executeQuery(query3);
while (rs3.next()) {
fnamn2 = rs3.getString("fnamn");
enamn2 = rs3.getString("enamn");
rs3.close();
selectStatement.close();
String update = "UPDATE totaltiddiv SET p1fnamn='" + fnamn1 +
"', p1enamn='" + enamn1 + "', p2fnamn='" + fnamn2 + "', p2enamn='" +
enamn2 + "' WHERE p1key='" + t.p1key + "' AND p2key='" + t.p2key +
System.out.println(update);
noOfRows = updateStatement.executeUpdate(update);
updateStatement.close();
con.close();
catch (SQLException sqe) {
System.out.println(sqe);
------------------------------Tottaltiddiv-----------------------------------------------
public String tidnr;
public String tidnrinv;
public String idnr;
public int bana;
public String tid;
public String datum;
public String division;
public String matchindex;
public int tiddiv;
public boolean ledig;
public int rank;
public String p1fnamn;
public String p1enamn;
public String p2fnamn;
public String p2enamn;
public String p1key;
public String p2key;
public int set11;
public int set12;
public int set21;
public int set22;
public int tie1;
public int tie2;
public boolean wo1;
public boolean wo2;
public boolean spelad;
public String wonevenloss;
public int diff;
Every parameter above is in range of 1-50 charachters
I cant see what should bee "eating" all the memory?
Would be very glad if anyone could help me.....
Thanks in advance /D_S

Answer 1

That's some ugly procedural code you've written there. What is this, VB?
Well-decomposed code would say write short methods that each do one thing well.
If I were you, I'd decompose this method into several and test each one individually.
One advantage of this will be narrower scope. The garbage collector will have a chance to clean up some of your mess that way.
I don't know what all those declared variables at the bottom are about. Are those class members or something? Why are they all public?
Please don't tell me this is scriptlet code in a JSP...
%